Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] dma: fix /etc/dma/*.conf permissions
@ 2021-12-09 21:00 loreb
  2021-12-09 21:13 ` loreb
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: loreb @ 2021-12-09 21:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 667 bytes --]

There is a new pull request by loreb against master on the void-packages repository

https://github.com/loreb/void-packages dma-34431
https://github.com/void-linux/void-packages/pull/34451

dma: fix /etc/dma/*.conf permissions
Fixes https://github.com/void-linux/void-packages/issues/34431;
solution due to thenktor

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86-64-musl)


A patch file from https://github.com/void-linux/void-packages/pull/34451.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dma-34431-34451.patch --]
[-- Type: text/x-diff, Size: 1158 bytes --]

From 0d69c102fa4ffe349d8574c81d9cee424e6ee0a5 Mon Sep 17 00:00:00 2001
From: Lorenzo Beretta <vc.net.loreb@gmail.com>
Date: Thu, 9 Dec 2021 21:46:24 +0100
Subject: [PATCH] dma: fix /etc/dma/*.conf permissions

Fixes https://github.com/void-linux/void-packages/issues/34431;
solution due to thenktor
---
 srcpkgs/dma/INSTALL  | 1 +
 srcpkgs/dma/template | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/dma/INSTALL b/srcpkgs/dma/INSTALL
index 88bfc22cca11..e35876f94cf6 100644
--- a/srcpkgs/dma/INSTALL
+++ b/srcpkgs/dma/INSTALL
@@ -2,6 +2,7 @@ case ${ACTION} in
 post)
 	# fix permissions and owners
 	chown root:mail usr/bin/dma
+	chown root:mail etc/dma/auth.conf etc/dma/dma.conf
 	chmod 2755 usr/bin/dma
 	chown root:mail usr/lib/dma-mbox-create
 	chmod 4754 usr/lib/dma-mbox-create
diff --git a/srcpkgs/dma/template b/srcpkgs/dma/template
index 71892496013f..78c71595ec15 100644
--- a/srcpkgs/dma/template
+++ b/srcpkgs/dma/template
@@ -1,7 +1,7 @@
 # Template file for 'dma'
 pkgname=dma
 version=0.13
-revision=3
+revision=4
 conf_files="/etc/dma/*.conf"
 make_dirs="/var/spool/dma 2775 root mail"
 hostmakedepends="flex"

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: dma: fix /etc/dma/*.conf permissions
  2021-12-09 21:00 [PR PATCH] dma: fix /etc/dma/*.conf permissions loreb
@ 2021-12-09 21:13 ` loreb
  2021-12-09 21:20 ` loreb
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: loreb @ 2021-12-09 21:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1457 bytes --]

New comment by loreb on void-packages repository

https://github.com/void-linux/void-packages/pull/34451#issuecomment-990259190

Comment:
Btw, in case anyone wants to take a look, there were a couple of compilation warnings:

```
net.c: In function 'read_remote.part.0':
net.c:159:6: warning: 'strncpy' specified bound 1024 equals destination size [-Wstringop-truncation]
  159 |      strncpy(neterr, strerror(errno), sizeof(neterr));
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net.c:154:6: warning: 'strncpy' specified bound 1024 equals destination size [-Wstringop-truncation]
  154 |      strncpy(neterr, ssl_errstr(), sizeof(neterr));
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net.c:168:4: warning: 'strncat' output may be truncated copying between 0 and 1023 bytes from a string of length 2047 [-Wstringop-truncation]
  168 |    strncat(neterr, buff, copysize);
      |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net.c: In function 'send_remote_command':
net.c:104:5: warning: 'strncpy' specified bound 1024 equals destination size [-Wstringop-truncation]
  104 |     strncpy(neterr, ssl_errstr(), sizeof(neterr));
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

```

They were fixed upstream in February 2020 (strncpy=>strlcpy), except that it looks to me that the 2047=>1023 is still there (strncat) and replacing it with strlcat would silence the warning without actually fixing the issue.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: dma: fix /etc/dma/*.conf permissions
  2021-12-09 21:00 [PR PATCH] dma: fix /etc/dma/*.conf permissions loreb
  2021-12-09 21:13 ` loreb
@ 2021-12-09 21:20 ` loreb
  2022-06-18  2:13 ` github-actions
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: loreb @ 2021-12-09 21:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New comment by loreb on void-packages repository

https://github.com/void-linux/void-packages/pull/34451#issuecomment-990267930

Comment:
Urgh... upstream set -Wno-format-truncation, reenabling it shows some extra snprintf warnings which I'm not looking into, at least right now.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: dma: fix /etc/dma/*.conf permissions
  2021-12-09 21:00 [PR PATCH] dma: fix /etc/dma/*.conf permissions loreb
  2021-12-09 21:13 ` loreb
  2021-12-09 21:20 ` loreb
@ 2022-06-18  2:13 ` github-actions
  2022-06-18 12:17 ` loreb
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: github-actions @ 2022-06-18  2:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/34451#issuecomment-1159340177

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: dma: fix /etc/dma/*.conf permissions
  2021-12-09 21:00 [PR PATCH] dma: fix /etc/dma/*.conf permissions loreb
                   ` (2 preceding siblings ...)
  2022-06-18  2:13 ` github-actions
@ 2022-06-18 12:17 ` loreb
  2022-09-18  2:15 ` github-actions
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: loreb @ 2022-06-18 12:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]

New comment by loreb on void-packages repository

https://github.com/void-linux/void-packages/pull/34451#issuecomment-1159454803

Comment:
bump

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: dma: fix /etc/dma/*.conf permissions
  2021-12-09 21:00 [PR PATCH] dma: fix /etc/dma/*.conf permissions loreb
                   ` (3 preceding siblings ...)
  2022-06-18 12:17 ` loreb
@ 2022-09-18  2:15 ` github-actions
  2022-09-18 18:14 ` loreb
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: github-actions @ 2022-09-18  2:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/34451#issuecomment-1250175479

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: dma: fix /etc/dma/*.conf permissions
  2021-12-09 21:00 [PR PATCH] dma: fix /etc/dma/*.conf permissions loreb
                   ` (4 preceding siblings ...)
  2022-09-18  2:15 ` github-actions
@ 2022-09-18 18:14 ` loreb
  2022-09-18 19:31 ` classabbyamp
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: loreb @ 2022-09-18 18:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]

New comment by loreb on void-packages repository

https://github.com/void-linux/void-packages/pull/34451#issuecomment-1250359998

Comment:
bump

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: dma: fix /etc/dma/*.conf permissions
  2021-12-09 21:00 [PR PATCH] dma: fix /etc/dma/*.conf permissions loreb
                   ` (5 preceding siblings ...)
  2022-09-18 18:14 ` loreb
@ 2022-09-18 19:31 ` classabbyamp
  2022-09-18 19:55 ` [PR PATCH] [Updated] " loreb
  2022-09-18 20:12 ` [PR PATCH] [Merged]: " classabbyamp
  8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2022-09-18 19:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/34451#issuecomment-1250372313

Comment:
can you rebase this? 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] dma: fix /etc/dma/*.conf permissions
  2021-12-09 21:00 [PR PATCH] dma: fix /etc/dma/*.conf permissions loreb
                   ` (6 preceding siblings ...)
  2022-09-18 19:31 ` classabbyamp
@ 2022-09-18 19:55 ` loreb
  2022-09-18 20:12 ` [PR PATCH] [Merged]: " classabbyamp
  8 siblings, 0 replies; 10+ messages in thread
From: loreb @ 2022-09-18 19:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

There is an updated pull request by loreb against master on the void-packages repository

https://github.com/loreb/void-packages dma-34431
https://github.com/void-linux/void-packages/pull/34451

dma: fix /etc/dma/*.conf permissions
Fixes https://github.com/void-linux/void-packages/issues/34431;
solution due to thenktor

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86-64-musl)


A patch file from https://github.com/void-linux/void-packages/pull/34451.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dma-34431-34451.patch --]
[-- Type: text/x-diff, Size: 1158 bytes --]

From f0dd1981a9ddd0c0a1c77e0a1e4b16ae26a22e9a Mon Sep 17 00:00:00 2001
From: Lorenzo Beretta <vc.net.loreb@gmail.com>
Date: Thu, 9 Dec 2021 21:46:24 +0100
Subject: [PATCH] dma: fix /etc/dma/*.conf permissions

Fixes https://github.com/void-linux/void-packages/issues/34431;
solution due to thenktor
---
 srcpkgs/dma/INSTALL  | 1 +
 srcpkgs/dma/template | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/dma/INSTALL b/srcpkgs/dma/INSTALL
index 88bfc22cca11..e35876f94cf6 100644
--- a/srcpkgs/dma/INSTALL
+++ b/srcpkgs/dma/INSTALL
@@ -2,6 +2,7 @@ case ${ACTION} in
 post)
 	# fix permissions and owners
 	chown root:mail usr/bin/dma
+	chown root:mail etc/dma/auth.conf etc/dma/dma.conf
 	chmod 2755 usr/bin/dma
 	chown root:mail usr/lib/dma-mbox-create
 	chmod 4754 usr/lib/dma-mbox-create
diff --git a/srcpkgs/dma/template b/srcpkgs/dma/template
index 71892496013f..78c71595ec15 100644
--- a/srcpkgs/dma/template
+++ b/srcpkgs/dma/template
@@ -1,7 +1,7 @@
 # Template file for 'dma'
 pkgname=dma
 version=0.13
-revision=3
+revision=4
 conf_files="/etc/dma/*.conf"
 make_dirs="/var/spool/dma 2775 root mail"
 hostmakedepends="flex"

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Merged]: dma: fix /etc/dma/*.conf permissions
  2021-12-09 21:00 [PR PATCH] dma: fix /etc/dma/*.conf permissions loreb
                   ` (7 preceding siblings ...)
  2022-09-18 19:55 ` [PR PATCH] [Updated] " loreb
@ 2022-09-18 20:12 ` classabbyamp
  8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2022-09-18 20:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

There's a merged pull request on the void-packages repository

dma: fix /etc/dma/*.conf permissions
https://github.com/void-linux/void-packages/pull/34451

Description:
Fixes https://github.com/void-linux/void-packages/issues/34431;
solution due to thenktor

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86-64-musl)


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-09-18 20:12 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-09 21:00 [PR PATCH] dma: fix /etc/dma/*.conf permissions loreb
2021-12-09 21:13 ` loreb
2021-12-09 21:20 ` loreb
2022-06-18  2:13 ` github-actions
2022-06-18 12:17 ` loreb
2022-09-18  2:15 ` github-actions
2022-09-18 18:14 ` loreb
2022-09-18 19:31 ` classabbyamp
2022-09-18 19:55 ` [PR PATCH] [Updated] " loreb
2022-09-18 20:12 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).