[PR PATCH] python3-bibtexparser: update to 1.2.0.

[PR PATCH] python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

There is a new pull request by jgarte against master on the void-packages repository

https://github.com/jgarte/void-packages python3-bibtexparser
https://github.com/void-linux/void-packages/pull/34299

python3-bibtexparser: update to 1.2.0.
#### Testing the changes
- I tested the changes in this PR: briefly

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/34299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-bibtexparser-34299.patch --]
[-- Type: text/x-diff, Size: 1135 bytes --]

From a1cb9f74423d3ec260acc8de993e2a90ff872039 Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Mon, 29 Nov 2021 01:00:56 -0500
Subject: [PATCH] python3-bibtexparser: update to 1.2.0.

---
 srcpkgs/python3-bibtexparser/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-bibtexparser/template b/srcpkgs/python3-bibtexparser/template
index aa6651428b66..56831a4f467a 100644
--- a/srcpkgs/python3-bibtexparser/template
+++ b/srcpkgs/python3-bibtexparser/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-bibtexparser'
 pkgname=python3-bibtexparser
-version=1.1.0
-revision=5
+version=1.2.0
+revision=6
 wrksrc="bibtexparser-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
@@ -11,4 +11,4 @@ maintainer="xaltsc <xaltsc@protonmail.ch>"
 license="LGPL-3.0-only"
 homepage="https://github.com/sciunto-org/python-bibtexparser"
 distfiles="${PYPI_SITE}/b/bibtexparser/bibtexparser-${version}.tar.gz"
-checksum=df8966ea752db6d74657a69b9d684a61aa33457ad6d9d50e41c50ef7f374907f
+checksum=0f9ab94e3fc36ee2ee6a3713c5dd7320d4b6ee52bd66ecbab03c6b06675ae410

Re: [PR PATCH] [Updated] python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

There is an updated pull request by jgarte against master on the void-packages repository

https://github.com/jgarte/void-packages python3-bibtexparser
https://github.com/void-linux/void-packages/pull/34299

python3-bibtexparser: update to 1.2.0.
#### Testing the changes
- I tested the changes in this PR: briefly

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/34299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-bibtexparser-34299.patch --]
[-- Type: text/x-diff, Size: 1135 bytes --]

From 155282c01d0abf3c784985f4a535e037b899aeb3 Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Mon, 29 Nov 2021 01:00:56 -0500
Subject: [PATCH] python3-bibtexparser: update to 1.2.0.

---
 srcpkgs/python3-bibtexparser/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-bibtexparser/template b/srcpkgs/python3-bibtexparser/template
index aa6651428b66..8a073d146fa0 100644
--- a/srcpkgs/python3-bibtexparser/template
+++ b/srcpkgs/python3-bibtexparser/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-bibtexparser'
 pkgname=python3-bibtexparser
-version=1.1.0
-revision=5
+version=1.2.0
+revision=1
 wrksrc="bibtexparser-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
@@ -11,4 +11,4 @@ maintainer="xaltsc <xaltsc@protonmail.ch>"
 license="LGPL-3.0-only"
 homepage="https://github.com/sciunto-org/python-bibtexparser"
 distfiles="${PYPI_SITE}/b/bibtexparser/bibtexparser-${version}.tar.gz"
-checksum=df8966ea752db6d74657a69b9d684a61aa33457ad6d9d50e41c50ef7f374907f
+checksum=0f9ab94e3fc36ee2ee6a3713c5dd7320d4b6ee52bd66ecbab03c6b06675ae410

Re: python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New comment by jgarte on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#issuecomment-981374620

Comment:
@ericonr 

This built locally on my machine and I was able to import the library in a repl.

Not sure what's going on with ci...

Re: [PR REVIEW] python3-bibtexparser: update to 1.2.0.

[dotnetfox]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New review comment by dotnetfox on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#discussion_r758510986

Comment:
```suggestion
hostmakedepends="python3-setuptools python3-pip python3-wheel"
```

Append these two packages.

Re: [PR REVIEW] python3-bibtexparser: update to 1.2.0.

[dotnetfox]

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

New review comment by dotnetfox on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#discussion_r758510986

Comment:
Append these two packages.

```suggestion
hostmakedepends="python3-setuptools python3-pip python3-wheel"
```

Re: [PR REVIEW] python3-bibtexparser: update to 1.2.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#discussion_r758542839

Comment:
No, this is wrong, pip should never be in any dependencies.

The check error says it needs python3-future in checkdepends.
```
error: Command '['/usr/bin/python3', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/tmp/tmphjmnl4oi', '--quiet', 'future>=0.16.0']' returned non-zero exit status 1.
```

Re: [PR REVIEW] python3-bibtexparser: update to 1.2.0.

[dotnetfox]

[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]

New review comment by dotnetfox on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#discussion_r758567275

Comment:
@paper42, according to what you just wrote, I suppose you meant the following:

```
hostmakedepends="python3-setuptools python3-wheel"
depends="python3-parsing"
checkdepends="python3-future"
```

However, it still does not seem to be enough:

```
=> python3-bibtexparser-1.2.0_1: running do_check ...
/usr/lib/python3.10/distutils/dist.py:274: UserWarning: Unknown distribution option: 'extra_requires'
  warnings.warn(msg)
running test
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
/usr/bin/python3: No module named pip
error: Command '['/usr/bin/python3', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/tmp/tmpfxlnb_mp', '--quiet', 'pyparsing>=2.0.3']' returned non-zero exit status 1.
=> ERROR: python3-bibtexparser-1.2.0_1: do_check: 'python3 setup.py ${make_check_target} ${make_check_args}' exited with 1
=> ERROR:   in do_check() at common/build-style/python3-module.sh:40
```

Re: [PR REVIEW] python3-bibtexparser: update to 1.2.0.

[dotnetfox]

[-- Attachment #1: Type: text/plain, Size: 1507 bytes --]

New review comment by dotnetfox on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#discussion_r758567275

Comment:
@paper42, according to what you just wrote, I suppose you meant the following:

```
hostmakedepends="python3-setuptools python3-wheel"
depends="python3-parsing"
checkdepends="python3-future"
```

However, it still does not seem to be enough:

```
=> python3-bibtexparser-1.2.0_1: running do_check ...
/usr/lib/python3.10/distutils/dist.py:274: UserWarning: Unknown distribution option: 'extra_requires'
  warnings.warn(msg)
running test
WARNING: Testing via this command is deprecated and will be removed in a future version. Users looking for a generic test entry point independent of test runner are encouraged to use tox.
/usr/bin/python3: No module named pip
error: Command '['/usr/bin/python3', '-m', 'pip', '--disable-pip-version-check', 'wheel', '--no-deps', '-w', '/tmp/tmpfxlnb_mp', '--quiet', 'pyparsing>=2.0.3']' returned non-zero exit status 1.
=> ERROR: python3-bibtexparser-1.2.0_1: do_check: 'python3 setup.py ${make_check_target} ${make_check_args}' exited with 1
=> ERROR:   in do_check() at common/build-style/python3-module.sh:40
```

Therefore it also needs python3-parsing in checkdepends:

```
hostmakedepends="python3-setuptools python3-wheel"
depends="python3-parsing"
checkdepends="python3-future python3-parsing"
```

This variant of template builds as expected without using python3-pip.

Thank you.

Re: [PR REVIEW] python3-bibtexparser: update to 1.2.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#discussion_r758586517

Comment:
```
hostmakedepends="python3-setuptools"
depends="python3-parsing"
checkdepends="python3-future $depends"
```
It doesn't actually run any tests because the pypi tarball doesn't contain them and we can't switch the tarball source to github because they didn't publish 1.2.0 there: https://github.com/sciunto-org/python-bibtexparser/issues/287. But that shouldn't be a blocker.

Re: [PR PATCH] [Updated] python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

There is an updated pull request by jgarte against master on the void-packages repository

https://github.com/jgarte/void-packages python3-bibtexparser
https://github.com/void-linux/void-packages/pull/34299

python3-bibtexparser: update to 1.2.0.
#### Testing the changes
- I tested the changes in this PR: briefly

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/34299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-bibtexparser-34299.patch --]
[-- Type: text/x-diff, Size: 1281 bytes --]

From 793d3f58e2a80f07d9ef188b71bcdbc06841cfa9 Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Mon, 29 Nov 2021 01:00:56 -0500
Subject: [PATCH] python3-bibtexparser: update to 1.2.0.

---
 srcpkgs/python3-bibtexparser/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/python3-bibtexparser/template b/srcpkgs/python3-bibtexparser/template
index aa6651428b66..f80cfb4f9bc9 100644
--- a/srcpkgs/python3-bibtexparser/template
+++ b/srcpkgs/python3-bibtexparser/template
@@ -1,14 +1,15 @@
 # Template file for 'python3-bibtexparser'
 pkgname=python3-bibtexparser
-version=1.1.0
-revision=5
+version=1.2.0
+revision=1
 wrksrc="bibtexparser-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-parsing python3-future"
+depends="python3-parsing"
+checkdepends="python3-future $depends"
 short_desc="Python3 package for parsing BibTeX"
 maintainer="xaltsc <xaltsc@protonmail.ch>"
 license="LGPL-3.0-only"
 homepage="https://github.com/sciunto-org/python-bibtexparser"
 distfiles="${PYPI_SITE}/b/bibtexparser/bibtexparser-${version}.tar.gz"
-checksum=df8966ea752db6d74657a69b9d684a61aa33457ad6d9d50e41c50ef7f374907f
+checksum=0f9ab94e3fc36ee2ee6a3713c5dd7320d4b6ee52bd66ecbab03c6b06675ae410

Re: [PR REVIEW] python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New review comment by jgarte on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#discussion_r758670112

Comment:
Thanks @paper42 @dotnetfox for the suggestion. CI is all green now after applying the new changes :)

Re: python3-bibtexparser: update to 1.2.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 290 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#issuecomment-981950264

Comment:
let's also add the changelog
```
changelog="https://raw.githubusercontent.com/sciunto-org/python-bibtexparser/master/CHANGELOG"
```

cc @xaltsc 

Re: [PR PATCH] [Updated] python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

There is an updated pull request by jgarte against master on the void-packages repository

https://github.com/jgarte/void-packages python3-bibtexparser
https://github.com/void-linux/void-packages/pull/34299

python3-bibtexparser: update to 1.2.0.
#### Testing the changes
- I tested the changes in this PR: briefly

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/34299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-bibtexparser-34299.patch --]
[-- Type: text/x-diff, Size: 1379 bytes --]

From 69ac28fc42233ab4fc331afa8925ff56099cc8a8 Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Mon, 29 Nov 2021 01:00:56 -0500
Subject: [PATCH] python3-bibtexparser: update to 1.2.0.

---
 srcpkgs/python3-bibtexparser/template | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/python3-bibtexparser/template b/srcpkgs/python3-bibtexparser/template
index aa6651428b66..a35dd8c4192a 100644
--- a/srcpkgs/python3-bibtexparser/template
+++ b/srcpkgs/python3-bibtexparser/template
@@ -1,14 +1,16 @@
 # Template file for 'python3-bibtexparser'
 pkgname=python3-bibtexparser
-version=1.1.0
-revision=5
+version=1.2.0
+revision=1
 wrksrc="bibtexparser-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-parsing python3-future"
+depends="python3-parsing"
+checkdepends="python3-future $depends"
 short_desc="Python3 package for parsing BibTeX"
 maintainer="xaltsc <xaltsc@protonmail.ch>"
 license="LGPL-3.0-only"
+changelog="https://raw.githubusercontent.com/sciunto-org/python-bibtexparser/master/CHANGELOG"
 homepage="https://github.com/sciunto-org/python-bibtexparser"
 distfiles="${PYPI_SITE}/b/bibtexparser/bibtexparser-${version}.tar.gz"
-checksum=df8966ea752db6d74657a69b9d684a61aa33457ad6d9d50e41c50ef7f374907f
+checksum=0f9ab94e3fc36ee2ee6a3713c5dd7320d4b6ee52bd66ecbab03c6b06675ae410

Re: python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

New comment by jgarte on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#issuecomment-982071013

Comment:
> changelog="https://raw.githubusercontent.com/sciunto-org/python-bibtexparser/master/CHANGELOG"

@paper42 Done!

Re: [PR PATCH] [Updated] python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

There is an updated pull request by jgarte against master on the void-packages repository

https://github.com/jgarte/void-packages python3-bibtexparser
https://github.com/void-linux/void-packages/pull/34299

python3-bibtexparser: update to 1.2.0.
#### Testing the changes
- I tested the changes in this PR: briefly

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/34299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-bibtexparser-34299.patch --]
[-- Type: text/x-diff, Size: 1379 bytes --]

From b4682841271598233fa374048db9aef80d151c5f Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Mon, 29 Nov 2021 01:00:56 -0500
Subject: [PATCH] python3-bibtexparser: update to 1.2.0.

---
 srcpkgs/python3-bibtexparser/template | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/python3-bibtexparser/template b/srcpkgs/python3-bibtexparser/template
index aa6651428b66..1fad61b3466d 100644
--- a/srcpkgs/python3-bibtexparser/template
+++ b/srcpkgs/python3-bibtexparser/template
@@ -1,14 +1,16 @@
 # Template file for 'python3-bibtexparser'
 pkgname=python3-bibtexparser
-version=1.1.0
-revision=5
+version=1.2.0
+revision=1
 wrksrc="bibtexparser-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-parsing python3-future"
+depends="python3-parsing"
+checkdepends="python3-future $depends"
 short_desc="Python3 package for parsing BibTeX"
 maintainer="xaltsc <xaltsc@protonmail.ch>"
 license="LGPL-3.0-only"
 homepage="https://github.com/sciunto-org/python-bibtexparser"
+changelog="https://raw.githubusercontent.com/sciunto-org/python-bibtexparser/master/CHANGELOG"
 distfiles="${PYPI_SITE}/b/bibtexparser/bibtexparser-${version}.tar.gz"
-checksum=df8966ea752db6d74657a69b9d684a61aa33457ad6d9d50e41c50ef7f374907f
+checksum=0f9ab94e3fc36ee2ee6a3713c5dd7320d4b6ee52bd66ecbab03c6b06675ae410

Re: [PR REVIEW] python3-bibtexparser: update to 1.2.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#discussion_r759562143

Comment:
```suggestion
checkdepends="python3-pytest python3-future $depends"
```
and let's switch to a tarball from github which actually contains tests

Re: [PR REVIEW] python3-bibtexparser: update to 1.2.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 337 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#discussion_r759563758

Comment:
```suggestion
homepage="https://pypi.org/project/bibtexparser/"
```
Thanks to this, update-check will be able to detect new versions even when they are only pushed to pypi and not github.

Re: [PR PATCH] [Updated] python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

There is an updated pull request by jgarte against master on the void-packages repository

https://github.com/jgarte/void-packages python3-bibtexparser
https://github.com/void-linux/void-packages/pull/34299

python3-bibtexparser: update to 1.2.0.
#### Testing the changes
- I tested the changes in this PR: briefly

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/34299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-bibtexparser-34299.patch --]
[-- Type: text/x-diff, Size: 1432 bytes --]

From 9659b90d8d7ee6714ebed30cd2f5eb7f29b3a3e7 Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Mon, 29 Nov 2021 01:00:56 -0500
Subject: [PATCH] python3-bibtexparser: update to 1.2.0.

---
 srcpkgs/python3-bibtexparser/template | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/python3-bibtexparser/template b/srcpkgs/python3-bibtexparser/template
index aa6651428b66..beee7ea46fa9 100644
--- a/srcpkgs/python3-bibtexparser/template
+++ b/srcpkgs/python3-bibtexparser/template
@@ -1,14 +1,16 @@
 # Template file for 'python3-bibtexparser'
 pkgname=python3-bibtexparser
-version=1.1.0
-revision=5
+version=1.2.0
+revision=1
 wrksrc="bibtexparser-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-parsing python3-future"
+depends="python3-parsing"
+checkdepends="python3-future $depends"
 short_desc="Python3 package for parsing BibTeX"
 maintainer="xaltsc <xaltsc@protonmail.ch>"
 license="LGPL-3.0-only"
-homepage="https://github.com/sciunto-org/python-bibtexparser"
+homepage="https://pypi.org/project/bibtexparser/"
+changelog="https://raw.githubusercontent.com/sciunto-org/python-bibtexparser/master/CHANGELOG"
 distfiles="${PYPI_SITE}/b/bibtexparser/bibtexparser-${version}.tar.gz"
-checksum=df8966ea752db6d74657a69b9d684a61aa33457ad6d9d50e41c50ef7f374907f
+checksum=0f9ab94e3fc36ee2ee6a3713c5dd7320d4b6ee52bd66ecbab03c6b06675ae410

Re: [PR REVIEW] python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New review comment by jgarte on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#discussion_r759642091

Comment:
@paper42 Ok, I pushed the changes you suggested. Marking this as resolved.

Re: [PR REVIEW] python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New review comment by jgarte on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#discussion_r759642091

Comment:
@paper42 Ok, I pushed the changes you suggested. Thanks! Marking this thread as resolved.

Re: [PR PATCH] [Updated] python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

There is an updated pull request by jgarte against master on the void-packages repository

https://github.com/jgarte/void-packages python3-bibtexparser
https://github.com/void-linux/void-packages/pull/34299

python3-bibtexparser: update to 1.2.0.
#### Testing the changes
- I tested the changes in this PR: briefly

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/34299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-bibtexparser-34299.patch --]
[-- Type: text/x-diff, Size: 2382 bytes --]

From 9659b90d8d7ee6714ebed30cd2f5eb7f29b3a3e7 Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Mon, 29 Nov 2021 01:00:56 -0500
Subject: [PATCH 1/2] python3-bibtexparser: update to 1.2.0.

---
 srcpkgs/python3-bibtexparser/template | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/python3-bibtexparser/template b/srcpkgs/python3-bibtexparser/template
index aa6651428b66..beee7ea46fa9 100644
--- a/srcpkgs/python3-bibtexparser/template
+++ b/srcpkgs/python3-bibtexparser/template
@@ -1,14 +1,16 @@
 # Template file for 'python3-bibtexparser'
 pkgname=python3-bibtexparser
-version=1.1.0
-revision=5
+version=1.2.0
+revision=1
 wrksrc="bibtexparser-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-parsing python3-future"
+depends="python3-parsing"
+checkdepends="python3-future $depends"
 short_desc="Python3 package for parsing BibTeX"
 maintainer="xaltsc <xaltsc@protonmail.ch>"
 license="LGPL-3.0-only"
-homepage="https://github.com/sciunto-org/python-bibtexparser"
+homepage="https://pypi.org/project/bibtexparser/"
+changelog="https://raw.githubusercontent.com/sciunto-org/python-bibtexparser/master/CHANGELOG"
 distfiles="${PYPI_SITE}/b/bibtexparser/bibtexparser-${version}.tar.gz"
-checksum=df8966ea752db6d74657a69b9d684a61aa33457ad6d9d50e41c50ef7f374907f
+checksum=0f9ab94e3fc36ee2ee6a3713c5dd7320d4b6ee52bd66ecbab03c6b06675ae410

From 7f3f486cc06d5f6b3e3004449215fd4de9da2edc Mon Sep 17 00:00:00 2001
From: jgart <47760695+jgarte@users.noreply.github.com>
Date: Tue, 30 Nov 2021 15:40:24 -0500
Subject: [PATCH 2/2] Update srcpkgs/python3-bibtexparser/template

Co-authored-by: paper <michal@vasilek.cz>
---
 srcpkgs/python3-bibtexparser/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/python3-bibtexparser/template b/srcpkgs/python3-bibtexparser/template
index beee7ea46fa9..38b05da51cbb 100644
--- a/srcpkgs/python3-bibtexparser/template
+++ b/srcpkgs/python3-bibtexparser/template
@@ -6,7 +6,7 @@ wrksrc="bibtexparser-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-parsing"
-checkdepends="python3-future $depends"
+checkdepends="python3-pytest python3-future $depends"
 short_desc="Python3 package for parsing BibTeX"
 maintainer="xaltsc <xaltsc@protonmail.ch>"
 license="LGPL-3.0-only"

Re: python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

New comment by jgarte on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#issuecomment-983003723

Comment:
Hmm, the github UI allows me to add suggestions made by others so they can get there name added to the commit, which is really cool but it doesn't squash those commits together. What do void devs prefer? Are you able to squash the final commit on your end from the web ui?

Re: python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

New comment by jgarte on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#issuecomment-983005122

Comment:
> subject does not follow CONTRIBUTING.md guildelines

I'm not entirely sure what the above lint warning from github CI means. It happened after I accepted @paper42 suggestion above to add pytest to the template.

Re: [PR PATCH] [Updated] python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

There is an updated pull request by jgarte against master on the void-packages repository

https://github.com/jgarte/void-packages python3-bibtexparser
https://github.com/void-linux/void-packages/pull/34299

python3-bibtexparser: update to 1.2.0.
#### Testing the changes
- I tested the changes in this PR: briefly

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/34299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-bibtexparser-34299.patch --]
[-- Type: text/x-diff, Size: 1489 bytes --]

From ba3fb3b454dfbef940f99132a9a3f00fe2a79be4 Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Mon, 29 Nov 2021 01:00:56 -0500
Subject: [PATCH] python3-bibtexparser: update to 1.2.0.

Co-authored-by: paper <michal@vasilek.cz>
---
 srcpkgs/python3-bibtexparser/template | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/python3-bibtexparser/template b/srcpkgs/python3-bibtexparser/template
index aa6651428b66..6044c9920ff3 100644
--- a/srcpkgs/python3-bibtexparser/template
+++ b/srcpkgs/python3-bibtexparser/template
@@ -1,14 +1,16 @@
 # Template file for 'python3-bibtexparser'
 pkgname=python3-bibtexparser
-version=1.1.0
-revision=5
+version=1.2.0
+revision=1
 wrksrc="bibtexparser-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-parsing python3-future"
+depends="python3-parsing"
+checkdepends="python3-future python3-pytest $depends"
 short_desc="Python3 package for parsing BibTeX"
 maintainer="xaltsc <xaltsc@protonmail.ch>"
 license="LGPL-3.0-only"
-homepage="https://github.com/sciunto-org/python-bibtexparser"
+homepage="https://pypi.org/project/bibtexparser/"
+changelog="https://raw.githubusercontent.com/sciunto-org/python-bibtexparser/master/CHANGELOG"
 distfiles="${PYPI_SITE}/b/bibtexparser/bibtexparser-${version}.tar.gz"
-checksum=df8966ea752db6d74657a69b9d684a61aa33457ad6d9d50e41c50ef7f374907f
+checksum=0f9ab94e3fc36ee2ee6a3713c5dd7320d4b6ee52bd66ecbab03c6b06675ae410

Re: python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by jgarte on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#issuecomment-983016925

Comment:
@paper42 

I applied your co-authorship manually from my terminal and force pushed. I think all should be good now.

Re: [PR PATCH] [Updated] python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

There is an updated pull request by jgarte against master on the void-packages repository

https://github.com/jgarte/void-packages python3-bibtexparser
https://github.com/void-linux/void-packages/pull/34299

python3-bibtexparser: update to 1.2.0.
#### Testing the changes
- I tested the changes in this PR: briefly

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/34299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-bibtexparser-34299.patch --]
[-- Type: text/x-diff, Size: 1533 bytes --]

From 046b6b149df6fd143968040c6006eff9a0c44d92 Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Mon, 29 Nov 2021 01:00:56 -0500
Subject: [PATCH] python3-bibtexparser: update to 1.2.0.

Co-authored-by: paper <michal@vasilek.cz>
---
 srcpkgs/python3-bibtexparser/template | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/python3-bibtexparser/template b/srcpkgs/python3-bibtexparser/template
index aa6651428b66..d2ca63af00c4 100644
--- a/srcpkgs/python3-bibtexparser/template
+++ b/srcpkgs/python3-bibtexparser/template
@@ -1,14 +1,20 @@
 # Template file for 'python3-bibtexparser'
 pkgname=python3-bibtexparser
-version=1.1.0
-revision=5
+version=1.2.0
+revision=1
 wrksrc="bibtexparser-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-parsing python3-future"
+depends="python3-parsing"
+checkdepends="python3-future python3-pytest $depends"
 short_desc="Python3 package for parsing BibTeX"
 maintainer="xaltsc <xaltsc@protonmail.ch>"
 license="LGPL-3.0-only"
-homepage="https://github.com/sciunto-org/python-bibtexparser"
+homepage="https://pypi.org/project/bibtexparser/"
+changelog="https://raw.githubusercontent.com/sciunto-org/python-bibtexparser/master/CHANGELOG"
 distfiles="${PYPI_SITE}/b/bibtexparser/bibtexparser-${version}.tar.gz"
-checksum=df8966ea752db6d74657a69b9d684a61aa33457ad6d9d50e41c50ef7f374907f
+checksum=0f9ab94e3fc36ee2ee6a3713c5dd7320d4b6ee52bd66ecbab03c6b06675ae410
+
+do_check() {
+	python3 -m pytest
+}

Re: [PR PATCH] [Updated] python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

There is an updated pull request by jgarte against master on the void-packages repository

https://github.com/jgarte/void-packages python3-bibtexparser
https://github.com/void-linux/void-packages/pull/34299

python3-bibtexparser: update to 1.2.0.
#### Testing the changes
- I tested the changes in this PR: briefly

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/34299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-bibtexparser-34299.patch --]
[-- Type: text/x-diff, Size: 1531 bytes --]

From 9f68a87d21bd7b141eb01484dcd15adfbad3220b Mon Sep 17 00:00:00 2001
From: jgart <jgart@dismail.de>
Date: Mon, 29 Nov 2021 01:00:56 -0500
Subject: [PATCH] python3-bibtexparser: update to 1.2.0.

Co-authored-by: paper <michal@vasilek.cz>
---
 srcpkgs/python3-bibtexparser/template | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/python3-bibtexparser/template b/srcpkgs/python3-bibtexparser/template
index aa6651428b66..3fcd1e362e0b 100644
--- a/srcpkgs/python3-bibtexparser/template
+++ b/srcpkgs/python3-bibtexparser/template
@@ -1,14 +1,20 @@
 # Template file for 'python3-bibtexparser'
 pkgname=python3-bibtexparser
-version=1.1.0
-revision=5
+version=1.2.0
+revision=1
 wrksrc="bibtexparser-${version}"
 build_style=python3-module
 hostmakedepends="python3-setuptools"
-depends="python3-parsing python3-future"
+depends="python3-parsing"
+checkdepends="python3-future $depends"
 short_desc="Python3 package for parsing BibTeX"
 maintainer="xaltsc <xaltsc@protonmail.ch>"
 license="LGPL-3.0-only"
-homepage="https://github.com/sciunto-org/python-bibtexparser"
+homepage="https://pypi.org/project/bibtexparser/"
+changelog="https://raw.githubusercontent.com/sciunto-org/python-bibtexparser/master/CHANGELOG"
 distfiles="${PYPI_SITE}/b/bibtexparser/bibtexparser-${version}.tar.gz"
-checksum=df8966ea752db6d74657a69b9d684a61aa33457ad6d9d50e41c50ef7f374907f
+checksum=0f9ab94e3fc36ee2ee6a3713c5dd7320d4b6ee52bd66ecbab03c6b06675ae410
+
+do_check() {
+	LC_ALL="en_US.UTF-8" nosetests
+}

Re: python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

New comment by jgarte on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#issuecomment-983038914

Comment:
@paper42 @dotnetfox @ericonr 

Tests currently fail for this package because PyPi does not include the test repo.

I can add them if I pull the sources in from the project's github repo.

Would you prefer for me to do that?

@paper42 

It looks like tests are run with `nose` instead of `pytest`:

https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/development/python-modules/bibtexparser/default.nix#L24

Re: python3-bibtexparser: update to 1.2.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#issuecomment-983085786

Comment:
* switch to the github tarball as and add pytest to checkdepends as I mentioned in https://github.com/void-linux/void-packages/pull/34299#discussion_r759562143
* import this patch to fix the one failing test https://github.com/sciunto-org/python-bibtexparser/commit/5f98bac62e8ff3c8ab6b956f288f1c61b99c6a5d
* do not override do_check

Re: python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

New comment by jgarte on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#issuecomment-983127397

Comment:
> * switch to the github tarball as and add pytest to checkdepends as I mentioned in [python3-bibtexparser: update to 1.2.0. #34299 (comment)](https://github.com/void-linux/void-packages/pull/34299#discussion_r759562143)
> * import this patch to fix the one failing test [sciunto-org/python-bibtexparser@5f98bac](https://github.com/sciunto-org/python-bibtexparser/commit/5f98bac62e8ff3c8ab6b956f288f1c61b99c6a5d)
> * do not override do_check

@paper42 

Does pytest wrap unittest or nosetests? I haven't looked that far at the code.

Re: python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]

New comment by jgarte on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#issuecomment-983127397

Comment:
> * switch to the github tarball as and add pytest to checkdepends as I mentioned in [python3-bibtexparser: update to 1.2.0. #34299 (comment)](https://github.com/void-linux/void-packages/pull/34299#discussion_r759562143)
> * import this patch to fix the one failing test [sciunto-org/python-bibtexparser@5f98bac](https://github.com/sciunto-org/python-bibtexparser/commit/5f98bac62e8ff3c8ab6b956f288f1c61b99c6a5d)
> * do not override do_check

@paper42 

Does pytest wrap unittest or nosetests? I haven't looked that far at the code.

Answer to self:

https://docs.pytest.org/en/6.2.x/unittest.html

> pytest supports running Python unittest-based tests out of the box. It’s meant for leveraging existing unittest-based test suites to use pytest as a test runner and also allow to incrementally adapt the test suite to take full advantage of pytest’s features.

Re: [PR REVIEW] python3-bibtexparser: update to 1.2.0.

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#discussion_r767082031

Comment:
This should use `nosetests3` directly, but it also requires that `python3-nose` be in checkdepends.

Re: [PR REVIEW] python3-bibtexparser: update to 1.2.0.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#discussion_r770092509

Comment:
We can run all the tests with pytest if we just remove `do_check` and add pytest to checkdepends.

Re: python3-bibtexparser: update to 1.2.0.

[jgarte]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by jgarte on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#issuecomment-1010502033

Comment:
Not sure, when I'll be able to spend time on this one again. If anyone else would like to take it over feel free to.

Re: python3-bibtexparser: update to 1.2.0.

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/34299#issuecomment-1157155585

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: python3-bibtexparser: update to 1.2.0.

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

There's a closed pull request on the void-packages repository

python3-bibtexparser: update to 1.2.0.
https://github.com/void-linux/void-packages/pull/34299

Description:
#### Testing the changes
- I tested the changes in this PR: briefly

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)