[PR PATCH] zsh: add alternative for sh

[PR PATCH] zsh: add alternative for sh

[SimonPersson]

[-- Attachment #1: Type: text/plain, Size: 578 bytes --]

There is a new pull request by SimonPersson against master on the void-packages repository

https://github.com/SimonPersson/void-packages zsh-alternative
https://github.com/void-linux/void-packages/pull/34540

zsh: add alternative for sh
#### Testing the changes
- I tested the changes in this PR: **YES**

The system boots and basic usage seems to work fine with zsh as `/bin/sh`.


#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc



A patch file from https://github.com/void-linux/void-packages/pull/34540.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zsh-alternative-34540.patch --]
[-- Type: text/x-diff, Size: 699 bytes --]

From 112c5ac1645b2bba3b7c0b22724bc1df5f872244 Mon Sep 17 00:00:00 2001
From: Simon Persson <simon@flaskpost.me>
Date: Tue, 14 Dec 2021 22:29:13 +0100
Subject: [PATCH] zsh: add alternative for sh

---
 srcpkgs/zsh/template | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/srcpkgs/zsh/template b/srcpkgs/zsh/template
index a7aea22e18d9..a8e1291cea8d 100644
--- a/srcpkgs/zsh/template
+++ b/srcpkgs/zsh/template
@@ -27,6 +27,10 @@ register_shell="/bin/zsh /usr/bin/zsh"
 lib32disabled=yes
 conf_files="/etc/zsh/*"
 
+alternatives="
+ sh:sh:/usr/bin/zsh
+ sh:sh.1:/usr/share/man/man1/zsh.1"
+
 post_patch() {
 	# Set correct keymap path
 	sed -i 's#/usr/share/keymaps#/usr/share/kbd/keymaps#g' \

Re: zsh: add alternative for sh

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/34540#issuecomment-994156401

Comment:
This should increase revision, too.

That said, I'm not sure how I feel about it.

@void-linux/pkg-committers thoughts?

Re: zsh: add alternative for sh

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/34540#issuecomment-994164519

Comment:
I don't particularly like it. I just tried zsh as sh, and while it works, it doesn't add anything, and doesn't even separate dotfiles.

Re: zsh: add alternative for sh

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/34540#issuecomment-994164535

Comment:
r

Re: zsh: add alternative for sh

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/34540#issuecomment-994164535

Comment:
r

Re: zsh: add alternative for sh

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 789 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/34540#issuecomment-994177374

Comment:
There is no discernible benefit to using `zsh` as `sh` and a lot of potential drawbacks. Substituting `bash` for `sh` is one thing; several popular distributions use `bash` as `sh` and a wide range of shell scripts with a `/bin/sh` shebang are probably widely deployed and well tested with `bash`. (I don't really like this; script writers who specify `/bin/sh` should make sure they aren't inadvertently relying on bashisms; this common practice leads to sloppiness.) I'm almost certain that the vast majority of shell scripts written for `/bin/sh` have *never* been tested when interpreted by `zsh`.

I vote against adding an alternative here.

Re: zsh: add alternative for sh

[sgn]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/34540#issuecomment-994264818

Comment:
I voted against the proposal. Let's not count the problem with current alternatives system, there are no real benefit but potential problems will arise with using zsh as `/bin/sh`

Re: zsh: add alternative for sh

[q66]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New comment by q66 on void-packages repository

https://github.com/void-linux/void-packages/pull/34540#issuecomment-994320103

Comment:
I also don't like it 

Re: zsh: add alternative for sh

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/34540#issuecomment-994384717

Comment:
Thank you for your patch, however at this time it will not be accepted to Void.

Re: [PR PATCH] [Closed]: zsh: add alternative for sh

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

There's a closed pull request on the void-packages repository

zsh: add alternative for sh
https://github.com/void-linux/void-packages/pull/34540

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

The system boots and basic usage seems to work fine with zsh as `/bin/sh`.


#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

Re: zsh: add alternative for sh

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/34540#issuecomment-995283289

Comment:
FTR, 75b6b9bba68f57 iirc it was reverted because it actually broke something.