From: Aloz1 <Aloz1@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [WIP]ghdl: add libbacktrace for llvm backend
Date: Thu, 23 Dec 2021 22:07:41 +0100 [thread overview]
Message-ID: <20211223210741.KtMy81kHjIaYqOqWJmwolL-nNUVc6m0nRXm1_hSEF10@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34626@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]
New comment by Aloz1 on void-packages repository
https://github.com/void-linux/void-packages/pull/34626#issuecomment-1000523822
Comment:
> The upstream build still puts it inside `.libs`, this doesn't change that. A 1k GCC patch is not the solution here, please revert to the version with the manual install commands.
You're not wrong, but that's fundamentally how building with autotools/libtools works. Libraries that are built with libtool are always placed in a '.libs/' directory. The changes in the patch (8 lines of which are actual changes, the rest being autogenn'ed using autoreconf) simply defer installation back to autotools, which is consistent with other public-ally exposed libtools libraries in the gcc source distribution.
I'm also not happy with the 1k patch, but I'd done it that way because I had thought that calling autoreconf within do_preconfigure() would require adding a new hostmakedepends dependency. But I've just had a look, and it seems that all of autotools is depended on by base-devel anyway. So I can reduce the patch down to only 34 lines.
Having said that, if you're more happy with the manual vinstall from .libs (as was done previously), I'm happy to revert it back to that.
next prev parent reply other threads:[~2021-12-23 21:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 14:34 [PR PATCH] " Aloz1
2021-12-20 14:45 ` Aloz1
2021-12-20 15:05 ` [PR REVIEW] " ericonr
2021-12-20 15:05 ` ericonr
2021-12-20 15:05 ` ericonr
2021-12-20 15:32 ` Aloz1
2021-12-20 15:33 ` Aloz1
2021-12-20 15:44 ` [PR PATCH] [Updated] " Aloz1
2021-12-20 15:44 ` [PR REVIEW] " Aloz1
2021-12-21 3:37 ` ericonr
2021-12-21 6:16 ` Aloz1
2021-12-21 19:04 ` ericonr
2021-12-22 0:26 ` Aloz1
2021-12-23 4:45 ` ericonr
2021-12-23 12:47 ` [PR PATCH] [Updated] " Aloz1
2021-12-23 12:52 ` Aloz1
2021-12-23 12:57 ` Aloz1
2021-12-23 13:03 ` Aloz1
2021-12-23 14:07 ` ericonr
2021-12-23 21:07 ` Aloz1
2021-12-23 21:07 ` Aloz1 [this message]
2021-12-23 21:16 ` Aloz1
2021-12-23 22:33 ` Aloz1
2021-12-23 22:58 ` [PR PATCH] [Updated] " Aloz1
2022-01-18 11:45 ` ghdl: " Aloz1
2022-06-19 2:16 ` github-actions
2022-07-04 2:15 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211223210741.KtMy81kHjIaYqOqWJmwolL-nNUVc6m0nRXm1_hSEF10@z \
--to=aloz1@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).