Github messages for voidlinux
 help / color / mirror / Atom feed
From: Aloz1 <Aloz1@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [WIP]ghdl: add libbacktrace for llvm backend
Date: Thu, 23 Dec 2021 23:33:28 +0100	[thread overview]
Message-ID: <20211223223328.5m5I5nbUmFi0Ct2IeuUX9CdtjhoFs66Mp-UI-EF7NaE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34626@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 951 bytes --]

New comment by Aloz1 on void-packages repository

https://github.com/void-linux/void-packages/pull/34626#issuecomment-1000523822

Comment:
> The upstream build still puts it inside `.libs`, this doesn't change that. A 1k GCC patch is not the solution here, please revert to the version with the manual install commands.

Sure, but that's just how building libraries with autotools/libtool works. Libraries that are built with libtool are always placed in a '.libs/' directory. The only ways to avoid the .libs directory are to either let automake generate the libtool specific install targets (what the patch does), or to remove libtool usage from Makefile.am all together, (which would result in an even bigger patch).

I'm also not happy with the 1k patch, and I really don't want to add an additional dependency on automake within the gcc template, just for the sake of libbacktrace; so I'll revert it to using vinstall on .libs/libbacktrace.a

  parent reply	other threads:[~2021-12-23 22:33 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-20 14:34 [PR PATCH] " Aloz1
2021-12-20 14:45 ` Aloz1
2021-12-20 15:05 ` [PR REVIEW] " ericonr
2021-12-20 15:05 ` ericonr
2021-12-20 15:05 ` ericonr
2021-12-20 15:32 ` Aloz1
2021-12-20 15:33 ` Aloz1
2021-12-20 15:44 ` [PR PATCH] [Updated] " Aloz1
2021-12-20 15:44 ` [PR REVIEW] " Aloz1
2021-12-21  3:37 ` ericonr
2021-12-21  6:16 ` Aloz1
2021-12-21 19:04 ` ericonr
2021-12-22  0:26 ` Aloz1
2021-12-23  4:45 ` ericonr
2021-12-23 12:47 ` [PR PATCH] [Updated] " Aloz1
2021-12-23 12:52 ` Aloz1
2021-12-23 12:57 ` Aloz1
2021-12-23 13:03 ` Aloz1
2021-12-23 14:07 ` ericonr
2021-12-23 21:07 ` Aloz1
2021-12-23 21:07 ` Aloz1
2021-12-23 21:16 ` Aloz1
2021-12-23 22:33 ` Aloz1 [this message]
2021-12-23 22:58 ` [PR PATCH] [Updated] " Aloz1
2022-01-18 11:45 ` ghdl: " Aloz1
2022-06-19  2:16 ` github-actions
2022-07-04  2:15 ` [PR PATCH] [Closed]: " github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211223223328.5m5I5nbUmFi0Ct2IeuUX9CdtjhoFs66Mp-UI-EF7NaE@z \
    --to=aloz1@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).