[PR PATCH] wicd: clean up INSTALL.msg

[PR PATCH] wicd: clean up INSTALL.msg

[camoz]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

There is a new pull request by camoz against master on the void-packages repository

https://github.com/camoz/void-packages patch-2
https://github.com/void-linux/void-packages/pull/34703

wicd: clean up INSTALL.msg
None

A patch file from https://github.com/void-linux/void-packages/pull/34703.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-2-34703.patch --]
[-- Type: text/x-diff, Size: 1181 bytes --]

From bbc0a23f63618fb20cbfeda6e53ed186043dc814 Mon Sep 17 00:00:00 2001
From: camoz <camoz@users.noreply.github.com>
Date: Sun, 26 Dec 2021 08:38:10 +0100
Subject: [PATCH] wicd: clean up INSTALL.msg

---
 srcpkgs/wicd/INSTALL.msg | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/wicd/INSTALL.msg b/srcpkgs/wicd/INSTALL.msg
index 3cc3a4773da7..0c745cee6c86 100644
--- a/srcpkgs/wicd/INSTALL.msg
+++ b/srcpkgs/wicd/INSTALL.msg
@@ -1,9 +1,7 @@
-Please note that wicd does not require to have dhcpcd and/or
-wpa_supplicant services running at boot. If you are using them at
-boot, please disable them before using wicd. You can do that with:
+Please note that wicd requires that no other network management daemons (like
+dhcpcd or wpa_supplicant) are running. If you are using them, please disable
+them before using wicd. You can do that with:
 
-	# rm -f /var/service/{dhcpcd,wpa_supplicant}
+	# rm /var/service/<service>
 
-ATTENTION: to make wicd work for your user, it must be a member
-of the 'network' group. You may need 'kdesu' for privilege 
-elevation.
+NOTE: You may need a graphical sudo program like kdesu for privilege elevation.

Re: wicd: clean up INSTALL.msg

[paper42]

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34703#issuecomment-1001144600

Comment:
* the package revision needs to be increased
* I am not sure how this improves the documentation significantly
* why did you remove mentioning the network group? Is it not relevant anymore?

Re: wicd: clean up INSTALL.msg

[camoz]

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

New comment by camoz on void-packages repository

https://github.com/void-linux/void-packages/pull/34703#issuecomment-1001155843

Comment:
> the package revision needs to be increased

Oh I didn't know that (I'm quite new to void).
Maybe the changes can be bundled with the next update to wicd?

> I am not sure how this improves the documentation significantly

Well the first sentence is semantically wrong ("does not require to have" vs. "requires not to have") so I thought better correct that. I'm not using wicd myself, just saw it on the go.

> why did you remove mentioning the network group? Is it not relevant anymore?

Per void docs the `network` group isn't used anymore: https://docs.voidlinux.org/config/users-and-groups.html#default-groups

Re: wicd: clean up INSTALL.msg

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/34703#issuecomment-1001186315

Comment:
I would vote to just remove `INSTALL.msg`, we don't have them for the other packages that have the same requirement like `NetworkManager` and its sufficiently documented in the handbook.


> Per void docs the network group isn't used anymore: https://docs.voidlinux.org/config/users-and-groups.html#default-groups

The documentation here is wrong, there are packages that use this group, like wicd and networkmanager.

Re: wicd: clean up INSTALL.msg

[camoz]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New comment by camoz on void-packages repository

https://github.com/void-linux/void-packages/pull/34703#issuecomment-1001189702

Comment:
Personally, I don't care if this gets merged or `INSTALL.msg` is removed. Removing seems simpler and sounds reasonable to me.

Re: wicd: clean up INSTALL.msg

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/34703#issuecomment-1065994833

Comment:
https://github.com/void-linux/void-packages/issues/36116

Re: [PR PATCH] [Closed]: wicd: clean up INSTALL.msg

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

There's a closed pull request on the void-packages repository

wicd: clean up INSTALL.msg
https://github.com/void-linux/void-packages/pull/34703

Description:
None