Re: [PR REVIEW] New package: qmidiarp-0.6.5

Re: [PR REVIEW] New package: qmidiarp-0.6.5

[mvf]

[-- Attachment #1: Type: text/plain, Size: 287 bytes --]

New review comment by mvf on void-packages repository

https://github.com/void-linux/void-packages/pull/23072#discussion_r471708906

Comment:
Hm, what would be the benefit? A patch would be more verbose and messier to maintain. The envvar is straightforward and build system agnostic...

Re: [PR REVIEW] New package: qmidiarp-0.6.5

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23072#discussion_r673438419

Comment:
This release is from 2017... Things using Qt sometimes start accumulating more and more patches :/

Re: [PR REVIEW] New package: qmidiarp-0.6.5

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/23072#discussion_r673439386

Comment:
Is the removal because of the `-I$EXTRA_QT_INCLUDE_DIR` inclusion?

Re: [PR PATCH] [Updated] New package: qmidiarp-0.6.5

[mvf]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

There is an updated pull request by mvf against master on the void-packages repository

https://github.com/mvf/void-packages pr/qmidiarp
https://github.com/void-linux/void-packages/pull/23072

New package: qmidiarp-0.6.5


A patch file from https://github.com/void-linux/void-packages/pull/23072.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pr/qmidiarp-23072.patch --]
[-- Type: text/x-diff, Size: 3129 bytes --]

From dc1b9c9f350730fbafaa56c4fe69b243aabe056f Mon Sep 17 00:00:00 2001
From: Matthias von Faber <mvf@gmx.eu>
Date: Wed, 17 Jun 2020 22:11:17 +0200
Subject: [PATCH] New package: qmidiarp-0.6.5

---
 .../patches/add-missing-includes.patch        | 21 +++++++++++++++++++
 srcpkgs/qmidiarp/patches/cross.patch          | 15 +++++++++++++
 srcpkgs/qmidiarp/template                     | 18 ++++++++++++++++
 3 files changed, 54 insertions(+)
 create mode 100644 srcpkgs/qmidiarp/patches/add-missing-includes.patch
 create mode 100644 srcpkgs/qmidiarp/patches/cross.patch
 create mode 100644 srcpkgs/qmidiarp/template

diff --git a/srcpkgs/qmidiarp/patches/add-missing-includes.patch b/srcpkgs/qmidiarp/patches/add-missing-includes.patch
new file mode 100644
index 000000000000..13cb6658aed0
--- /dev/null
+++ b/srcpkgs/qmidiarp/patches/add-missing-includes.patch
@@ -0,0 +1,21 @@
+--- a/src/main.cpp
++++ b/src/main.cpp
+@@ -69,6 +69,8 @@
+ #include "mainwindow.h"
+ #include "main.h"
+ 
++#include <sys/types.h>
++#include <unistd.h>
+ 
+ static struct option options[] = {
+     {"version", 0, 0, 'v'},
+--- a/src/midiworker.h
++++ b/src/midiworker.h
+@@ -28,6 +28,7 @@
+ #include "main.h"
+ #include <cstdlib>
+ #include <cstdio>
++#include <sys/types.h>
+ 
+ 
+ /*! @brief MIDI worker base class for QMidiArp modules.
diff --git a/srcpkgs/qmidiarp/patches/cross.patch b/srcpkgs/qmidiarp/patches/cross.patch
new file mode 100644
index 000000000000..0b7c7dae06e6
--- /dev/null
+++ b/srcpkgs/qmidiarp/patches/cross.patch
@@ -0,0 +1,15 @@
+--- a/configure.ac
++++ b/configure.ac
+@@ -127,12 +127,6 @@ if test "x$ac_buildapp" = "xyes" -o ["x$ac_lv2pluginuis" = "xyes"  -a "x$ac_lv2w
+           QT_INCLUDE_DIR=`$PKG_CONFIG --variable=includedir Qt5Gui`
+           QT_CXXFLAGS=`$PKG_CONFIG --cflags Qt5Core Qt5Gui Qt5Widgets`
+           QT_CXXFLAGS="$QT_CXXFLAGS -fPIC"
+-          EXTRA_QT_INCLUDE_DIR="$QT_INCLUDE_DIR/Qt"
+-          AC_CHECK_FILE([$QT_INCLUDE_DIR/QtWidgets/QWidget],
+-            AC_MSG_NOTICE([No extra QT_INCLUDE_DIR needed]),
+-              AC_CHECK_FILE([$EXTRA_QT_INCLUDE_DIR/QtWidgets/QWidget],
+-                QT_CPPFLAGS="$QT_CPPFLAGS -I$EXTRA_QT_INCLUDE_DIR",
+-                  AC_MSG_WARN([QWidget not found])))
+         
+           AC_SUBST(QT_CXXFLAGS)
+           AC_SUBST(Qt5_LIBS)
diff --git a/srcpkgs/qmidiarp/template b/srcpkgs/qmidiarp/template
new file mode 100644
index 000000000000..04ada9038b07
--- /dev/null
+++ b/srcpkgs/qmidiarp/template
@@ -0,0 +1,18 @@
+# Template file for 'qmidiarp'
+pkgname=qmidiarp
+version=0.6.5
+revision=1
+build_style=gnu-configure
+hostmakedepends="automake libtool pkg-config qt5-host-tools"
+makedepends="alsa-lib-devel jack-devel lv2 qt5-devel"
+short_desc="MIDI arpeggiator and LFO"
+maintainer="Matthias von Faber <mvf@gmx.eu>"
+license="GPL-2.0-or-later"
+homepage="http://qmidiarp.sourceforge.net"
+distfiles="${SOURCEFORGE_SITE}/project/${pkgname}/${pkgname}/${version}/${pkgname}-${version}.tar.bz2"
+checksum=22a3a26d3dbe4bf215aa33c0fd4a79c088549328477840d00e72e50c6e807e10
+CXXFLAGS="-D_GNU_SOURCE"
+
+pre_configure() {
+	autoreconf -if
+}

Re: [PR REVIEW] New package: qmidiarp-0.6.5

[mvf]

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New review comment by mvf on void-packages repository

https://github.com/void-linux/void-packages/pull/23072#discussion_r676343100

Comment:
Hm, IME it's not worse than with other libs. Of course, there will likely have to be a patch for Qt6 at some point.

Re: [PR REVIEW] New package: qmidiarp-0.6.5

[mvf]

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

New review comment by mvf on void-packages repository

https://github.com/void-linux/void-packages/pull/23072#discussion_r676343746

Comment:
This removes a cross-unaware file existence check that breaks the build:
```
checking for /usr/include/qt5/QtWidgets/QWidget... configure: error: cannot check for file existence when cross compiling
=> ERROR: qmidiarp-0.6.5_1: do_configure: '${configure_script} ${configure_args}' exited with 1
=> ERROR:   in do_configure() at common/build-style/gnu-configure.sh:8
```
It's unnecessary too, because the `pkg-config` based check succeeds and returns the same include paths:
```
checking for Qt5Core Qt5Gui Qt5Widgets >= 5.0... yes
```

Re: [PR PATCH] [Merged]: New package: qmidiarp-0.6.5

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

There's a merged pull request on the void-packages repository

New package: qmidiarp-0.6.5
https://github.com/void-linux/void-packages/pull/23072

Description: