Re: [PR PATCH] [Updated] (help needed) New package: sbcl-doc-2.1.11

[HiPhish <HiPhish@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]

There is an updated pull request by HiPhish against master on the void-packages repository

https://github.com/HiPhish/void-packages sbcl-doc
https://github.com/void-linux/void-packages/pull/34730

(help needed) New package: sbcl-doc-2.1.11
Add the GNU Info manual for SBCL and its accompanying ASDF manual.

This package has an issue: it will install the manual with the `sbcl` package as well. This is due to the fact that the `do_install` function of the `sbcl` package runs `install.sh`, which will install the manual if it is available. There does not seem to be a way of suppressing that behaviour.

I tried to define a custom `do_build` function inside the subpackage, but it appears that it is not being run: 

```sh
sbcl-doc_package() {
	short_desc+=" - documentation"
	do_build() {
		(cd ./doc/manual; make info)
	}
	pkg_install() {
		vmkdir 'usr/share/info'
		vcopy "doc/manual/*.info*" 'usr/share/info'
	}
}
```

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

A patch file from https://github.com/void-linux/void-packages/pull/34730.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sbcl-doc-34730.patch --]
[-- Type: text/x-diff, Size: 1649 bytes --]

From f2690aa13a9ed8d4c4a6fa920773c9e51f01d0a9 Mon Sep 17 00:00:00 2001
From: HiPhish <hiphish@posteo.de>
Date: Tue, 28 Dec 2021 10:15:29 +0100
Subject: [PATCH] New package: sbcl-doc-2.1.11

Add the GNU Info manual for SBCL and its accompanying ASDF manual.
---
 srcpkgs/sbcl-doc      |  1 +
 srcpkgs/sbcl/template | 17 ++++++++++++++++-
 2 files changed, 17 insertions(+), 1 deletion(-)
 create mode 120000 srcpkgs/sbcl-doc

diff --git a/srcpkgs/sbcl-doc b/srcpkgs/sbcl-doc
new file mode 120000
index 000000000000..d6eeb2634b04
--- /dev/null
+++ b/srcpkgs/sbcl-doc
@@ -0,0 +1 @@
+sbcl
\ No newline at end of file
diff --git a/srcpkgs/sbcl/template b/srcpkgs/sbcl/template
index 524d66eb8d05..5447201fb938 100644
--- a/srcpkgs/sbcl/template
+++ b/srcpkgs/sbcl/template
@@ -3,7 +3,7 @@ pkgname=sbcl
 version=2.1.11
 revision=1
 archs="i686 x86_64* armv7l aarch64 ppc64le*"
-hostmakedepends="iana-etc"
+hostmakedepends="iana-etc texinfo"
 makedepends="zlib-devel"
 conf_files="/etc/sbclrc"
 short_desc="Steel Bank Common Lisp"
@@ -46,6 +46,13 @@ do_build() {
 	bash make.sh \
 		"$_bootstrap_lisp" \
 		--without-sb-test --with-sb-core-compression --prefix=/usr
+	(cd ./doc/manual; make info)
+	# Move built manual files into other directory so they won't get installed
+	# in the main package
+	mkdir -p doc/manual/info
+	for info in doc/manual/*.info*; do
+		mv $info doc/manual/info/
+	done
 }
 
 do_install() {
@@ -64,3 +71,11 @@ sbcl-source_package() {
 		vcopy src usr/lib/sbcl
 	}
 }
+
+sbcl-doc_package() {
+	short_desc+=" - documentation"
+	pkg_install() {
+		vmkdir 'usr/share/info'
+		vcopy "doc/manual/info/*.info*" "usr/share/info"
+	}
+}