Github messages for voidlinux
 help / color / mirror / Atom feed
From: HiPhish <HiPhish@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] New package: sbcl-doc-2.1.11
Date: Thu, 30 Dec 2021 16:45:47 +0100	[thread overview]
Message-ID: <20211230154547.e9Ex5racNR5tsgv3_5HwRw78jiY1DrKQb2YJpUD7w0c@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34730@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]

There is an updated pull request by HiPhish against master on the void-packages repository

https://github.com/HiPhish/void-packages sbcl-doc
https://github.com/void-linux/void-packages/pull/34730

New package: sbcl-doc-2.1.11
Add the GNU Info manual for SBCL and its accompanying ASDF manual.

This package has an issue: it will install the manual with the `sbcl` package as well. This is due to the fact that the `do_install` function of the `sbcl` package runs `install.sh`, which will install the manual if it is available. There does not seem to be a way of suppressing that behaviour.

I tried to define a custom `do_build` function inside the subpackage, but it appears that it is not being run: 

```sh
sbcl-doc_package() {
	short_desc+=" - documentation"
	do_build() {
		(cd ./doc/manual; make info)
	}
	pkg_install() {
		vmkdir 'usr/share/info'
		vcopy "doc/manual/*.info*" 'usr/share/info'
	}
}
```

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

A patch file from https://github.com/void-linux/void-packages/pull/34730.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sbcl-doc-34730.patch --]
[-- Type: text/x-diff, Size: 979 bytes --]

From 105949a0936708def8ab750a1a70d6bd1aedd816 Mon Sep 17 00:00:00 2001
From: HiPhish <hiphish@posteo.de>
Date: Tue, 28 Dec 2021 10:15:29 +0100
Subject: [PATCH] New package: sbcl-doc-2.1.11

Add the GNU Info manual for SBCL and its accompanying ASDF manual.
---
 srcpkgs/sbcl/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/sbcl/template b/srcpkgs/sbcl/template
index 524d66eb8d05..59259de77f26 100644
--- a/srcpkgs/sbcl/template
+++ b/srcpkgs/sbcl/template
@@ -1,9 +1,9 @@
 # Template file for 'sbcl'
 pkgname=sbcl
 version=2.1.11
-revision=1
+revision=2
 archs="i686 x86_64* armv7l aarch64 ppc64le*"
-hostmakedepends="iana-etc"
+hostmakedepends="iana-etc texinfo"
 makedepends="zlib-devel"
 conf_files="/etc/sbclrc"
 short_desc="Steel Bank Common Lisp"
@@ -46,6 +46,7 @@ do_build() {
 	bash make.sh \
 		"$_bootstrap_lisp" \
 		--without-sb-test --with-sb-core-compression --prefix=/usr
+	make -C ./doc/manual info
 }
 
 do_install() {

  parent reply	other threads:[~2021-12-30 15:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-28  9:48 [PR PATCH] (help needed) " HiPhish
2021-12-28 14:09 ` [PR PATCH] [Updated] " HiPhish
2021-12-28 14:13 ` HiPhish
2021-12-28 20:35 ` Chocimier
2021-12-28 20:36 ` Chocimier
2021-12-28 23:01 ` [PR PATCH] [Updated] " HiPhish
2021-12-28 23:13 ` HiPhish
2021-12-29 23:49 ` Chocimier
2021-12-30 12:04 ` [PR PATCH] [Updated] " HiPhish
2021-12-30 12:06 ` HiPhish
2021-12-30 14:08 ` leahneukirchen
2021-12-30 14:09 ` leahneukirchen
2021-12-30 15:44 ` [PR PATCH] [Updated] " HiPhish
2021-12-30 15:45 ` HiPhish [this message]
2021-12-30 15:46 ` HiPhish
2022-01-09 15:19 ` [PR PATCH] [Updated] " HiPhish
2022-01-09 15:19 ` HiPhish
2022-01-09 15:27 ` [PR PATCH] [Merged]: " leahneukirchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211230154547.e9Ex5racNR5tsgv3_5HwRw78jiY1DrKQb2YJpUD7w0c@z \
    --to=hiphish@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).