* Re: binwalk: update to 2.3.3.
2021-11-29 19:02 [PR PATCH] binwalk: update to 2.3.3 unspecd
@ 2021-12-03 18:26 ` ericonr
2021-12-04 6:23 ` [PR PATCH] [Updated] " unspecd
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-12-03 18:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 597 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/34309#issuecomment-985736186
Comment:
The lint should be easy to fix, just remove `pycompile_module`.
```
Extractor Exception: Binwalk extraction uses many third party utilities, which may not be secure. If you wish to have extraction utilities executed as the current user, use '--run-as=root' (binwalk itself must be run as root).
```
Do the tests run locally without issue? You can add `make_check=ci-skip`, if so, unless you figure out how to pass `--run-as=root` to the testsuite.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] binwalk: update to 2.3.3.
2021-11-29 19:02 [PR PATCH] binwalk: update to 2.3.3 unspecd
2021-12-03 18:26 ` ericonr
@ 2021-12-04 6:23 ` unspecd
2022-01-02 15:01 ` unspecd
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: unspecd @ 2021-12-04 6:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]
There is an updated pull request by unspecd against master on the void-packages repository
https://github.com/unspecd/void-packages pkg/binwalk
https://github.com/void-linux/void-packages/pull/34309
binwalk: update to 2.3.3.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34309.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pkg/binwalk-34309.patch --]
[-- Type: text/x-diff, Size: 1165 bytes --]
From e87730d42b26e2f0af05c929e9cddf2dc7dbc47f Mon Sep 17 00:00:00 2001
From: Evgeny Ermakov <evgeny.v.ermakov@gmail.com>
Date: Tue, 30 Nov 2021 06:00:47 +1100
Subject: [PATCH] binwalk: update to 2.3.3.
---
srcpkgs/binwalk/template | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/binwalk/template b/srcpkgs/binwalk/template
index 210ea288857d..14a19c1b0b9a 100644
--- a/srcpkgs/binwalk/template
+++ b/srcpkgs/binwalk/template
@@ -1,9 +1,8 @@
# Template file for 'binwalk'
pkgname=binwalk
-version=2.3.1
-revision=2
+version=2.3.3
+revision=1
build_style=python3-module
-pycompile_module="binwalk"
hostmakedepends="python3"
depends="python3"
checkdepends="python3-coverage python3-nose"
@@ -12,7 +11,7 @@ maintainer="Duncaen <duncaen@voidlinux.org>"
license="MIT"
homepage="https://github.com/ReFirmLabs/binwalk"
distfiles="https://github.com/ReFirmLabs/binwalk/archive/v${version}.tar.gz"
-checksum=7ec9d8fcb8686f4060d37e1096669e3ed8ce1194c91ad80199622448bcc01b19
+checksum=7e32b94dc77632b51d18732b5456e2a3ef85e4521d7d4a54410e36f93859501f
post_extract() {
vsed -i -e 's;/etc/bash_completion.d/%s;%s.bash;' setup.py
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] binwalk: update to 2.3.3.
2021-11-29 19:02 [PR PATCH] binwalk: update to 2.3.3 unspecd
2021-12-03 18:26 ` ericonr
2021-12-04 6:23 ` [PR PATCH] [Updated] " unspecd
@ 2022-01-02 15:01 ` unspecd
2022-01-02 15:03 ` unspecd
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: unspecd @ 2022-01-02 15:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]
There is an updated pull request by unspecd against master on the void-packages repository
https://github.com/unspecd/void-packages pkg/binwalk
https://github.com/void-linux/void-packages/pull/34309
binwalk: update to 2.3.3.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34309.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pkg/binwalk-34309.patch --]
[-- Type: text/x-diff, Size: 2286 bytes --]
From 82fc165ffb1babe462ca419a2a88a2b6abc4a1b1 Mon Sep 17 00:00:00 2001
From: Evgeny Ermakov <evgeny.v.ermakov@gmail.com>
Date: Tue, 30 Nov 2021 06:00:47 +1100
Subject: [PATCH] binwalk: update to 2.3.3.
---
srcpkgs/binwalk/patches/fix-2.3.3-test.patch | 14 ++++++++++++++
srcpkgs/binwalk/template | 7 +++----
2 files changed, 17 insertions(+), 4 deletions(-)
create mode 100644 srcpkgs/binwalk/patches/fix-2.3.3-test.patch
diff --git a/srcpkgs/binwalk/patches/fix-2.3.3-test.patch b/srcpkgs/binwalk/patches/fix-2.3.3-test.patch
new file mode 100644
index 000000000000..be9fe44430da
--- /dev/null
+++ b/srcpkgs/binwalk/patches/fix-2.3.3-test.patch
@@ -0,0 +1,14 @@
+https://github.com/ReFirmLabs/binwalk/issues/566
+https://github.com/ReFirmLabs/binwalk/issues/569
+
+--- b/testing/tests/test_firmware_zip.py
++++ a/testing/tests/test_firmware_zip.py
+@@ -10,6 +10,8 @@
+ '''
+ expected_results = [
+ [0, 'Zip archive data, at least v1.0 to extract, name: dir655_revB_FW_203NA/'],
++ [51, 'Zip archive data, at least v2.0 to extract, compressed size: 6395868, uncompressed size: 6422554, name: dir655_revB_FW_203NA/DIR655B1_FW203NAB02.bin'],
++ [6395993, 'Zip archive data, at least v2.0 to extract, compressed size: 14243, uncompressed size: 61440, name: dir655_revB_FW_203NA/dir655_revB_release_notes_203NA.doc'],
+ [6410581, 'End of Zip archive, footer length: 22'],
+
+ ]
diff --git a/srcpkgs/binwalk/template b/srcpkgs/binwalk/template
index 210ea288857d..14a19c1b0b9a 100644
--- a/srcpkgs/binwalk/template
+++ b/srcpkgs/binwalk/template
@@ -1,9 +1,8 @@
# Template file for 'binwalk'
pkgname=binwalk
-version=2.3.1
-revision=2
+version=2.3.3
+revision=1
build_style=python3-module
-pycompile_module="binwalk"
hostmakedepends="python3"
depends="python3"
checkdepends="python3-coverage python3-nose"
@@ -12,7 +11,7 @@ maintainer="Duncaen <duncaen@voidlinux.org>"
license="MIT"
homepage="https://github.com/ReFirmLabs/binwalk"
distfiles="https://github.com/ReFirmLabs/binwalk/archive/v${version}.tar.gz"
-checksum=7ec9d8fcb8686f4060d37e1096669e3ed8ce1194c91ad80199622448bcc01b19
+checksum=7e32b94dc77632b51d18732b5456e2a3ef85e4521d7d4a54410e36f93859501f
post_extract() {
vsed -i -e 's;/etc/bash_completion.d/%s;%s.bash;' setup.py
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] binwalk: update to 2.3.3.
2021-11-29 19:02 [PR PATCH] binwalk: update to 2.3.3 unspecd
` (2 preceding siblings ...)
2022-01-02 15:01 ` unspecd
@ 2022-01-02 15:03 ` unspecd
2022-01-02 16:54 ` unspecd
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: unspecd @ 2022-01-02 15:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]
There is an updated pull request by unspecd against master on the void-packages repository
https://github.com/unspecd/void-packages pkg/binwalk
https://github.com/void-linux/void-packages/pull/34309
binwalk: update to 2.3.3.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34309.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pkg/binwalk-34309.patch --]
[-- Type: text/x-diff, Size: 2286 bytes --]
From f39a6e90ddca77509a1f0ad6a1aa554027fb67c6 Mon Sep 17 00:00:00 2001
From: Evgeny Ermakov <evgeny.v.ermakov@gmail.com>
Date: Tue, 30 Nov 2021 06:00:47 +1100
Subject: [PATCH] binwalk: update to 2.3.3.
---
srcpkgs/binwalk/patches/fix-2.3.3-test.patch | 14 ++++++++++++++
srcpkgs/binwalk/template | 7 +++----
2 files changed, 17 insertions(+), 4 deletions(-)
create mode 100644 srcpkgs/binwalk/patches/fix-2.3.3-test.patch
diff --git a/srcpkgs/binwalk/patches/fix-2.3.3-test.patch b/srcpkgs/binwalk/patches/fix-2.3.3-test.patch
new file mode 100644
index 000000000000..be9fe44430da
--- /dev/null
+++ b/srcpkgs/binwalk/patches/fix-2.3.3-test.patch
@@ -0,0 +1,14 @@
+https://github.com/ReFirmLabs/binwalk/issues/566
+https://github.com/ReFirmLabs/binwalk/issues/569
+
+--- b/testing/tests/test_firmware_zip.py
++++ a/testing/tests/test_firmware_zip.py
+@@ -10,6 +10,8 @@
+ '''
+ expected_results = [
+ [0, 'Zip archive data, at least v1.0 to extract, name: dir655_revB_FW_203NA/'],
++ [51, 'Zip archive data, at least v2.0 to extract, compressed size: 6395868, uncompressed size: 6422554, name: dir655_revB_FW_203NA/DIR655B1_FW203NAB02.bin'],
++ [6395993, 'Zip archive data, at least v2.0 to extract, compressed size: 14243, uncompressed size: 61440, name: dir655_revB_FW_203NA/dir655_revB_release_notes_203NA.doc'],
+ [6410581, 'End of Zip archive, footer length: 22'],
+
+ ]
diff --git a/srcpkgs/binwalk/template b/srcpkgs/binwalk/template
index 210ea288857d..14a19c1b0b9a 100644
--- a/srcpkgs/binwalk/template
+++ b/srcpkgs/binwalk/template
@@ -1,9 +1,8 @@
# Template file for 'binwalk'
pkgname=binwalk
-version=2.3.1
-revision=2
+version=2.3.3
+revision=1
build_style=python3-module
-pycompile_module="binwalk"
hostmakedepends="python3"
depends="python3"
checkdepends="python3-coverage python3-nose"
@@ -12,7 +11,7 @@ maintainer="Duncaen <duncaen@voidlinux.org>"
license="MIT"
homepage="https://github.com/ReFirmLabs/binwalk"
distfiles="https://github.com/ReFirmLabs/binwalk/archive/v${version}.tar.gz"
-checksum=7ec9d8fcb8686f4060d37e1096669e3ed8ce1194c91ad80199622448bcc01b19
+checksum=7e32b94dc77632b51d18732b5456e2a3ef85e4521d7d4a54410e36f93859501f
post_extract() {
vsed -i -e 's;/etc/bash_completion.d/%s;%s.bash;' setup.py
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] binwalk: update to 2.3.3.
2021-11-29 19:02 [PR PATCH] binwalk: update to 2.3.3 unspecd
` (3 preceding siblings ...)
2022-01-02 15:03 ` unspecd
@ 2022-01-02 16:54 ` unspecd
2022-01-02 17:03 ` unspecd
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: unspecd @ 2022-01-02 16:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]
There is an updated pull request by unspecd against master on the void-packages repository
https://github.com/unspecd/void-packages pkg/binwalk
https://github.com/void-linux/void-packages/pull/34309
binwalk: update to 2.3.3.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34309.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pkg/binwalk-34309.patch --]
[-- Type: text/x-diff, Size: 2706 bytes --]
From 3150f7a5d825ed074d735064403c5868d6deecae Mon Sep 17 00:00:00 2001
From: Evgeny Ermakov <evgeny.v.ermakov@gmail.com>
Date: Tue, 30 Nov 2021 06:00:47 +1100
Subject: [PATCH] binwalk: update to 2.3.3.
---
srcpkgs/binwalk/patches/fix-2.3.3-test.patch | 14 ++++++++++++++
srcpkgs/binwalk/template | 15 ++++++++++-----
2 files changed, 24 insertions(+), 5 deletions(-)
create mode 100644 srcpkgs/binwalk/patches/fix-2.3.3-test.patch
diff --git a/srcpkgs/binwalk/patches/fix-2.3.3-test.patch b/srcpkgs/binwalk/patches/fix-2.3.3-test.patch
new file mode 100644
index 000000000000..bce5ed7c8f39
--- /dev/null
+++ b/srcpkgs/binwalk/patches/fix-2.3.3-test.patch
@@ -0,0 +1,14 @@
+https://github.com/ReFirmLabs/binwalk/issues/566
+https://github.com/ReFirmLabs/binwalk/issues/569
+
+--- a/testing/tests/test_firmware_zip.py
++++ b/testing/tests/test_firmware_zip.py
+@@ -10,6 +10,8 @@
+ '''
+ expected_results = [
+ [0, 'Zip archive data, at least v1.0 to extract, name: dir655_revB_FW_203NA/'],
++ [51, 'Zip archive data, at least v2.0 to extract, compressed size: 6395868, uncompressed size: 6422554, name: dir655_revB_FW_203NA/DIR655B1_FW203NAB02.bin'],
++ [6395993, 'Zip archive data, at least v2.0 to extract, compressed size: 14243, uncompressed size: 61440, name: dir655_revB_FW_203NA/dir655_revB_release_notes_203NA.doc'],
+ [6410581, 'End of Zip archive, footer length: 22'],
+
+ ]
diff --git a/srcpkgs/binwalk/template b/srcpkgs/binwalk/template
index 210ea288857d..f3838109bfb2 100644
--- a/srcpkgs/binwalk/template
+++ b/srcpkgs/binwalk/template
@@ -1,21 +1,26 @@
# Template file for 'binwalk'
pkgname=binwalk
-version=2.3.1
-revision=2
+version=2.3.3
+revision=1
build_style=python3-module
-pycompile_module="binwalk"
hostmakedepends="python3"
depends="python3"
-checkdepends="python3-coverage python3-nose"
+checkdepends="python3-coverage python3-nose tar"
short_desc="Easy tool for analyzing/reversing/extracting firmware images"
maintainer="Duncaen <duncaen@voidlinux.org>"
license="MIT"
homepage="https://github.com/ReFirmLabs/binwalk"
distfiles="https://github.com/ReFirmLabs/binwalk/archive/v${version}.tar.gz"
-checksum=7ec9d8fcb8686f4060d37e1096669e3ed8ce1194c91ad80199622448bcc01b19
+checksum=7e32b94dc77632b51d18732b5456e2a3ef85e4521d7d4a54410e36f93859501f
post_extract() {
vsed -i -e 's;/etc/bash_completion.d/%s;%s.bash;' setup.py
+
+ if [ $(id -u) -eq 0 ]; then
+ # CI container has different privileges than expected in tests.
+ # Append " **{'run-as' : 'root'}," to "binwalk.scan(input_vector_file,".
+ vsed -i -e "/binwalk.scan(input_vector_file,/ s/$/ **{'run-as' : 'root'},/" testing/tests/test_*.py
+ fi
}
do_check() {
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: binwalk: update to 2.3.3.
2021-11-29 19:02 [PR PATCH] binwalk: update to 2.3.3 unspecd
` (4 preceding siblings ...)
2022-01-02 16:54 ` unspecd
@ 2022-01-02 17:03 ` unspecd
2022-06-16 2:14 ` github-actions
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: unspecd @ 2022-01-02 17:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
New comment by unspecd on void-packages repository
https://github.com/void-linux/void-packages/pull/34309#issuecomment-1003745881
Comment:
I hope this is an acceptable solution.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: binwalk: update to 2.3.3.
2021-11-29 19:02 [PR PATCH] binwalk: update to 2.3.3 unspecd
` (5 preceding siblings ...)
2022-01-02 17:03 ` unspecd
@ 2022-06-16 2:14 ` github-actions
2022-06-26 22:41 ` Duncaen
2022-06-26 22:41 ` [PR PATCH] [Closed]: " Duncaen
8 siblings, 0 replies; 10+ messages in thread
From: github-actions @ 2022-06-16 2:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/34309#issuecomment-1157155607
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: binwalk: update to 2.3.3.
2021-11-29 19:02 [PR PATCH] binwalk: update to 2.3.3 unspecd
` (6 preceding siblings ...)
2022-06-16 2:14 ` github-actions
@ 2022-06-26 22:41 ` Duncaen
2022-06-26 22:41 ` [PR PATCH] [Closed]: " Duncaen
8 siblings, 0 replies; 10+ messages in thread
From: Duncaen @ 2022-06-26 22:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/34309#issuecomment-1166666694
Comment:
Merged changes in a9216a5523ee8dcb0437c80215ad12ce92ef9477.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Closed]: binwalk: update to 2.3.3.
2021-11-29 19:02 [PR PATCH] binwalk: update to 2.3.3 unspecd
` (7 preceding siblings ...)
2022-06-26 22:41 ` Duncaen
@ 2022-06-26 22:41 ` Duncaen
8 siblings, 0 replies; 10+ messages in thread
From: Duncaen @ 2022-06-26 22:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]
There's a closed pull request on the void-packages repository
binwalk: update to 2.3.3.
https://github.com/void-linux/void-packages/pull/34309
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 10+ messages in thread