* [PR PATCH] rust-analyzer: update to 2022.01.03.
@ 2022-01-04 22:31 tjkirch
2022-01-05 18:40 ` tjkirch
` (12 more replies)
0 siblings, 13 replies; 14+ messages in thread
From: tjkirch @ 2022-01-04 22:31 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
There is a new pull request by tjkirch against master on the void-packages repository
https://github.com/tjkirch/void-packages rust-analyzer
https://github.com/void-linux/void-packages/pull/34856
rust-analyzer: update to 2022.01.03.
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86-64 glibc
---
Now that Rust 1.57 is merged, we can update rust-analyzer, which since October 21 has required the 2021 edition (introduced in Rust 1.56).
A patch file from https://github.com/void-linux/void-packages/pull/34856.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rust-analyzer-34856.patch --]
[-- Type: text/x-diff, Size: 1082 bytes --]
From 4248586073152e00fcf7786890d99e5d9bd4f819 Mon Sep 17 00:00:00 2001
From: Tom Kirchner <git@halffull.org>
Date: Fri, 10 Dec 2021 21:17:45 -0800
Subject: [PATCH] rust-analyzer: update to 2022.01.03.
---
srcpkgs/rust-analyzer/template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/rust-analyzer/template b/srcpkgs/rust-analyzer/template
index b41a84aab5ea..e099edbbec24 100644
--- a/srcpkgs/rust-analyzer/template
+++ b/srcpkgs/rust-analyzer/template
@@ -1,6 +1,6 @@
# Template file for 'rust-analyzer'
pkgname=rust-analyzer
-version=2021.08.30
+version=2022.01.03
revision=1
_ver=${version//./-}
wrksrc="${pkgname}-${_ver}"
@@ -11,7 +11,7 @@ maintainer="Gabriel Sanches <gabriel@gsr.dev>"
license="Apache-2.0, MIT"
homepage="https://rust-analyzer.github.io/"
distfiles="https://github.com/${pkgname}/${pkgname}/archive/${_ver}.tar.gz"
-checksum=a5c791cd660b46e8fc20c1b268cb25c33658fcd593d81b278c34c97efccddbde
+checksum=3595986c9a988c3eaaa303fdcea6b2100de8467e13863a725d8f9fd463534ce0
# tests require Rust source code
make_check=no
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: rust-analyzer: update to 2022.01.03.
2022-01-04 22:31 [PR PATCH] rust-analyzer: update to 2022.01.03 tjkirch
@ 2022-01-05 18:40 ` tjkirch
2022-01-05 19:03 ` ericonr
` (11 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: tjkirch @ 2022-01-05 18:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]
New comment by tjkirch on void-packages repository
https://github.com/void-linux/void-packages/pull/34856#issuecomment-1005983260
Comment:
The CI checks on ARM* failed because compiling a dependency, [indexmap](https://docs.rs/indexmap/latest/indexmap/index.html), failed because of a missing generic parameter for types like [IndexSet](https://docs.rs/indexmap/latest/indexmap/set/struct.IndexSet.html). The [code](https://docs.rs/indexmap/1.7.0/src/indexmap/set.rs.html#63-69) shows that there's a default value for that parameter, but only if Rust `has_std`.
I see that other Rust-based PRs like [ncspot](https://github.com/void-linux/void-packages/pull/33600) are failing for the same arches; I can't see the error details, but someone linked to [this issue](https://github.com/librespot-org/librespot/issues/774) which sounds very much the same.
The last rust-analyzer PR checked fine, and rust-analyzer doesn't seem to have changed arch support; they still have an official aarch64 build. I wonder if Void's recent [Rust update](https://github.com/void-linux/void-packages/pull/32555) changed something that might be related... Maybe @q66 has context since they did the update?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: rust-analyzer: update to 2022.01.03.
2022-01-04 22:31 [PR PATCH] rust-analyzer: update to 2022.01.03 tjkirch
2022-01-05 18:40 ` tjkirch
@ 2022-01-05 19:03 ` ericonr
2022-01-05 19:22 ` tjkirch
` (10 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2022-01-05 19:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 233 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/34856#issuecomment-1005998045
Comment:
https://github.com/void-linux/void-packages/commit/6660537f754ddb0ca97c3b174425998bd796ca57
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: rust-analyzer: update to 2022.01.03.
2022-01-04 22:31 [PR PATCH] rust-analyzer: update to 2022.01.03 tjkirch
2022-01-05 18:40 ` tjkirch
2022-01-05 19:03 ` ericonr
@ 2022-01-05 19:22 ` tjkirch
2022-01-05 19:23 ` ericonr
` (9 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: tjkirch @ 2022-01-05 19:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 180 bytes --]
New comment by tjkirch on void-packages repository
https://github.com/void-linux/void-packages/pull/34856#issuecomment-1006010901
Comment:
Ah, thank you! I'll do the same here.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: rust-analyzer: update to 2022.01.03.
2022-01-04 22:31 [PR PATCH] rust-analyzer: update to 2022.01.03 tjkirch
` (2 preceding siblings ...)
2022-01-05 19:22 ` tjkirch
@ 2022-01-05 19:23 ` ericonr
2022-01-05 19:23 ` ericonr
` (8 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2022-01-05 19:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/34856#issuecomment-1006011386
Comment:
Please don't do that, actually. That commit is an explanation, I'd rather avoid having to revert lots of `nocross` additions.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: rust-analyzer: update to 2022.01.03.
2022-01-04 22:31 [PR PATCH] rust-analyzer: update to 2022.01.03 tjkirch
` (3 preceding siblings ...)
2022-01-05 19:23 ` ericonr
@ 2022-01-05 19:23 ` ericonr
2022-01-17 19:42 ` tjkirch
` (7 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2022-01-05 19:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 303 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/34856#issuecomment-1006011386
Comment:
Please don't do that, actually. That commit is an explanation, I'd rather avoid having to revert lots of `nocross` additions.
This PR will have to wait a bit.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: rust-analyzer: update to 2022.01.03.
2022-01-04 22:31 [PR PATCH] rust-analyzer: update to 2022.01.03 tjkirch
` (4 preceding siblings ...)
2022-01-05 19:23 ` ericonr
@ 2022-01-17 19:42 ` tjkirch
2022-01-17 23:56 ` ericonr
` (6 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: tjkirch @ 2022-01-17 19:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
New comment by tjkirch on void-packages repository
https://github.com/void-linux/void-packages/pull/34856#issuecomment-1014841625
Comment:
For the record, I tried updating this PR to rust-analyzer 2022-01-17, but it fails to build because we don't have Rust 1.58 yet. As of [two days ago](https://github.com/rust-analyzer/rust-analyzer/commit/91279db2b4dff5cc77a9f34a2212e93490676c46#diff-fe57070ff64dbee9c061031533b3b75f6ef360f3a794aefad62f6849be2caaa3R16) it relies on [captured identifiers in format strings](https://blog.rust-lang.org/2022/01/13/Rust-1.58.0.html#captured-identifiers-in-format-strings). We could probably update to 2022-01-10, but hopefully we have Rust 1.58 soon.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: rust-analyzer: update to 2022.01.03.
2022-01-04 22:31 [PR PATCH] rust-analyzer: update to 2022.01.03 tjkirch
` (5 preceding siblings ...)
2022-01-17 19:42 ` tjkirch
@ 2022-01-17 23:56 ` ericonr
2022-01-18 0:04 ` tjkirch
` (5 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: ericonr @ 2022-01-17 23:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/34856#issuecomment-1014960944
Comment:
Rust 1.58.0 came out like 3 days ago............
I *will* try to update the toolchain, but their minimum rust version policy needs some serious work.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: rust-analyzer: update to 2022.01.03.
2022-01-04 22:31 [PR PATCH] rust-analyzer: update to 2022.01.03 tjkirch
` (6 preceding siblings ...)
2022-01-17 23:56 ` ericonr
@ 2022-01-18 0:04 ` tjkirch
2022-02-27 12:13 ` tranzystorek-io
` (4 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: tjkirch @ 2022-01-18 0:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
New comment by tjkirch on void-packages repository
https://github.com/void-linux/void-packages/pull/34856#issuecomment-1014963914
Comment:
Totally agree. FWIW, there's at least [an issue](https://github.com/rust-analyzer/rust-analyzer/issues/11226) about _documenting_ the fact that it requires latest stable to build...
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: rust-analyzer: update to 2022.01.03.
2022-01-04 22:31 [PR PATCH] rust-analyzer: update to 2022.01.03 tjkirch
` (7 preceding siblings ...)
2022-01-18 0:04 ` tjkirch
@ 2022-02-27 12:13 ` tranzystorek-io
2022-02-27 19:01 ` tjkirch
` (3 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: tranzystorek-io @ 2022-02-27 12:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by tranzystorek-io on void-packages repository
https://github.com/void-linux/void-packages/pull/34856#issuecomment-1053536834
Comment:
The indexmap issue should be fixed if autocfg is updated, sth like:
```shell
post_patch() {
cargo update --package autocfg --precise 1.1.0
}
```
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: rust-analyzer: update to 2022.01.03.
2022-01-04 22:31 [PR PATCH] rust-analyzer: update to 2022.01.03 tjkirch
` (8 preceding siblings ...)
2022-02-27 12:13 ` tranzystorek-io
@ 2022-02-27 19:01 ` tjkirch
2022-04-05 2:32 ` Goorzhel
` (2 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: tjkirch @ 2022-02-27 19:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 368 bytes --]
New comment by tjkirch on void-packages repository
https://github.com/void-linux/void-packages/pull/34856#issuecomment-1053646761
Comment:
FWIW, I tried updating again, with the autocfg update, but we still need Rust 1.58. And it's no longer just rust-analyzer itself, but dependencies are now also requiring captured identifiers in format strings, from Rust 1.58.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: rust-analyzer: update to 2022.01.03.
2022-01-04 22:31 [PR PATCH] rust-analyzer: update to 2022.01.03 tjkirch
` (9 preceding siblings ...)
2022-02-27 19:01 ` tjkirch
@ 2022-04-05 2:32 ` Goorzhel
2022-06-15 21:18 ` classabbyamp
2022-06-15 21:18 ` [PR PATCH] [Closed]: " classabbyamp
12 siblings, 0 replies; 14+ messages in thread
From: Goorzhel @ 2022-04-05 2:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 259 bytes --]
New comment by Goorzhel on void-packages repository
https://github.com/void-linux/void-packages/pull/34856#issuecomment-1088207134
Comment:
There used to be a PR for 1.58, but the one to follow now is https://github.com/void-linux/void-packages/pull/36269.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: rust-analyzer: update to 2022.01.03.
2022-01-04 22:31 [PR PATCH] rust-analyzer: update to 2022.01.03 tjkirch
` (10 preceding siblings ...)
2022-04-05 2:32 ` Goorzhel
@ 2022-06-15 21:18 ` classabbyamp
2022-06-15 21:18 ` [PR PATCH] [Closed]: " classabbyamp
12 siblings, 0 replies; 14+ messages in thread
From: classabbyamp @ 2022-06-15 21:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/34856#issuecomment-1156956395
Comment:
superceded by #37566
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Closed]: rust-analyzer: update to 2022.01.03.
2022-01-04 22:31 [PR PATCH] rust-analyzer: update to 2022.01.03 tjkirch
` (11 preceding siblings ...)
2022-06-15 21:18 ` classabbyamp
@ 2022-06-15 21:18 ` classabbyamp
12 siblings, 0 replies; 14+ messages in thread
From: classabbyamp @ 2022-06-15 21:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
There's a closed pull request on the void-packages repository
rust-analyzer: update to 2022.01.03.
https://github.com/void-linux/void-packages/pull/34856
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86-64 glibc
---
Now that Rust 1.57 is merged, we can update rust-analyzer, which since October 21 has required the 2021 edition (introduced in Rust 1.56).
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2022-06-15 21:18 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-04 22:31 [PR PATCH] rust-analyzer: update to 2022.01.03 tjkirch
2022-01-05 18:40 ` tjkirch
2022-01-05 19:03 ` ericonr
2022-01-05 19:22 ` tjkirch
2022-01-05 19:23 ` ericonr
2022-01-05 19:23 ` ericonr
2022-01-17 19:42 ` tjkirch
2022-01-17 23:56 ` ericonr
2022-01-18 0:04 ` tjkirch
2022-02-27 12:13 ` tranzystorek-io
2022-02-27 19:01 ` tjkirch
2022-04-05 2:32 ` Goorzhel
2022-06-15 21:18 ` classabbyamp
2022-06-15 21:18 ` [PR PATCH] [Closed]: " classabbyamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).