Github messages for voidlinux
 help / color / mirror / Atom feed
From: TinfoilSubmarine <TinfoilSubmarine@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] synapse: update to 1.50.1.
Date: Thu, 20 Jan 2022 19:19:02 +0100	[thread overview]
Message-ID: <20220120181902.LHzWQeCZHaa-AZJn9c3xydKIBxCCzZzC6vI7Eh1SEQA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35109@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1722 bytes --]

New review comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/35109#discussion_r789037296

Comment:
It might be too complex to add, txredisapi needs a running instance of Redis in order to test. I tried the naive approach:
```
do_check() {
  redis-server &
  python3 -m pytest
  redis-cli flushall
}
```
but I'm getting a bunch of errors about type mismatches:
```
self = <tests.test_unix_connection.TestUnixConnectionMethods testMethod=test_UnixConnectionDB1>
result = <TestCaseFunction test_UnixConnectionDB1>

    def run(self, result):
        """
        Run the test case, storing the results in C{result}.

        First runs C{setUp} on self, then runs the test method (defined in the
        constructor), then runs C{tearDown}.  As with the standard library
        L{unittest.TestCase}, the return value of these methods is disregarded.
        In particular, returning a L{Deferred<twisted.internet.defer.Deferred>}
        has no special additional consequences.

        @param result: A L{TestResult} object.
        """
        log.msg("--> %s <--" % (self.id()))
        new_result = itrial.IReporter(result, None)
        if new_result is None:
            result = PyUnitResultAdapter(result)
        else:
            result = new_result
        result.startTest(self)
        if self.getSkip(): # don't run test methods that are marked as .skip
>           result.addSkip(self, self.getSkip())
E           TypeError: Skipped expected string as 'msg' parameter, got 'bool' instead.
E           Perhaps you meant to use a mark?

/usr/lib/python3.10/site-packages/twisted/trial/_synctest.py:1062: TypeError
```

  parent reply	other threads:[~2022-01-20 18:19 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-18 13:45 [PR PATCH] synapse: update to 1.50.0 TinfoilSubmarine
2022-01-18 17:43 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-01-20  0:25 ` [PR REVIEW] synapse: update to 1.50.1 paper42
2022-01-20  0:25 ` paper42
2022-01-20  0:25 ` paper42
2022-01-20 14:51 ` TinfoilSubmarine
2022-01-20 15:32 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-01-20 15:32 ` [PR REVIEW] " TinfoilSubmarine
2022-01-20 17:36 ` paper42
2022-01-20 17:38 ` paper42
2022-01-20 17:50 ` TinfoilSubmarine
2022-01-20 17:58 ` TinfoilSubmarine
2022-01-20 18:19 ` TinfoilSubmarine [this message]
2022-01-20 18:40 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-01-20 18:40 ` [PR REVIEW] " paper42
2022-01-20 18:41 ` TinfoilSubmarine
2022-01-20 18:44 ` paper42
2022-01-20 18:48 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-01-20 18:51 ` [PR REVIEW] " TinfoilSubmarine
2022-01-24 15:43 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-01-24 15:44 ` TinfoilSubmarine
2022-01-25 13:29 ` [PR PATCH] [Updated] synapse: update to 1.50.2 TinfoilSubmarine
2022-01-25 15:18 ` [PR REVIEW] synapse: update to 1.51.0 paper42
2022-01-25 18:34 ` TinfoilSubmarine
2022-01-25 18:38 ` [PR PATCH] [Updated] " TinfoilSubmarine
2022-01-25 23:29 ` [PR REVIEW] " paper42
2022-01-25 23:30 ` paper42
2022-01-26 13:10 ` TinfoilSubmarine
2022-01-26 15:57 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220120181902.LHzWQeCZHaa-AZJn9c3xydKIBxCCzZzC6vI7Eh1SEQA@z \
    --to=tinfoilsubmarine@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).