* [PR PATCH] New package: quicklisp 20150128 @ 2022-02-06 15:19 basicfunc 2022-02-06 15:32 ` [PR REVIEW] " paper42 ` (9 more replies) 0 siblings, 10 replies; 11+ messages in thread From: basicfunc @ 2022-02-06 15:19 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 663 bytes --] There is a new pull request by basicfunc against master on the void-packages repository https://github.com/basicfunc/void-packages quicklisp https://github.com/void-linux/void-packages/pull/35438 New package: quicklisp 20150128 #### Testing the changes - I tested the changes in this PR: **YES** #### New package - This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES** #### Local build testing - I built this PR locally for my native architecture, x86_64-glibc A patch file from https://github.com/void-linux/void-packages/pull/35438.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-quicklisp-35438.patch --] [-- Type: text/x-diff, Size: 4474 bytes --] From 09a34dc23be5b101dd25e6f55b7cf6c7965ea20b Mon Sep 17 00:00:00 2001 From: Rahul <basicfunc@gmail.com> Date: Thu, 3 Feb 2022 01:48:14 +0530 Subject: [PATCH] New Package: quicklisp-20150128 --- srcpkgs/quicklisp/files/LICENSE | 50 +++++++++++++++++++++++++++++++++ srcpkgs/quicklisp/template | 28 ++++++++++++++++++ 2 files changed, 78 insertions(+) create mode 100644 srcpkgs/quicklisp/files/LICENSE create mode 100644 srcpkgs/quicklisp/template diff --git a/srcpkgs/quicklisp/files/LICENSE b/srcpkgs/quicklisp/files/LICENSE new file mode 100644 index 000000000000..2e8fe40971cb --- /dev/null +++ b/srcpkgs/quicklisp/files/LICENSE @@ -0,0 +1,50 @@ +License information + + Copyright © 2010 Zachary Beane <zach@quicklisp.org> + + Permission is hereby granted, free of charge, to any person obtaining a copy + of this software and associated documentation files (the "Software"), to deal + in the Software without restriction, including without limitation the rights + to use, copy, modify, merge, publish, distribute, sublicense, and/or sell + copies of the Software, and to permit persons to whom the Software is + furnished to do so, subject to the following conditions: + + The above copyright notice and this permission notice shall be included in + all copies or substantial portions of the Software. + + THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN + THE SOFTWARE. +Portions of Quicklisp are derived from Pierre Mai's Deflate library, which is available under the following terms: + + Deflate --- RFC 1951 Deflate Decompression + + Copyright (C) 2000-2009 PMSF IT Consulting Pierre R. Mai. + + Permission is hereby granted, free of charge, to any person obtaining + a copy of this software and associated documentation files (the + "Software"), to deal in the Software without restriction, including + without limitation the rights to use, copy, modify, merge, publish, + distribute, sublicense, and/or sell copies of the Software, and to + permit persons to whom the Software is furnished to do so, subject to + the following conditions: + + The above copyright notice and this permission notice shall be + included in all copies or substantial portions of the Software. + + THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF + MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. + IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY CLAIM, DAMAGES OR + OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, + ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + OTHER DEALINGS IN THE SOFTWARE. + + Except as contained in this notice, the name of the author shall + not be used in advertising or otherwise to promote the sale, use or + other dealings in this Software without prior written authorization + from the author. diff --git a/srcpkgs/quicklisp/template b/srcpkgs/quicklisp/template new file mode 100644 index 000000000000..54d7331be122 --- /dev/null +++ b/srcpkgs/quicklisp/template @@ -0,0 +1,28 @@ +# Template file for 'quicklisp' +pkgname=quicklisp +version=20150128 +revision=1 +wrksrc=${pkgname} +build_style=fetch +makedepends="sbcl" +depends="sbcl" +short_desc="Library manager for Common Lisp" +maintainer="Rahul <basicfunc@gmail.com>" +license="custom:bsd" +homepage="https://beta.quicklisp.org" +distfiles="${homepage}/quicklisp.lisp" +checksum=4a7a5c2aebe0716417047854267397e24a44d0cce096127411e9ce9ccfeb2c17 +nocheckperms=yes + +do_install( ){ + echo -ne "(quicklisp-quickstart:install :path \"${DESTDIR}/usr/lib/${pkgname}\")\n(quit)\n" | sbcl --no-userinit --load $pkgname.lisp + chmod 777 -R "$DESTDIR"/usr/lib/${pkgname} + chmod 777 -R "$DESTDIR"/usr/lib/${pkgname}/tmp + chmod 777 -R "$DESTDIR"/usr/lib/${pkgname}/dists + chmod 777 -R "$DESTDIR"/usr/lib/${pkgname}/local-projects + echo -ne "(load \"/usr/lib/${pkgname}/setup\")\n" > ${DESDIR}/etc/default/${pkgname} +} + +post_install( ){ + vlicense ${FILESDIR}/LICENSE +} ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] New package: quicklisp 20150128 2022-02-06 15:19 [PR PATCH] New package: quicklisp 20150128 basicfunc @ 2022-02-06 15:32 ` paper42 2022-02-06 15:32 ` paper42 ` (8 subsequent siblings) 9 siblings, 0 replies; 11+ messages in thread From: paper42 @ 2022-02-06 15:32 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 169 bytes --] New review comment by paper42 on void-packages repository https://github.com/void-linux/void-packages/pull/35438#discussion_r800195487 Comment: why is this necessary? ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] New package: quicklisp 20150128 2022-02-06 15:19 [PR PATCH] New package: quicklisp 20150128 basicfunc 2022-02-06 15:32 ` [PR REVIEW] " paper42 @ 2022-02-06 15:32 ` paper42 2022-02-06 15:32 ` paper42 ` (7 subsequent siblings) 9 siblings, 0 replies; 11+ messages in thread From: paper42 @ 2022-02-06 15:32 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 171 bytes --] New review comment by paper42 on void-packages repository https://github.com/void-linux/void-packages/pull/35438#discussion_r800195520 Comment: This is very weird, why? ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] New package: quicklisp 20150128 2022-02-06 15:19 [PR PATCH] New package: quicklisp 20150128 basicfunc 2022-02-06 15:32 ` [PR REVIEW] " paper42 2022-02-06 15:32 ` paper42 @ 2022-02-06 15:32 ` paper42 2022-02-06 15:59 ` basicfunc ` (6 subsequent siblings) 9 siblings, 0 replies; 11+ messages in thread From: paper42 @ 2022-02-06 15:32 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 183 bytes --] New review comment by paper42 on void-packages repository https://github.com/void-linux/void-packages/pull/35438#discussion_r800195732 Comment: Add the license as a second distfile ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] New package: quicklisp 20150128 2022-02-06 15:19 [PR PATCH] New package: quicklisp 20150128 basicfunc ` (2 preceding siblings ...) 2022-02-06 15:32 ` paper42 @ 2022-02-06 15:59 ` basicfunc 2022-02-06 16:03 ` paper42 ` (5 subsequent siblings) 9 siblings, 0 replies; 11+ messages in thread From: basicfunc @ 2022-02-06 15:59 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 677 bytes --] New review comment by basicfunc on void-packages repository https://github.com/void-linux/void-packages/pull/35438#discussion_r800199219 Comment: If you're talking about `nocheckperms`, I added because I was getting error regarding file permission. Like this ``` quicklisp-20150128_1: post-install_14-fix-permissions: 'find "$PKGDESTDIR" -type f -perm -0002' exited with 1 => ERROR: in hook() at common/hooks/post-install/14-fix-permissions.sh:17 => ERROR: in run_func() at common/xbps-src/shutils/common.sh:21 => ERROR: in run_pkg_hooks() at common/xbps-src/shutils/common.sh:245 => ERROR: in main() at common/xbps-src/libexec/xbps-src-doinstall.sh:66 ``` ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] New package: quicklisp 20150128 2022-02-06 15:19 [PR PATCH] New package: quicklisp 20150128 basicfunc ` (3 preceding siblings ...) 2022-02-06 15:59 ` basicfunc @ 2022-02-06 16:03 ` paper42 2022-02-06 16:04 ` basicfunc ` (4 subsequent siblings) 9 siblings, 0 replies; 11+ messages in thread From: paper42 @ 2022-02-06 16:03 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 397 bytes --] New review comment by paper42 on void-packages repository https://github.com/void-linux/void-packages/pull/35438#discussion_r800199793 Comment: That's a hook which checks if packages have o=w permissions (anyone on the system can write to this file) which should never happen and can be a security issue. I think this is because the `chmod 777` commands below, why does this package need this? ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] New package: quicklisp 20150128 2022-02-06 15:19 [PR PATCH] New package: quicklisp 20150128 basicfunc ` (4 preceding siblings ...) 2022-02-06 16:03 ` paper42 @ 2022-02-06 16:04 ` basicfunc 2022-02-06 16:05 ` basicfunc ` (3 subsequent siblings) 9 siblings, 0 replies; 11+ messages in thread From: basicfunc @ 2022-02-06 16:04 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 212 bytes --] New review comment by basicfunc on void-packages repository https://github.com/void-linux/void-packages/pull/35438#discussion_r800199829 Comment: Oh that's what I tried to fix the same error and forgot to fix. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] New package: quicklisp 20150128 2022-02-06 15:19 [PR PATCH] New package: quicklisp 20150128 basicfunc ` (5 preceding siblings ...) 2022-02-06 16:04 ` basicfunc @ 2022-02-06 16:05 ` basicfunc 2022-02-06 16:16 ` [PR PATCH] [Updated] " basicfunc ` (2 subsequent siblings) 9 siblings, 0 replies; 11+ messages in thread From: basicfunc @ 2022-02-06 16:05 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 281 bytes --] New review comment by basicfunc on void-packages repository https://github.com/void-linux/void-packages/pull/35438#discussion_r800199971 Comment: Actually LICENSE file isn't distributed, it's embedded into webpage, you can find it [here](https://www.quicklisp.org/beta/#license) ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR PATCH] [Updated] New package: quicklisp 20150128 2022-02-06 15:19 [PR PATCH] New package: quicklisp 20150128 basicfunc ` (6 preceding siblings ...) 2022-02-06 16:05 ` basicfunc @ 2022-02-06 16:16 ` basicfunc 2022-02-06 16:17 ` [PR REVIEW] " basicfunc 2022-02-06 16:17 ` basicfunc 9 siblings, 0 replies; 11+ messages in thread From: basicfunc @ 2022-02-06 16:16 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 668 bytes --] There is an updated pull request by basicfunc against master on the void-packages repository https://github.com/basicfunc/void-packages quicklisp https://github.com/void-linux/void-packages/pull/35438 New package: quicklisp 20150128 #### Testing the changes - I tested the changes in this PR: **YES** #### New package - This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES** #### Local build testing - I built this PR locally for my native architecture, x86_64-glibc A patch file from https://github.com/void-linux/void-packages/pull/35438.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-quicklisp-35438.patch --] [-- Type: text/x-diff, Size: 5839 bytes --] From 09a34dc23be5b101dd25e6f55b7cf6c7965ea20b Mon Sep 17 00:00:00 2001 From: Rahul <basicfunc@gmail.com> Date: Thu, 3 Feb 2022 01:48:14 +0530 Subject: [PATCH 1/2] New Package: quicklisp-20150128 --- srcpkgs/quicklisp/files/LICENSE | 50 +++++++++++++++++++++++++++++++++ srcpkgs/quicklisp/template | 28 ++++++++++++++++++ 2 files changed, 78 insertions(+) create mode 100644 srcpkgs/quicklisp/files/LICENSE create mode 100644 srcpkgs/quicklisp/template diff --git a/srcpkgs/quicklisp/files/LICENSE b/srcpkgs/quicklisp/files/LICENSE new file mode 100644 index 000000000000..2e8fe40971cb --- /dev/null +++ b/srcpkgs/quicklisp/files/LICENSE @@ -0,0 +1,50 @@ +License information + + Copyright © 2010 Zachary Beane <zach@quicklisp.org> + + Permission is hereby granted, free of charge, to any person obtaining a copy + of this software and associated documentation files (the "Software"), to deal + in the Software without restriction, including without limitation the rights + to use, copy, modify, merge, publish, distribute, sublicense, and/or sell + copies of the Software, and to permit persons to whom the Software is + furnished to do so, subject to the following conditions: + + The above copyright notice and this permission notice shall be included in + all copies or substantial portions of the Software. + + THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, + OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN + THE SOFTWARE. +Portions of Quicklisp are derived from Pierre Mai's Deflate library, which is available under the following terms: + + Deflate --- RFC 1951 Deflate Decompression + + Copyright (C) 2000-2009 PMSF IT Consulting Pierre R. Mai. + + Permission is hereby granted, free of charge, to any person obtaining + a copy of this software and associated documentation files (the + "Software"), to deal in the Software without restriction, including + without limitation the rights to use, copy, modify, merge, publish, + distribute, sublicense, and/or sell copies of the Software, and to + permit persons to whom the Software is furnished to do so, subject to + the following conditions: + + The above copyright notice and this permission notice shall be + included in all copies or substantial portions of the Software. + + THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF + MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. + IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY CLAIM, DAMAGES OR + OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, + ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + OTHER DEALINGS IN THE SOFTWARE. + + Except as contained in this notice, the name of the author shall + not be used in advertising or otherwise to promote the sale, use or + other dealings in this Software without prior written authorization + from the author. diff --git a/srcpkgs/quicklisp/template b/srcpkgs/quicklisp/template new file mode 100644 index 000000000000..54d7331be122 --- /dev/null +++ b/srcpkgs/quicklisp/template @@ -0,0 +1,28 @@ +# Template file for 'quicklisp' +pkgname=quicklisp +version=20150128 +revision=1 +wrksrc=${pkgname} +build_style=fetch +makedepends="sbcl" +depends="sbcl" +short_desc="Library manager for Common Lisp" +maintainer="Rahul <basicfunc@gmail.com>" +license="custom:bsd" +homepage="https://beta.quicklisp.org" +distfiles="${homepage}/quicklisp.lisp" +checksum=4a7a5c2aebe0716417047854267397e24a44d0cce096127411e9ce9ccfeb2c17 +nocheckperms=yes + +do_install( ){ + echo -ne "(quicklisp-quickstart:install :path \"${DESTDIR}/usr/lib/${pkgname}\")\n(quit)\n" | sbcl --no-userinit --load $pkgname.lisp + chmod 777 -R "$DESTDIR"/usr/lib/${pkgname} + chmod 777 -R "$DESTDIR"/usr/lib/${pkgname}/tmp + chmod 777 -R "$DESTDIR"/usr/lib/${pkgname}/dists + chmod 777 -R "$DESTDIR"/usr/lib/${pkgname}/local-projects + echo -ne "(load \"/usr/lib/${pkgname}/setup\")\n" > ${DESDIR}/etc/default/${pkgname} +} + +post_install( ){ + vlicense ${FILESDIR}/LICENSE +} From 5fa1f1b256d8ee84113f1523280bcb100a3e75df Mon Sep 17 00:00:00 2001 From: Rahul <basicfunc@gmail.com> Date: Sun, 6 Feb 2022 21:46:39 +0530 Subject: [PATCH 2/2] Fixed xlint errors --- srcpkgs/quicklisp/template | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/srcpkgs/quicklisp/template b/srcpkgs/quicklisp/template index 54d7331be122..765ae57a177c 100644 --- a/srcpkgs/quicklisp/template +++ b/srcpkgs/quicklisp/template @@ -12,17 +12,11 @@ license="custom:bsd" homepage="https://beta.quicklisp.org" distfiles="${homepage}/quicklisp.lisp" checksum=4a7a5c2aebe0716417047854267397e24a44d0cce096127411e9ce9ccfeb2c17 -nocheckperms=yes do_install( ){ - echo -ne "(quicklisp-quickstart:install :path \"${DESTDIR}/usr/lib/${pkgname}\")\n(quit)\n" | sbcl --no-userinit --load $pkgname.lisp - chmod 777 -R "$DESTDIR"/usr/lib/${pkgname} - chmod 777 -R "$DESTDIR"/usr/lib/${pkgname}/tmp - chmod 777 -R "$DESTDIR"/usr/lib/${pkgname}/dists - chmod 777 -R "$DESTDIR"/usr/lib/${pkgname}/local-projects - echo -ne "(load \"/usr/lib/${pkgname}/setup\")\n" > ${DESDIR}/etc/default/${pkgname} + echo -ne "(quicklisp-quickstart:install :path \"${DESTDIR}/usr/lib/${pkgname}\")\n(quit)\n" | sbcl --no-userinit --load $pkgname.lisp } post_install( ){ - vlicense ${FILESDIR}/LICENSE + vlicense ${FILESDIR}/LICENSE } ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] New package: quicklisp 20150128 2022-02-06 15:19 [PR PATCH] New package: quicklisp 20150128 basicfunc ` (7 preceding siblings ...) 2022-02-06 16:16 ` [PR PATCH] [Updated] " basicfunc @ 2022-02-06 16:17 ` basicfunc 2022-02-06 16:17 ` basicfunc 9 siblings, 0 replies; 11+ messages in thread From: basicfunc @ 2022-02-06 16:17 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 154 bytes --] New review comment by basicfunc on void-packages repository https://github.com/void-linux/void-packages/pull/35438#discussion_r800201567 Comment: Fixed ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PR REVIEW] New package: quicklisp 20150128 2022-02-06 15:19 [PR PATCH] New package: quicklisp 20150128 basicfunc ` (8 preceding siblings ...) 2022-02-06 16:17 ` [PR REVIEW] " basicfunc @ 2022-02-06 16:17 ` basicfunc 9 siblings, 0 replies; 11+ messages in thread From: basicfunc @ 2022-02-06 16:17 UTC (permalink / raw) To: ml [-- Attachment #1: Type: text/plain, Size: 173 bytes --] New review comment by basicfunc on void-packages repository https://github.com/void-linux/void-packages/pull/35438#discussion_r800201617 Comment: Fixed, it was my mistake ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-02-06 16:17 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-02-06 15:19 [PR PATCH] New package: quicklisp 20150128 basicfunc 2022-02-06 15:32 ` [PR REVIEW] " paper42 2022-02-06 15:32 ` paper42 2022-02-06 15:32 ` paper42 2022-02-06 15:59 ` basicfunc 2022-02-06 16:03 ` paper42 2022-02-06 16:04 ` basicfunc 2022-02-06 16:05 ` basicfunc 2022-02-06 16:16 ` [PR PATCH] [Updated] " basicfunc 2022-02-06 16:17 ` [PR REVIEW] " basicfunc 2022-02-06 16:17 ` basicfunc
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).