* Re: [WIP]New package: helvum-0.3.1
2021-12-15 23:51 [PR PATCH] [WIP]New package: helvum-0.3.1 xaltsc
@ 2022-01-05 9:38 ` dkwo
2022-01-09 0:04 ` [PR REVIEW] " classabbyamp
` (11 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: dkwo @ 2022-01-05 9:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/34560#issuecomment-1005525790
Comment:
Would you like to try again now?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] [WIP]New package: helvum-0.3.1
2021-12-15 23:51 [PR PATCH] [WIP]New package: helvum-0.3.1 xaltsc
2022-01-05 9:38 ` dkwo
@ 2022-01-09 0:04 ` classabbyamp
2022-01-09 0:04 ` classabbyamp
` (10 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: classabbyamp @ 2022-01-09 0:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/34560#discussion_r780718061
Comment:
```suggestion
short_desc="GTK patchbay for pipewire"
```
from `xlint`/[Manual.md](https://github.com/void-linux/void-packages/blob/master/Manual.md#mandatory_vars)
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] [WIP]New package: helvum-0.3.1
2021-12-15 23:51 [PR PATCH] [WIP]New package: helvum-0.3.1 xaltsc
2022-01-05 9:38 ` dkwo
2022-01-09 0:04 ` [PR REVIEW] " classabbyamp
@ 2022-01-09 0:04 ` classabbyamp
2022-01-09 0:04 ` classabbyamp
` (9 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: classabbyamp @ 2022-01-09 0:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 265 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/34560#discussion_r780717882
Comment:
```suggestion
homepage="https://gitlab.freedesktop.org/ryuukyu/helvum"
```
as suggested by @Roger-Roger-debug
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] [WIP]New package: helvum-0.3.1
2021-12-15 23:51 [PR PATCH] [WIP]New package: helvum-0.3.1 xaltsc
` (2 preceding siblings ...)
2022-01-09 0:04 ` classabbyamp
@ 2022-01-09 0:04 ` classabbyamp
2022-01-09 0:04 ` classabbyamp
` (8 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: classabbyamp @ 2022-01-09 0:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/34560#discussion_r780718110
Comment:
```suggestion
post_configure() {
```
from `xlint`
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] [WIP]New package: helvum-0.3.1
2021-12-15 23:51 [PR PATCH] [WIP]New package: helvum-0.3.1 xaltsc
` (3 preceding siblings ...)
2022-01-09 0:04 ` classabbyamp
@ 2022-01-09 0:04 ` classabbyamp
2022-01-09 10:39 ` Roger-Roger-debug
` (7 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: classabbyamp @ 2022-01-09 0:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 343 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/34560#discussion_r780717805
Comment:
```suggestion
license="GPL-3.0-only"
```
from [here](https://spdx.org/licenses/GPL-3.0-only.html)/[Manual.md](https://github.com/void-linux/void-packages/blob/master/Manual.md#var_license)
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [WIP]New package: helvum-0.3.1
2021-12-15 23:51 [PR PATCH] [WIP]New package: helvum-0.3.1 xaltsc
` (4 preceding siblings ...)
2022-01-09 0:04 ` classabbyamp
@ 2022-01-09 10:39 ` Roger-Roger-debug
2022-02-13 13:56 ` dkwo
` (6 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: Roger-Roger-debug @ 2022-01-09 10:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
New comment by Roger-Roger-debug on void-packages repository
https://github.com/void-linux/void-packages/pull/34560#issuecomment-1008272301
Comment:
`libgtk-4.so.1` is provided by gtk4, so it should be added as a dependency (maybe even pipewire?). Also when compiling I get the warning
```
warning: the cargo feature `edition2021` has been stabilized in the 1.56 release and is no longer necessary to be listed in the manifest
```
so we can probably remove the configure bit.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [WIP]New package: helvum-0.3.1
2021-12-15 23:51 [PR PATCH] [WIP]New package: helvum-0.3.1 xaltsc
` (5 preceding siblings ...)
2022-01-09 10:39 ` Roger-Roger-debug
@ 2022-02-13 13:56 ` dkwo
2022-02-13 18:24 ` Roger-Roger-debug
` (5 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: dkwo @ 2022-02-13 13:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 911 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/34560#issuecomment-1038135359
Comment:
This builds and installs fine for me on `x86_64-musl`.
```
# Template file for 'helvum'
pkgname=helvum
version=0.3.4
revision=1
build_style="meson"
hostmakedepends="cargo pkg-config"
makedepends="clang gtk4-devel pipewire-devel desktop-file-utils
glib-devel appstream-glib-devel"
depends="gtk4 pipewire dbus"
short_desc="GTK patchbay for pipewire"
maintainer="xaltsc <hey+dev@xaltsc.dev>"
license="GPL-3.0-only"
homepage="https://gitlab.freedesktop.org/ryuukyu/helvum"
distfiles="https://gitlab.freedesktop.org/ryuukyu/helvum/-/archive/${version}/helvum-${version}.tar.gz"
checksum=e19054f3bcd1ba234c451134fe7f4c6afee35f108c122642c1d502fc16785c02
```
Anyone @xaltsc @Roger-Roger-debug @classabbyamp interested in updating this PR, or creating a new one?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [WIP]New package: helvum-0.3.1
2021-12-15 23:51 [PR PATCH] [WIP]New package: helvum-0.3.1 xaltsc
` (6 preceding siblings ...)
2022-02-13 13:56 ` dkwo
@ 2022-02-13 18:24 ` Roger-Roger-debug
2022-02-13 18:49 ` classabbyamp
` (4 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: Roger-Roger-debug @ 2022-02-13 18:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 297 bytes --]
New comment by Roger-Roger-debug on void-packages repository
https://github.com/void-linux/void-packages/pull/34560#issuecomment-1038319812
Comment:
I can create a new one, but can you explain why you added dbus as a dependency? I couldn't find anything in the project indicating it needs dbus.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [WIP]New package: helvum-0.3.1
2021-12-15 23:51 [PR PATCH] [WIP]New package: helvum-0.3.1 xaltsc
` (7 preceding siblings ...)
2022-02-13 18:24 ` Roger-Roger-debug
@ 2022-02-13 18:49 ` classabbyamp
2022-02-13 20:30 ` dkwo
` (3 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: classabbyamp @ 2022-02-13 18:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/34560#issuecomment-1038337432
Comment:
works for me without dbus in #35591
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [WIP]New package: helvum-0.3.1
2021-12-15 23:51 [PR PATCH] [WIP]New package: helvum-0.3.1 xaltsc
` (8 preceding siblings ...)
2022-02-13 18:49 ` classabbyamp
@ 2022-02-13 20:30 ` dkwo
2022-03-07 18:10 ` xaltsc
` (2 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: dkwo @ 2022-02-13 20:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 182 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/34560#issuecomment-1038408081
Comment:
Well, pipewire requires dbus anyway, right?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [WIP]New package: helvum-0.3.1
2021-12-15 23:51 [PR PATCH] [WIP]New package: helvum-0.3.1 xaltsc
` (9 preceding siblings ...)
2022-02-13 20:30 ` dkwo
@ 2022-03-07 18:10 ` xaltsc
2022-03-07 23:05 ` classabbyamp
2022-03-14 7:08 ` [PR PATCH] [Closed]: " paper42
12 siblings, 0 replies; 14+ messages in thread
From: xaltsc @ 2022-03-07 18:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 262 bytes --]
New comment by xaltsc on void-packages repository
https://github.com/void-linux/void-packages/pull/34560#issuecomment-1060979836
Comment:
Sorry for the delay, given that this PR #35591 seems to be going well, should I close this PR or can I help in some way ?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [WIP]New package: helvum-0.3.1
2021-12-15 23:51 [PR PATCH] [WIP]New package: helvum-0.3.1 xaltsc
` (10 preceding siblings ...)
2022-03-07 18:10 ` xaltsc
@ 2022-03-07 23:05 ` classabbyamp
2022-03-14 7:08 ` [PR PATCH] [Closed]: " paper42
12 siblings, 0 replies; 14+ messages in thread
From: classabbyamp @ 2022-03-07 23:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 298 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/34560#issuecomment-1061231443
Comment:
I think that PR is just waiting for a maintainer approval. If you'd like to test it that'd be great but otherwise I don't think there's anything to do.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Closed]: [WIP]New package: helvum-0.3.1
2021-12-15 23:51 [PR PATCH] [WIP]New package: helvum-0.3.1 xaltsc
` (11 preceding siblings ...)
2022-03-07 23:05 ` classabbyamp
@ 2022-03-14 7:08 ` paper42
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2022-03-14 7:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1171 bytes --]
There's a closed pull request on the void-packages repository
[WIP]New package: helvum-0.3.1
https://github.com/void-linux/void-packages/pull/34560
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
This package does not build because rust is too old. Waitin for #32555 to be merged.
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 14+ messages in thread