Github messages for voidlinux
 help / color / mirror / Atom feed
From: 0x5c <0x5c@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: runit-void: Standardise/improve os-release
Date: Mon, 14 Feb 2022 06:24:12 +0100	[thread overview]
Message-ID: <20220214052412.Ky7gGqN0osCgdinJPk3L0oPqJBaHdrbRa-L_bL2C8Sg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35604@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]

New comment by 0x5c on void-packages repository

https://github.com/void-linux/void-packages/pull/35604#issuecomment-1038658367

Comment:
I was planning to make a PR too, happy to see someone else was looking at improving the situation!

I was primarly exploring what would be required to use the `LOGO` key, and it turns out to be somewhat simple. All it needs is the name of an icon to be looked up in an icon theme. Here's a test with a random icon I hapened to have on my system, shown in kde's system information page 
![image](https://user-images.githubusercontent.com/5877043/153802154-30105e35-22ba-4ab0-af10-5ca3e4520cce.png)

All we'd need is to have the void logo added as an icon in the hicolor theme. I suggest having the icon be part of `void-artwork`; there it would just be placed in the appropriate directorie(s) of the `hicolor` theme, with no dependency required on the actual hicolor package. The artwork would have no effect without the actual hicolor theme (which provides the theme config, and would be an indirect dependency of anything that needs to show icons), and a situation where `void-artwork` were to be absent (like it being in `ignorepkg`) would simply have the application attempting to show an icon fallback to a default or no icon, as per the icon theme spec.


  parent reply	other threads:[~2022-02-14  5:24 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-14  4:31 [PR PATCH] " dragonmaus
2022-02-14  4:32 ` the-maldridge
2022-02-14  4:33 ` dragonmaus
2022-02-14  4:34 ` [PR REVIEW] " Vaelatern
2022-02-14  4:35 ` dragonmaus
2022-02-14  4:36 ` dragonmaus
2022-02-14  4:36 ` Vaelatern
2022-02-14  4:36 ` dragonmaus
2022-02-14  4:38 ` dragonmaus
2022-02-14  4:42 ` dragonmaus
2022-02-14  4:47 ` the-maldridge
2022-02-14  5:24 ` 0x5c [this message]
2022-02-14  9:41 ` 0x5c
2022-02-14 16:26 ` Vaelatern
2022-02-23 10:20 ` JamiKettunen
2022-02-23 18:08 ` 0x5c
2022-02-23 18:25 ` 0x5c
2022-02-23 18:33 ` 0x5c
2022-02-23 20:47 ` dragonmaus
2022-02-23 21:02 ` [PR PATCH] [Updated] " dragonmaus
2022-02-23 21:02 ` dragonmaus
2022-02-23 21:02 ` dragonmaus
2022-02-23 21:18 ` 0x5c
2022-02-24  2:56 ` [PR PATCH] [Updated] " dragonmaus
2022-03-01 19:37 ` dragonmaus
2022-03-01 19:45 ` dragonmaus
2022-03-01 19:46 ` dragonmaus
2022-03-01 19:51 ` classabbyamp
2022-03-01 19:55 ` dragonmaus
2022-03-01 20:57 ` [PR PATCH] [Updated] " dragonmaus
2022-03-01 21:13 ` 0x5c
2022-03-01 21:15 ` classabbyamp
2022-03-01 21:15 ` dragonmaus
2022-03-01 21:16 ` [PR PATCH] [Updated] " dragonmaus
2022-03-01 21:18 ` classabbyamp
2022-03-01 21:18 ` classabbyamp
2022-03-01 21:20 ` dragonmaus
2022-03-01 21:22 ` [PR PATCH] [Updated] " dragonmaus
2022-03-12 23:16 ` 0x5c
2022-03-15 15:32 ` [PR PATCH] [Merged]: " leahneukirchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220214052412.Ky7gGqN0osCgdinJPk3L0oPqJBaHdrbRa-L_bL2C8Sg@z \
    --to=0x5c@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).