From: 0x5c <0x5c@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: runit-void: Standardise/improve os-release
Date: Wed, 23 Feb 2022 19:08:38 +0100 [thread overview]
Message-ID: <20220223180838.iQdngg8Dz4b-q4STXPRKRjA8YIB3XlbsDHGQAVaW16s@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35604@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]
New comment by 0x5c on void-packages repository
https://github.com/void-linux/void-packages/pull/35604#issuecomment-1049065386
Comment:
> Regarding the LOGO key, we can just put an image in /usr/share/icons (note: not in hicolor subdir but maybe this is a GNOME issue?), for example this works ok with LOGO=void-logo in /etc/os-release:
While this seems to work, it will break what follows the spec properly, as it states that icons should be placed in themes, hicolor being the default which is required to be available for applications to add their icons to. Icon lookup requires looking at the current theme then at hicolor if an icon has not been found.
This also breaks the ability to have scaled variations of an icon, and a scalable svg variant. Cuttlefish here is not even able to get a single size out of the icon
As for the inability to add the icon to hicolor, it is because the way void defines that theme only allows icons to be placed in `hicolor/[scale]/[category]/`, but this is fine since we should be providing at least a couple of scales.
If the idea of adding the void logo is welcome, I'd do the work for it.
next prev parent reply other threads:[~2022-02-23 18:08 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 4:31 [PR PATCH] " dragonmaus
2022-02-14 4:32 ` the-maldridge
2022-02-14 4:33 ` dragonmaus
2022-02-14 4:34 ` [PR REVIEW] " Vaelatern
2022-02-14 4:35 ` dragonmaus
2022-02-14 4:36 ` dragonmaus
2022-02-14 4:36 ` Vaelatern
2022-02-14 4:36 ` dragonmaus
2022-02-14 4:38 ` dragonmaus
2022-02-14 4:42 ` dragonmaus
2022-02-14 4:47 ` the-maldridge
2022-02-14 5:24 ` 0x5c
2022-02-14 9:41 ` 0x5c
2022-02-14 16:26 ` Vaelatern
2022-02-23 10:20 ` JamiKettunen
2022-02-23 18:08 ` 0x5c [this message]
2022-02-23 18:25 ` 0x5c
2022-02-23 18:33 ` 0x5c
2022-02-23 20:47 ` dragonmaus
2022-02-23 21:02 ` [PR PATCH] [Updated] " dragonmaus
2022-02-23 21:02 ` dragonmaus
2022-02-23 21:02 ` dragonmaus
2022-02-23 21:18 ` 0x5c
2022-02-24 2:56 ` [PR PATCH] [Updated] " dragonmaus
2022-03-01 19:37 ` dragonmaus
2022-03-01 19:45 ` dragonmaus
2022-03-01 19:46 ` dragonmaus
2022-03-01 19:51 ` classabbyamp
2022-03-01 19:55 ` dragonmaus
2022-03-01 20:57 ` [PR PATCH] [Updated] " dragonmaus
2022-03-01 21:13 ` 0x5c
2022-03-01 21:15 ` classabbyamp
2022-03-01 21:15 ` dragonmaus
2022-03-01 21:16 ` [PR PATCH] [Updated] " dragonmaus
2022-03-01 21:18 ` classabbyamp
2022-03-01 21:18 ` classabbyamp
2022-03-01 21:20 ` dragonmaus
2022-03-01 21:22 ` [PR PATCH] [Updated] " dragonmaus
2022-03-12 23:16 ` 0x5c
2022-03-15 15:32 ` [PR PATCH] [Merged]: " leahneukirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223180838.iQdngg8Dz4b-q4STXPRKRjA8YIB3XlbsDHGQAVaW16s@z \
--to=0x5c@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).