[PR PATCH] krfb: add pipewire dependency

[PR PATCH] krfb: add pipewire dependency

[Konata390]

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

There is a new pull request by Konata390 against master on the void-packages repository

https://github.com/Konata390/void-packages master
https://github.com/void-linux/void-packages/pull/35660

krfb: add pipewire dependency
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

This enables remote desktop functionality in KDE wayland


A patch file from https://github.com/void-linux/void-packages/pull/35660.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-35660.patch --]
[-- Type: text/x-diff, Size: 1230 bytes --]

From 5608a9e1427b6eb6a8df426ebd74c7918ae8217e Mon Sep 17 00:00:00 2001
From: Konata390 <34007143+Konata390@users.noreply.github.com>
Date: Thu, 17 Feb 2022 07:57:50 +0100
Subject: [PATCH] krfb: add pipewire dependency

---
 srcpkgs/krfb/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/krfb/template b/srcpkgs/krfb/template
index c57c8c2b9966..5f8a21591a2b 100644
--- a/srcpkgs/krfb/template
+++ b/srcpkgs/krfb/template
@@ -1,7 +1,7 @@
 # Template file for 'krfb'
 pkgname=krfb
 version=21.12.1
-revision=1
+revision=2
 build_style=cmake
 hostmakedepends="extra-cmake-modules qt5-qmake qt5-host-tools python3 kdoctools
  kconfig pkg-config kcoreaddons gettext"
@@ -9,7 +9,7 @@ makedepends="qt5-devel qt5-x11extras-devel ki18n-devel kcompletion-devel
  kconfig-devel kcoreaddons-devel kcrash-devel kdbusaddons-devel kdnssd-devel
  kdoctools-devel knotifications-devel kwallet-devel kwidgetsaddons-devel
  kxmlgui-devel libvncserver-devel libXtst-devel xcb-util-image-devel
- kwayland-devel"
+ kwayland-devel pipewire-devel plasma-wayland-protocols"
 short_desc="KDE Desktop Sharing"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later, GFDL-1.2-only, LGPL-2.1-or-later"

Re: krfb: add pipewire dependency

[Konata390]

[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]

New comment by Konata390 on void-packages repository

https://github.com/void-linux/void-packages/pull/35660#issuecomment-1042766278

Comment:
Adding qt5-wayland to `hostmakedepends` makes the cmake error go away, but a new error pops up while compiling:
`[1/48] Generating wayland-zkde-screencast-unstable-v1-client-protocol.h
FAILED: framebuffers/pipewire/wayland-zkde-screencast-unstable-v1-client-protocol.h /builddir/krfb-21.12.1/build/framebuffers/pipewire/wayland-zkde-screencast-unstable-v1-client-protocol.h 
cd /builddir/krfb-21.12.1/build/framebuffers/pipewire && /usr/armv7l-linux-gnueabihf/usr/bin/wayland-scanner client-header /usr/armv7l-linux-gnueabihf/usr/share/plasma-wayland-protocols/screencast.xml /builddir/krfb-21.12.1/build/framebuffers/pipewire/wayland-zkde-screencast-unstable-v1-client-protocol.h
/bin/sh: line 1: /usr/armv7l-linux-gnueabihf/usr/bin/wayland-scanner: cannot execute binary file: Exec format error
`
So seems like the cross compiler tries to invoke the `wayland-scanner` of the host which doesn't work. Adding qt5-wayland to the normal `makedepends` instead doesn't solve the cmake error though.

Re: krfb: add pipewire dependency

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/35660#issuecomment-1042786277

Comment:
Add `-DWaylandScanner_EXECUTABLE=/usr/bin/wayland-scanner` to configure_args.

Re: krfb: add pipewire dependency

[Konata390]

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

New comment by Konata390 on void-packages repository

https://github.com/void-linux/void-packages/pull/35660#issuecomment-1042853331

Comment:
I don't know what I did, but I can't reproduce my earlier issue anymore. Now I always get this error (with or without the added `configure_args`):

`[1/18] Generating wayland-zkde-screencast-unstable-v1-client-protocol.h
FAILED: framebuffers/pipewire/wayland-zkde-screencast-unstable-v1-client-protocol.h /builddir/krfb-21.12.1/build/framebuffers/pipewire/wayland-zkde-screencast-unstable-v1-client-protocol.h 
cd /builddir/krfb-21.12.1/build/framebuffers/pipewire && /usr/bin/wayland-scanner client-header /usr/armv7l-linux-gnueabihf/usr/share/plasma-wayland-protocols/screencast.xml /builddir/krfb-21.12.1/build/framebuffers/pipewire/wayland-zkde-screencast-unstable-v1-client-protocol.h
/bin/sh: line 1: /usr/bin/wayland-scanner: No such file or directory
`

Re: krfb: add pipewire dependency

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/35660#issuecomment-1042859802

Comment:
You need to add/keep qt5-wayland in hostmakedepends.

Re: [PR PATCH] [Updated] krfb: add pipewire dependency

[Konata390]

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

There is an updated pull request by Konata390 against master on the void-packages repository

https://github.com/Konata390/void-packages master
https://github.com/void-linux/void-packages/pull/35660

krfb: add pipewire dependency
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

This enables remote desktop functionality in KDE wayland


A patch file from https://github.com/void-linux/void-packages/pull/35660.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-35660.patch --]
[-- Type: text/x-diff, Size: 2211 bytes --]

From 5608a9e1427b6eb6a8df426ebd74c7918ae8217e Mon Sep 17 00:00:00 2001
From: Konata390 <34007143+Konata390@users.noreply.github.com>
Date: Thu, 17 Feb 2022 07:57:50 +0100
Subject: [PATCH 1/2] krfb: add pipewire dependency

---
 srcpkgs/krfb/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/krfb/template b/srcpkgs/krfb/template
index c57c8c2b9966..5f8a21591a2b 100644
--- a/srcpkgs/krfb/template
+++ b/srcpkgs/krfb/template
@@ -1,7 +1,7 @@
 # Template file for 'krfb'
 pkgname=krfb
 version=21.12.1
-revision=1
+revision=2
 build_style=cmake
 hostmakedepends="extra-cmake-modules qt5-qmake qt5-host-tools python3 kdoctools
  kconfig pkg-config kcoreaddons gettext"
@@ -9,7 +9,7 @@ makedepends="qt5-devel qt5-x11extras-devel ki18n-devel kcompletion-devel
  kconfig-devel kcoreaddons-devel kcrash-devel kdbusaddons-devel kdnssd-devel
  kdoctools-devel knotifications-devel kwallet-devel kwidgetsaddons-devel
  kxmlgui-devel libvncserver-devel libXtst-devel xcb-util-image-devel
- kwayland-devel"
+ kwayland-devel pipewire-devel plasma-wayland-protocols"
 short_desc="KDE Desktop Sharing"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later, GFDL-1.2-only, LGPL-2.1-or-later"

From f8eaecdde77472cc1a860c1206157b23ad9eb54e Mon Sep 17 00:00:00 2001
From: Konata390 <34007143+Konata390@users.noreply.github.com>
Date: Thu, 17 Feb 2022 12:42:47 +0100
Subject: [PATCH 2/2] krfb: fix cross compilation

---
 srcpkgs/krfb/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/krfb/template b/srcpkgs/krfb/template
index 5f8a21591a2b..0228b18ed988 100644
--- a/srcpkgs/krfb/template
+++ b/srcpkgs/krfb/template
@@ -3,7 +3,8 @@ pkgname=krfb
 version=21.12.1
 revision=2
 build_style=cmake
-hostmakedepends="extra-cmake-modules qt5-qmake qt5-host-tools python3 kdoctools
+configure_args="-DWaylandScanner_EXECUTABLE=/usr/bin/wayland-scanner"
+hostmakedepends="extra-cmake-modules qt5-qmake qt5-host-tools qt5-wayland python3 kdoctools
  kconfig pkg-config kcoreaddons gettext"
 makedepends="qt5-devel qt5-x11extras-devel ki18n-devel kcompletion-devel
  kconfig-devel kcoreaddons-devel kcrash-devel kdbusaddons-devel kdnssd-devel

Re: krfb: add pipewire dependency

[Konata390]

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by Konata390 on void-packages repository

https://github.com/void-linux/void-packages/pull/35660#issuecomment-1043001775

Comment:
Seems like it didn't work, any other ideas?

Re: krfb: add pipewire dependency

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 456 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/35660#issuecomment-1043274704

Comment:
Also needs wayland-devel. I picked you commits and merged them into my kde staging branch together with an update to 21.12.2., so will be in the main repo somewhen this weekend most likely.

Seems to work as good (or bad) as intended by upstream. (Sadly kwin doesn't support keyboard input with pipewire yet)

Re: [PR PATCH] [Closed]: krfb: add pipewire dependency

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 475 bytes --]

There's a closed pull request on the void-packages repository

krfb: add pipewire dependency
https://github.com/void-linux/void-packages/pull/35660

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

This enables remote desktop functionality in KDE wayland