[PR PATCH] pipewire: update to 0.3.43

[PR PATCH] pipewire: update to 0.3.43

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]

There is a new pull request by st3r4g against master on the void-packages repository

https://github.com/st3r4g/void-packages pipewire-0.3.43
https://github.com/void-linux/void-packages/pull/34904

pipewire: update to 0.3.43
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

What is the plan to make `wireplumber` the default session manager? If I add it to `depends`, there will be a build cycle.

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/34904.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-0.3.43-34904.patch --]
[-- Type: text/x-diff, Size: 1276 bytes --]

From 15fb698770229fa52b27c77879333aa5657ec204 Mon Sep 17 00:00:00 2001
From: Stefano Ragni <stefano.ragni@outlook.com>
Date: Thu, 6 Jan 2022 11:32:51 +0100
Subject: [PATCH] pipewire: update to 0.3.43

---
 srcpkgs/pipewire/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index 668b4989bbec..cb2aac730c29 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=0.3.42
+version=0.3.43
 revision=1
 _pms_version=0.4.1
 build_style=meson
@@ -32,7 +32,7 @@ homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz
  https://gitlab.freedesktop.org/pipewire/media-session/-/archive/${_pms_version}/media-session-${_pms_version}.tar.gz"
-checksum="726d1f2faed6f1e93c1499cd20ff0d6461bc698166bea3b98d46c291794e6e1c
+checksum="87f692a2cb5b14ee900e102502b5e078a0cd3f7836f03a2e7cb30690ead37b50
  119c9216070b54018217552c7924f9888da270c3c4647c5e2b85ffa6b1574975"
 make_dirs="/var/lib/pipewire 0755 _pipewire _pipewire"
 system_accounts="_pipewire"

Re: pipewire: update to 0.3.43

[steinex]

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

New comment by steinex on void-packages repository

https://github.com/void-linux/void-packages/pull/34904#issuecomment-1006730891

Comment:
+1 switching to wireplumber, upstream recommends it explicitely over p-m-s now. https://gitlab.freedesktop.org/pipewire/media-session#pipewire-media-session

And btw, wireplumber 0.4.6 is out.

Re: [PR PATCH] [Closed]: pipewire: update to 0.3.43

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

There's a closed pull request on the void-packages repository

pipewire: update to 0.3.43
https://github.com/void-linux/void-packages/pull/34904

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

What is the plan to make `wireplumber` the default session manager? If I add it to `depends`, there will be a build cycle.

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Re: pipewire: update to 0.3.43

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/34904#issuecomment-1007066545

Comment:
Unfortunately, there is no good plan to pull in wireplumber by default because of the cycle.

Re: pipewire: update to 0.3.43

[prez]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

New comment by prez on void-packages repository

https://github.com/void-linux/void-packages/pull/34904#issuecomment-1046111567

Comment:
https://pipewire.pages.freedesktop.org/wireplumber/running-wireplumber-daemon.html#run-from-the-pipewire-source-tree

Would this be an option?

Re: pipewire: update to 0.3.43

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/34904#issuecomment-1046635891

Comment:
> https://pipewire.pages.freedesktop.org/wireplumber/running-wireplumber-daemon.html#run-from-the-pipewire-source-tree
> 
> Would this be an option?

Would work, but it's ugly. For example, it forces a rebuild of both every time. It is mainly intended for developers, not distros.

Re: pipewire: update to 0.3.43

[prez]

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

New comment by prez on void-packages repository

https://github.com/void-linux/void-packages/pull/34904#issuecomment-1046792155

Comment:
> Would work, but it's ugly. For example, it forces a rebuild of both every time. It is mainly intended for developers, not distros.

I see. Shipping it with media-session but documenting how to switch would be best then, probably. 

On that note, how are you enabling wireplumber, in case you're running it? Either due to the precedence of files in `pipewire.conf` or the fact that array sections are appended, I can't seem to be able to specify wireplumber to run instead of media-session by dropping a .conf file into `~/.config/pipewire/pipewire.conf.d/` that overwrites only the `context.exec` section - and I do not want to have a global configuration in /etc or modify the provided files in /usr/share.
Apologies for hijacking this PR.

Re: pipewire: update to 0.3.43

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 713 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/34904#issuecomment-1047049957

Comment:
> I see. Shipping it with media-session but documenting how to switch would be best then, probably.

media-session is deprecated, at some point we must do the switch, no matter how ugly it is packaging-wise.

> On that note, how are you enabling wireplumber, in case you're running it?

I'm overriding the whole `pipewire.conf`, there haven't been breaking changes in the config lately. I've just tried dropping the snippet in `pipewire.conf.d` with `0.3.47`, and what I saw is that both media-session and wireplumber are executed, which is not good. Might be a bug.

Re: pipewire: update to 0.3.43

[st3r4g]

[-- Attachment #1: Type: text/plain, Size: 713 bytes --]

New comment by st3r4g on void-packages repository

https://github.com/void-linux/void-packages/pull/34904#issuecomment-1047049957

Comment:
> I see. Shipping it with media-session but documenting how to switch would be best then, probably.

media-session is deprecated, at some point we must do the switch, no matter how ugly it is packaging-wise.

> On that note, how are you enabling wireplumber, in case you're running it?

I'm overriding the whole `pipewire.conf`, there haven't been breaking changes in the config lately. I've just tried dropping the snippet in `pipewire.conf.d` with `0.3.47`, and what I saw is that both media-session and wireplumber are executed, which is not good. Probably a bug.

Re: pipewire: update to 0.3.43

[prez]

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

New comment by prez on void-packages repository

https://github.com/void-linux/void-packages/pull/34904#issuecomment-1047111490

Comment:
If it is already deprecated and we must make the switch at some point (might as well do it early then - I doubt something will change about pipewire and wireplumber being separate projects upstream and the resulting cycle) , the way I see it, we have two options:
1. Enabling `-Dsession-managers="[ 'wireplumber' ]"`, which pulls in wireplumber and enables the relevant entry in the default configuration file, making wireplumber a subpackage and telling users to install it together with pipewire in the documentation for a functional pipewire setup.
2. Alternatively, figuring out how to ship it without media-session and a context.exec entry (building with session-managers `=[]` doesn't seem to have that effect), keeping the wireplumber package as it as and adding the same bit of documentation.

>Probably a bug.

I think this due to `context.exec` being an array, so it gets appended and you end up with both being executed. I would be against recommending to override the whole configuration file, and it's not something I want to do myself, since I don't keep up with changes well and I don't expect many users do.

Re: pipewire: update to 0.3.43

[prez]

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

New comment by prez on void-packages repository

https://github.com/void-linux/void-packages/pull/34904#issuecomment-1047111490

Comment:
If it is already deprecated and we must make the switch at some point (might as well do it early then - I doubt something will change about pipewire and wireplumber being separate projects upstream and the resulting cycle) , the way I see it, we have two options:
1. Enabling `-Dsession-managers="[ 'wireplumber' ]"`, which pulls in wireplumber and enables the relevant entry in the default configuration file, making wireplumber a subpackage and telling users to install it together with pipewire in the documentation for a functional pipewire setup.
2. Alternatively, figuring out how to ship it without media-session and without a context.exec entry (building with session-managers `=[]` doesn't seem to have that effect), keeping the wireplumber package as it as and adding the same bit of documentation.

>Probably a bug.

I think this due to `context.exec` being an array, so it gets appended and you end up with both being executed. I would be against recommending to override the whole configuration file, and it's not something I want to do myself, since I don't keep up with changes well and I don't expect many users do.

Re: pipewire: update to 0.3.43

[prez]

[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]

New comment by prez on void-packages repository

https://github.com/void-linux/void-packages/pull/34904#issuecomment-1047111490

Comment:
If it is already deprecated and we must make the switch at some point (might as well do it early then - I doubt something will change about pipewire and wireplumber being separate projects upstream and the resulting cycle) , the way I see it, we have two options:
1. Enabling `-Dsession-managers="[ 'wireplumber' ]"`, which pulls in wireplumber and enables the relevant entry in the default configuration file, making wireplumber a subpackage and telling users to install it together with pipewire in the documentation for a functional pipewire setup.
2. Alternatively, figuring out how to ship it without media-session and without a context.exec entry (building with session-managers `=[]` doesn't seem to have that effect), keeping the wireplumber package as it as and adding the same bit of documentation with the added remark that the user has to start a wireplumber service too.

>Probably a bug.

I think this due to `context.exec` being an array, so it gets appended and you end up with both being executed. I would be against recommending to override the whole configuration file, and it's not something I want to do myself, since I don't keep up with changes well and I don't expect many users do.

Re: pipewire: update to 0.3.43

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/34904#issuecomment-1074022941

Comment:
alpine builds wireplumber with
```
provides="pipewire-session-manager"
provider_priority=0
```
and then pipewire with `-Dsession-managers=[]` accompanied
`install -Dm755 "$srcdir"/pipewire-launcher.sh "$pkgdir"/usr/libexec/pipewire-launcher`
by the launcher script
```
#!/bin/sh

# We need to kill any existing pipewire instance to restore sound
pkill -u "${USER}" -fx "/usr/bin/pipewire -c pipewire-pulse.conf" 1>/dev/null 2>&1
pkill -u "${USER}" -fx /usr/bin/pipewire-media-session 1>/dev/null 2>&1
pkill -u "${USER}" -fx /usr/bin/wireplumber 1>/dev/null 2>&1
pkill -u "${USER}" -fx /usr/bin/pipewire 1>/dev/null 2>&1

exec /usr/bin/pipewire &

# wait for pipewire to start before attempting to start related daemons
while [ "$(pgrep -f /usr/bin/pipewire)" = "" ]; do
        sleep 1
done

if [ -x /usr/bin/wireplumber ]; then
	exec /usr/bin/wireplumber &
elif [ -x /usr/bin/pipewire-media-session ]; then
	exec /usr/bin/pipewire-media-session &
fi

[ -f "/usr/share/pipewire/pipewire-pulse.conf" ] && exec /usr/bin/pipewire -c pipewire-pulse.conf &
```
Would this work in void?

Re: pipewire: update to 0.3.43

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/34904#issuecomment-1074061880

Comment:
The issue isn't how `wireplumber` gets launched, but how it is built. We cannot have the `wireplumber` package depend on `pipewire` and the `pipewire` package depend on `wireplumber` because that creates a build cycle.

If it is ugly to build `wireplumber` as part of the `pipewire` package (I have an unverified suspicion that it may be), it may be less ugly to have a `pipewire-bootstrap` package or something that can satisfy the `makedepends` and `checkdepends` of `pipewire` to break the cycle. I am not attuned enough to `pipewire` to have an opinion here.

Of course, if `wireplumber` is to be a new, official replacement for the old session manager, it seems that upstream should provide a clean way to build the entire apparatus together, such as by pulling `wireplumber` into the source tree. It is **always** problematic to say "you need package X to build package Y, but you need package Y to run package X".

Cf. the nightmare that is PEP-517 build systems which depend on an external TOML parser.

Re: pipewire: update to 0.3.43

[prez]

[-- Attachment #1: Type: text/plain, Size: 712 bytes --]

New comment by prez on void-packages repository

https://github.com/void-linux/void-packages/pull/34904#issuecomment-1079767607

Comment:
>Of course, if wireplumber is to be a new, official replacement for the old session manager, it seems that upstream should provide a clean way to build the entire apparatus together, such as by pulling wireplumber into the source tree.

>If it is ugly to build wireplumber as part of the pipewire package (I have an unverified suspicion that it may be), it may be less ugly to have a pipewire-bootstrap package or something that can satisfy the makedepends and checkdepends of pipewire to break the cycle.

This is what ` -Dsession-managers="[ 'wireplumber' ]"` is for.

Re: pipewire: update to 0.3.43

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/34904#issuecomment-1079768935

Comment:
> > Of course, if wireplumber is to be a new, official replacement for the old session manager, it seems that upstream should provide a clean way to build the entire apparatus together, such as by pulling wireplumber into the source tree.
> 
> > If it is ugly to build wireplumber as part of the pipewire package (I have an unverified suspicion that it may be), it may be less ugly to have a pipewire-bootstrap package or something that can satisfy the makedepends and checkdepends of pipewire to break the cycle.
> 
> This is what ` -Dsession-managers="[ 'wireplumber' ]"` is for.

How does that solve that pipewire would depend on wireplumber and wireplumber on pipewire? How are we supposed to build that from a clean state?

Re: pipewire: update to 0.3.43

[prez]

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

New comment by prez on void-packages repository

https://github.com/void-linux/void-packages/pull/34904#issuecomment-1079769541

Comment:
>How does that solve that pipewire would depend on wireplumber and wireplumber on pipewire? How are we supposed to build that from a clean state?

It doesn't, I'm guessing it would need to be one package, the same way pipewire-media-session is part of the pipewire package right now.

Re: pipewire: update to 0.3.43

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/34904#issuecomment-1098447468

Comment:
@ahesford If we build pipewire with `-Dsession-managers=[ ]`, then wireplumber is not a depenency of pipewire, so no cycle.
We should also split a separate pipewire-media-session pkg, which depends on pipewire, and use e.g. the above simple script to determine which session manager is used.

How does this sound?

Re: pipewire: update to 0.3.43

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/34904#issuecomment-1099329240

Comment:
Disabling the default session manager or separating it into a subpackage just leaves pipewire broken until you install one of the session managers and isn't really a workable solution. I think the only way to really manage this, short of upstream internalizing wireplumber (which I still think they should do, if it's the "official" session manager for pipewire), would be to create a meta package from an external template that depends on both pipewire and the preferred session manager; then we just have to tell people to install `pipewire-void` or something instead of just the pipewire package.

Of course, this update would break existing setups unless we violate our naming conventions and move pipewire to "pipewire-core" or something and name the meta-package "pipewire".