* [PR PATCH] Manual.md: add documentation for XBPS_ORIG_MAKEJOBS
@ 2022-02-21 15:46 classabbyamp
2022-02-21 21:04 ` [PR REVIEW] " Chocimier
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: classabbyamp @ 2022-02-21 15:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
There is a new pull request by classabbyamp against master on the void-packages repository
https://github.com/classabbyamp/void-packages patch-1
https://github.com/void-linux/void-packages/pull/35731
Manual.md: add documentation for XBPS_ORIG_MAKEJOBS
documents the variable added in #34989
A patch file from https://github.com/void-linux/void-packages/pull/35731.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-35731.patch --]
[-- Type: text/x-diff, Size: 1108 bytes --]
From fae693d3c1fd9152f8583451206506c158b6b1cb Mon Sep 17 00:00:00 2001
From: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
Date: Mon, 21 Feb 2022 10:46:12 -0500
Subject: [PATCH] Manual.md: add documentation for XBPS_ORIG_MAKEJOBS
documents the variable added in #34989
---
Manual.md | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Manual.md b/Manual.md
index d9081d023d1f..948987599f35 100644
--- a/Manual.md
+++ b/Manual.md
@@ -604,7 +604,9 @@ patches to the package sources during `do_patch()`. Patches are stored in
`srcpkgs/<pkgname>/patches` and must be in `-p1` format. By default set to `-Np1`.
- `disable_parallel_build` If set the package won't be built in parallel
-and `XBPS_MAKEJOBS` has no effect.
+and `XBPS_MAKEJOBS` has no effect. If a package does not work well with `XBPS_MAKEJOBS`
+but still has a mechanism to build in parallel, set `disable_parallel_build` and
+use `XBPS_ORIG_MAKEJOBS` instead.
- `make_check` Sets the cases in which the `check` phase is run.
This option has to be accompanied by a comment explaining why the tests fail.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] Manual.md: add documentation for XBPS_ORIG_MAKEJOBS
2022-02-21 15:46 [PR PATCH] Manual.md: add documentation for XBPS_ORIG_MAKEJOBS classabbyamp
@ 2022-02-21 21:04 ` Chocimier
2022-02-22 0:20 ` [PR PATCH] [Updated] " classabbyamp
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Chocimier @ 2022-02-21 21:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 387 bytes --]
New review comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/35731#discussion_r811427454
Comment:
> "use `XBPS_ORIG_MAKEJOBS`
This is a bit ambiguous regarding to where from it comes. What about
> and `XBPS_MAKEJOBS` is reset to 1.
> in template read value of `XBPS_ORIG_MAKEJOBS`, which is what `XBPS_MAKEJOBS` was reset from?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] Manual.md: add documentation for XBPS_ORIG_MAKEJOBS
2022-02-21 15:46 [PR PATCH] Manual.md: add documentation for XBPS_ORIG_MAKEJOBS classabbyamp
2022-02-21 21:04 ` [PR REVIEW] " Chocimier
@ 2022-02-22 0:20 ` classabbyamp
2022-02-22 0:21 ` [PR REVIEW] " classabbyamp
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2022-02-22 0:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 389 bytes --]
There is an updated pull request by classabbyamp against master on the void-packages repository
https://github.com/classabbyamp/void-packages patch-1
https://github.com/void-linux/void-packages/pull/35731
Manual.md: add documentation for XBPS_ORIG_MAKEJOBS
documents the variable added in #34989
A patch file from https://github.com/void-linux/void-packages/pull/35731.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-35731.patch --]
[-- Type: text/x-diff, Size: 1171 bytes --]
From a73e7f52bdfefa8160ff5e9b13ee76cff3333218 Mon Sep 17 00:00:00 2001
From: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
Date: Mon, 21 Feb 2022 10:46:12 -0500
Subject: [PATCH] Manual.md: add documentation for XBPS_ORIG_MAKEJOBS
documents the variable added in #34989
---
Manual.md | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Manual.md b/Manual.md
index d9081d023d1f..3165a57da4e4 100644
--- a/Manual.md
+++ b/Manual.md
@@ -604,7 +604,9 @@ patches to the package sources during `do_patch()`. Patches are stored in
`srcpkgs/<pkgname>/patches` and must be in `-p1` format. By default set to `-Np1`.
- `disable_parallel_build` If set the package won't be built in parallel
-and `XBPS_MAKEJOBS` has no effect.
+and `XBPS_MAKEJOBS` will be set to 1. If a package does not work well with `XBPS_MAKEJOBS`
+but still has a mechanism to build in parallel, set `disable_parallel_build` and
+use `XBPS_ORIG_MAKEJOBS`, which holds the original value of `XBPS_MAKEJOBS`, in the template.
- `make_check` Sets the cases in which the `check` phase is run.
This option has to be accompanied by a comment explaining why the tests fail.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR REVIEW] Manual.md: add documentation for XBPS_ORIG_MAKEJOBS
2022-02-21 15:46 [PR PATCH] Manual.md: add documentation for XBPS_ORIG_MAKEJOBS classabbyamp
2022-02-21 21:04 ` [PR REVIEW] " Chocimier
2022-02-22 0:20 ` [PR PATCH] [Updated] " classabbyamp
@ 2022-02-22 0:21 ` classabbyamp
2022-02-22 6:34 ` [PR PATCH] [Updated] " classabbyamp
2022-02-22 16:54 ` [PR PATCH] [Merged]: " Chocimier
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2022-02-22 0:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 179 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/35731#discussion_r811490290
Comment:
Updated. How's it look now?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] Manual.md: add documentation for XBPS_ORIG_MAKEJOBS
2022-02-21 15:46 [PR PATCH] Manual.md: add documentation for XBPS_ORIG_MAKEJOBS classabbyamp
` (2 preceding siblings ...)
2022-02-22 0:21 ` [PR REVIEW] " classabbyamp
@ 2022-02-22 6:34 ` classabbyamp
2022-02-22 16:54 ` [PR PATCH] [Merged]: " Chocimier
4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2022-02-22 6:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 389 bytes --]
There is an updated pull request by classabbyamp against master on the void-packages repository
https://github.com/classabbyamp/void-packages patch-1
https://github.com/void-linux/void-packages/pull/35731
Manual.md: add documentation for XBPS_ORIG_MAKEJOBS
documents the variable added in #34989
A patch file from https://github.com/void-linux/void-packages/pull/35731.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-35731.patch --]
[-- Type: text/x-diff, Size: 1171 bytes --]
From d205ab1a0d07f4192888b2427b34b860cb8cb94f Mon Sep 17 00:00:00 2001
From: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
Date: Mon, 21 Feb 2022 10:46:12 -0500
Subject: [PATCH] Manual.md: add documentation for XBPS_ORIG_MAKEJOBS
documents the variable added in #34989
---
Manual.md | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Manual.md b/Manual.md
index d9081d023d1f..40b2321f7a25 100644
--- a/Manual.md
+++ b/Manual.md
@@ -604,7 +604,9 @@ patches to the package sources during `do_patch()`. Patches are stored in
`srcpkgs/<pkgname>/patches` and must be in `-p1` format. By default set to `-Np1`.
- `disable_parallel_build` If set the package won't be built in parallel
-and `XBPS_MAKEJOBS` has no effect.
+and `XBPS_MAKEJOBS` will be set to 1. If a package does not work well with `XBPS_MAKEJOBS`
+but still has a mechanism to build in parallel, set `disable_parallel_build` and
+use `XBPS_ORIG_MAKEJOBS` (which holds the original value of `XBPS_MAKEJOBS`) in the template.
- `make_check` Sets the cases in which the `check` phase is run.
This option has to be accompanied by a comment explaining why the tests fail.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: Manual.md: add documentation for XBPS_ORIG_MAKEJOBS
2022-02-21 15:46 [PR PATCH] Manual.md: add documentation for XBPS_ORIG_MAKEJOBS classabbyamp
` (3 preceding siblings ...)
2022-02-22 6:34 ` [PR PATCH] [Updated] " classabbyamp
@ 2022-02-22 16:54 ` Chocimier
4 siblings, 0 replies; 6+ messages in thread
From: Chocimier @ 2022-02-22 16:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 223 bytes --]
There's a merged pull request on the void-packages repository
Manual.md: add documentation for XBPS_ORIG_MAKEJOBS
https://github.com/void-linux/void-packages/pull/35731
Description:
documents the variable added in #34989
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-02-22 16:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-21 15:46 [PR PATCH] Manual.md: add documentation for XBPS_ORIG_MAKEJOBS classabbyamp
2022-02-21 21:04 ` [PR REVIEW] " Chocimier
2022-02-22 0:20 ` [PR PATCH] [Updated] " classabbyamp
2022-02-22 0:21 ` [PR REVIEW] " classabbyamp
2022-02-22 6:34 ` [PR PATCH] [Updated] " classabbyamp
2022-02-22 16:54 ` [PR PATCH] [Merged]: " Chocimier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).