* Re: [PR PATCH] [Updated] New package: q5go-2.12
2022-02-23 20:33 [PR PATCH] New package: q5go-2.12 jason1987d
@ 2022-02-23 20:40 ` jason1987d
2022-02-23 20:42 ` [PR REVIEW] " Chocimier
` (9 subsequent siblings)
10 siblings, 0 replies; 15+ messages in thread
From: jason1987d @ 2022-02-23 20:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]
There is an updated pull request by jason1987d against master on the void-packages repository
https://github.com/jason1987d/void-packages q5go
https://github.com/void-linux/void-packages/pull/35809
New package: q5go-2.12
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/35809.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-q5go-35809.patch --]
[-- Type: text/x-diff, Size: 1635 bytes --]
From 162c96f5f6717220a3cd06b028163765445bcfe6 Mon Sep 17 00:00:00 2001
From: Jason Manley <jason@jasondavid.tv>
Date: Wed, 19 Jan 2022 10:49:27 -0600
Subject: [PATCH] New package: q5go-2.12
---
srcpkgs/q5go/template | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
create mode 100644 srcpkgs/q5go/template
diff --git a/srcpkgs/q5go/template b/srcpkgs/q5go/template
new file mode 100644
index 000000000000..123aacb84842
--- /dev/null
+++ b/srcpkgs/q5go/template
@@ -0,0 +1,21 @@
+# Template file for 'q5go'
+pkgname=q5go
+version=2.1.2
+revision=1
+archs="i686 x86_64"
+wrksrc="q5Go-${pkgname}-${version}"
+build_style=qmake
+configure_args="src/q5go.pro"
+makedepends="qt5-qmake qt5-multimedia-devel qt5-svg-devel"
+short_desc="Qt5 Go/Weiqi/Baduk client modernized from qGo"
+maintainer="Jason Manley <jason@jasondavid.tv>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/bernds/q5Go"
+distfiles="https://github.com/bernds/q5Go/archive/refs/tags/${pkgname}-${version}.tar.gz"
+checksum=00a685eed2bb4318ce148e916248def63ac484dda6eb8b3cda501a526e215d67
+
+post_install() {
+ qmake -install qinstall "${wrksrc}/src/images/clientwindow/Bowl.png" "${DESTDIR}/usr/share/q5go/Bowl.png"
+ qmake -install qinstall "${wrksrc}/templates/qgo.desktop" "${DESTDIR}/usr/share/applications/q5go.desktop"
+ sed -i -e 's/Name=qgo/Name=q5go/g' -e 's/Comment=qgo/Comment=q5go/g' -e 's/Exec=qgo/Exec=q5go/g' -e 's/Icon=\/usr\/share\/qGo\/pics\/Bowl\.png/Icon=\/usr\/share\/q5go\/Bowl\.png/g' -e 's/MimeType=text\/plain\;text\/sfg\;Application/MimeType=application\/x-go-sgf;/g' "${DESTDIR}/usr/share/applications/q5go.desktop"
+}
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PR REVIEW] New package: q5go-2.12
2022-02-23 20:33 [PR PATCH] New package: q5go-2.12 jason1987d
2022-02-23 20:40 ` [PR PATCH] [Updated] " jason1987d
@ 2022-02-23 20:42 ` Chocimier
2022-02-23 20:57 ` [PR PATCH] [Updated] " jason1987d
` (8 subsequent siblings)
10 siblings, 0 replies; 15+ messages in thread
From: Chocimier @ 2022-02-23 20:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 211 bytes --]
New review comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/35809#discussion_r813300406
Comment:
Nope, figure out cross build. dropping `archs=` is first step.
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PR PATCH] [Updated] New package: q5go-2.12
2022-02-23 20:33 [PR PATCH] New package: q5go-2.12 jason1987d
2022-02-23 20:40 ` [PR PATCH] [Updated] " jason1987d
2022-02-23 20:42 ` [PR REVIEW] " Chocimier
@ 2022-02-23 20:57 ` jason1987d
2022-02-23 21:42 ` jason1987d
` (7 subsequent siblings)
10 siblings, 0 replies; 15+ messages in thread
From: jason1987d @ 2022-02-23 20:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]
There is an updated pull request by jason1987d against master on the void-packages repository
https://github.com/jason1987d/void-packages q5go
https://github.com/void-linux/void-packages/pull/35809
New package: q5go-2.12
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/35809.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-q5go-35809.patch --]
[-- Type: text/x-diff, Size: 1635 bytes --]
From 162c96f5f6717220a3cd06b028163765445bcfe6 Mon Sep 17 00:00:00 2001
From: Jason Manley <jason@jasondavid.tv>
Date: Wed, 19 Jan 2022 10:49:27 -0600
Subject: [PATCH] New package: q5go-2.12
---
srcpkgs/q5go/template | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
create mode 100644 srcpkgs/q5go/template
diff --git a/srcpkgs/q5go/template b/srcpkgs/q5go/template
new file mode 100644
index 000000000000..123aacb84842
--- /dev/null
+++ b/srcpkgs/q5go/template
@@ -0,0 +1,21 @@
+# Template file for 'q5go'
+pkgname=q5go
+version=2.1.2
+revision=1
+archs="i686 x86_64"
+wrksrc="q5Go-${pkgname}-${version}"
+build_style=qmake
+configure_args="src/q5go.pro"
+makedepends="qt5-qmake qt5-multimedia-devel qt5-svg-devel"
+short_desc="Qt5 Go/Weiqi/Baduk client modernized from qGo"
+maintainer="Jason Manley <jason@jasondavid.tv>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/bernds/q5Go"
+distfiles="https://github.com/bernds/q5Go/archive/refs/tags/${pkgname}-${version}.tar.gz"
+checksum=00a685eed2bb4318ce148e916248def63ac484dda6eb8b3cda501a526e215d67
+
+post_install() {
+ qmake -install qinstall "${wrksrc}/src/images/clientwindow/Bowl.png" "${DESTDIR}/usr/share/q5go/Bowl.png"
+ qmake -install qinstall "${wrksrc}/templates/qgo.desktop" "${DESTDIR}/usr/share/applications/q5go.desktop"
+ sed -i -e 's/Name=qgo/Name=q5go/g' -e 's/Comment=qgo/Comment=q5go/g' -e 's/Exec=qgo/Exec=q5go/g' -e 's/Icon=\/usr\/share\/qGo\/pics\/Bowl\.png/Icon=\/usr\/share\/q5go\/Bowl\.png/g' -e 's/MimeType=text\/plain\;text\/sfg\;Application/MimeType=application\/x-go-sgf;/g' "${DESTDIR}/usr/share/applications/q5go.desktop"
+}
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PR PATCH] [Updated] New package: q5go-2.12
2022-02-23 20:33 [PR PATCH] New package: q5go-2.12 jason1987d
` (2 preceding siblings ...)
2022-02-23 20:57 ` [PR PATCH] [Updated] " jason1987d
@ 2022-02-23 21:42 ` jason1987d
2022-02-23 22:04 ` [PR REVIEW] " Chocimier
` (6 subsequent siblings)
10 siblings, 0 replies; 15+ messages in thread
From: jason1987d @ 2022-02-23 21:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]
There is an updated pull request by jason1987d against master on the void-packages repository
https://github.com/jason1987d/void-packages q5go
https://github.com/void-linux/void-packages/pull/35809
New package: q5go-2.12
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/35809.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-q5go-35809.patch --]
[-- Type: text/x-diff, Size: 2949 bytes --]
From 162c96f5f6717220a3cd06b028163765445bcfe6 Mon Sep 17 00:00:00 2001
From: Jason Manley <jason@jasondavid.tv>
Date: Wed, 19 Jan 2022 10:49:27 -0600
Subject: [PATCH 1/3] New package: q5go-2.12
---
srcpkgs/q5go/template | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
create mode 100644 srcpkgs/q5go/template
diff --git a/srcpkgs/q5go/template b/srcpkgs/q5go/template
new file mode 100644
index 000000000000..123aacb84842
--- /dev/null
+++ b/srcpkgs/q5go/template
@@ -0,0 +1,21 @@
+# Template file for 'q5go'
+pkgname=q5go
+version=2.1.2
+revision=1
+archs="i686 x86_64"
+wrksrc="q5Go-${pkgname}-${version}"
+build_style=qmake
+configure_args="src/q5go.pro"
+makedepends="qt5-qmake qt5-multimedia-devel qt5-svg-devel"
+short_desc="Qt5 Go/Weiqi/Baduk client modernized from qGo"
+maintainer="Jason Manley <jason@jasondavid.tv>"
+license="GPL-3.0-or-later"
+homepage="https://github.com/bernds/q5Go"
+distfiles="https://github.com/bernds/q5Go/archive/refs/tags/${pkgname}-${version}.tar.gz"
+checksum=00a685eed2bb4318ce148e916248def63ac484dda6eb8b3cda501a526e215d67
+
+post_install() {
+ qmake -install qinstall "${wrksrc}/src/images/clientwindow/Bowl.png" "${DESTDIR}/usr/share/q5go/Bowl.png"
+ qmake -install qinstall "${wrksrc}/templates/qgo.desktop" "${DESTDIR}/usr/share/applications/q5go.desktop"
+ sed -i -e 's/Name=qgo/Name=q5go/g' -e 's/Comment=qgo/Comment=q5go/g' -e 's/Exec=qgo/Exec=q5go/g' -e 's/Icon=\/usr\/share\/qGo\/pics\/Bowl\.png/Icon=\/usr\/share\/q5go\/Bowl\.png/g' -e 's/MimeType=text\/plain\;text\/sfg\;Application/MimeType=application\/x-go-sgf;/g' "${DESTDIR}/usr/share/applications/q5go.desktop"
+}
From c53e816f780b30f4e5d04b93365352a1a6b5f422 Mon Sep 17 00:00:00 2001
From: Jason Manley <jason@jasondavid.tv>
Date: Wed, 23 Feb 2022 14:57:28 -0600
Subject: [PATCH 2/3] New package: q5go-2.12
---
srcpkgs/q5go/template | 1 -
1 file changed, 1 deletion(-)
diff --git a/srcpkgs/q5go/template b/srcpkgs/q5go/template
index 123aacb84842..fa9790b5c29c 100644
--- a/srcpkgs/q5go/template
+++ b/srcpkgs/q5go/template
@@ -2,7 +2,6 @@
pkgname=q5go
version=2.1.2
revision=1
-archs="i686 x86_64"
wrksrc="q5Go-${pkgname}-${version}"
build_style=qmake
configure_args="src/q5go.pro"
From fa37c9b692beaad91c6def7f913c74855e6ce199 Mon Sep 17 00:00:00 2001
From: Jason Manley <jason@jasondavid.tv>
Date: Wed, 23 Feb 2022 14:57:28 -0600
Subject: [PATCH 3/3] New package: q5go-2.12
---
srcpkgs/q5go/template | 1 +
1 file changed, 1 insertion(+)
diff --git a/srcpkgs/q5go/template b/srcpkgs/q5go/template
index fa9790b5c29c..c93918af8299 100644
--- a/srcpkgs/q5go/template
+++ b/srcpkgs/q5go/template
@@ -5,6 +5,7 @@ revision=1
wrksrc="q5Go-${pkgname}-${version}"
build_style=qmake
configure_args="src/q5go.pro"
+hostmakedepends="qt5-qmake"
makedepends="qt5-qmake qt5-multimedia-devel qt5-svg-devel"
short_desc="Qt5 Go/Weiqi/Baduk client modernized from qGo"
maintainer="Jason Manley <jason@jasondavid.tv>"
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PR REVIEW] New package: q5go-2.12
2022-02-23 20:33 [PR PATCH] New package: q5go-2.12 jason1987d
` (3 preceding siblings ...)
2022-02-23 21:42 ` jason1987d
@ 2022-02-23 22:04 ` Chocimier
2022-02-23 22:07 ` jason1987d
` (5 subsequent siblings)
10 siblings, 0 replies; 15+ messages in thread
From: Chocimier @ 2022-02-23 22:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
New review comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/35809#discussion_r813363815
Comment:
It's getting better :) You can check locally with `./xbps-src -a aarch64 pkg q5go`
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PR REVIEW] New package: q5go-2.12
2022-02-23 20:33 [PR PATCH] New package: q5go-2.12 jason1987d
` (4 preceding siblings ...)
2022-02-23 22:04 ` [PR REVIEW] " Chocimier
@ 2022-02-23 22:07 ` jason1987d
2022-02-23 22:16 ` Chocimier
` (4 subsequent siblings)
10 siblings, 0 replies; 15+ messages in thread
From: jason1987d @ 2022-02-23 22:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
New review comment by jason1987d on void-packages repository
https://github.com/void-linux/void-packages/pull/35809#discussion_r813366019
Comment:
The package itself shows no documentation on which archs etc... what's the best next step as to figuring out how to get this to run on other archs? That local check is useful too.
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PR REVIEW] New package: q5go-2.12
2022-02-23 20:33 [PR PATCH] New package: q5go-2.12 jason1987d
` (5 preceding siblings ...)
2022-02-23 22:07 ` jason1987d
@ 2022-02-23 22:16 ` Chocimier
2022-02-23 22:21 ` jason1987d
` (3 subsequent siblings)
10 siblings, 0 replies; 15+ messages in thread
From: Chocimier @ 2022-02-23 22:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
New review comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/35809#discussion_r813372226
Comment:
Usually one adds necessary deps/flags/whatever until it compiles. At that point we assume it runs as well if build system is common. qmake is.
If you hit something you can't figure out, push that and ask.
```
$ xlocate bin/uic
qt5-host-tools-5.15.3+20211001_2 /usr/lib/qt5/bin/uic
```
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PR REVIEW] New package: q5go-2.12
2022-02-23 20:33 [PR PATCH] New package: q5go-2.12 jason1987d
` (6 preceding siblings ...)
2022-02-23 22:16 ` Chocimier
@ 2022-02-23 22:21 ` jason1987d
2022-02-23 22:54 ` jason1987d
` (2 subsequent siblings)
10 siblings, 0 replies; 15+ messages in thread
From: jason1987d @ 2022-02-23 22:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
New review comment by jason1987d on void-packages repository
https://github.com/void-linux/void-packages/pull/35809#discussion_r813375546
Comment:
Testing locally using aarch64. Change working so far is I copied the depends to hostmakedepends and now it's compiling. Though I will likely include that qt5-host-tools as a hostmakedepends as well.
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: New package: q5go-2.12
2022-02-23 20:33 [PR PATCH] New package: q5go-2.12 jason1987d
` (7 preceding siblings ...)
2022-02-23 22:21 ` jason1987d
@ 2022-02-23 22:54 ` jason1987d
2022-02-23 22:54 ` [PR PATCH] [Closed]: " jason1987d
2022-02-23 22:55 ` classabbyamp
10 siblings, 0 replies; 15+ messages in thread
From: jason1987d @ 2022-02-23 22:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
New comment by jason1987d on void-packages repository
https://github.com/void-linux/void-packages/pull/35809#issuecomment-1049294411
Comment:
I've set pull default to rebase so I won't have the issues with multiple commits. I will close this, create new as now mine builds on the other archs.
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PR PATCH] [Closed]: New package: q5go-2.12
2022-02-23 20:33 [PR PATCH] New package: q5go-2.12 jason1987d
` (8 preceding siblings ...)
2022-02-23 22:54 ` jason1987d
@ 2022-02-23 22:54 ` jason1987d
2022-02-23 22:55 ` classabbyamp
10 siblings, 0 replies; 15+ messages in thread
From: jason1987d @ 2022-02-23 22:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
There's a closed pull request on the void-packages repository
New package: q5go-2.12
https://github.com/void-linux/void-packages/pull/35809
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: New package: q5go-2.12
2022-02-23 20:33 [PR PATCH] New package: q5go-2.12 jason1987d
` (9 preceding siblings ...)
2022-02-23 22:54 ` [PR PATCH] [Closed]: " jason1987d
@ 2022-02-23 22:55 ` classabbyamp
10 siblings, 0 replies; 15+ messages in thread
From: classabbyamp @ 2022-02-23 22:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/35809#issuecomment-1049295356
Comment:
in the future, no need to close/open PRs, just use `git push --force`
^ permalink raw reply [flat|nested] 15+ messages in thread