From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: python3-prompt_toolkit: don't handle sigint
Date: Fri, 25 Feb 2022 16:53:10 +0100 [thread overview]
Message-ID: <20220225155310.pMnQYUTOI20YaH697TrYeLuIWVEKrGrqWIA31YCFt9Q@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35730@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/35730#issuecomment-1050972894
Comment:
Between the two options, I suppose I favor just disabling the SIGINT handler by default. Adding `cysignals` awareness to `prompt_toolkit` seems too special-purpose a fix; most people will not be using `cysignals` to add low-level signal handlers. It seems to me that the breakage here is with `cysignals`, which doesn't seem to be properly overriding the existing handler when it injects its own.
What I would like to see from upstream are some guidance about the following questions:
1. Is disabling SIGINT handling by default, and having xonsh turn it on explicitly, the right course of action?
2. If not, should this be fixed in IPython by providing a configuration option that can override the default SIGINT handler?
3. Is this better addressed (or even addressable at all) in the signal-handling logic of `cysignals`?
If upstream doesn't respond soon, we can pick up the original patch in this PR.
next prev parent reply other threads:[~2022-02-25 15:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 14:03 [PR PATCH] " tornaria
2022-02-21 14:11 ` ahesford
2022-02-21 14:11 ` ahesford
2022-02-21 14:35 ` tornaria
2022-02-24 20:59 ` [PR PATCH] [Updated] " tornaria
2022-02-24 21:01 ` tornaria
2022-02-25 15:53 ` ahesford [this message]
2022-02-25 21:46 ` tornaria
2022-02-25 22:11 ` ahesford
2022-02-27 18:19 ` tornaria
2022-02-27 21:48 ` ahesford
2022-02-27 21:49 ` ahesford
2022-02-27 21:49 ` ahesford
2022-02-28 1:35 ` [PR PATCH] [Updated] " tornaria
2022-02-28 1:59 ` tornaria
2022-02-28 2:25 ` [PR PATCH] [Merged]: " ahesford
2022-02-28 2:28 ` ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220225155310.pMnQYUTOI20YaH697TrYeLuIWVEKrGrqWIA31YCFt9Q@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).