Re: python3-prompt_toolkit: don't handle sigint

[ahesford <ahesford@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/35730#issuecomment-1051312288

Comment:
I misunderstood when `prompt_toolkit` installed and restored the signal handler; it certainly is problematic that the handler is overridden and restored repeatedly.

The "`cysignals` awareness" that I mention is your dependence on the `cysignals` package to save and restore signals set with `sigaction`. It's not clear to me that upstream would accept an (optional) dependence on `cysignals` to manage this. Furthermore, if managing signals set with `sigaction` is the right thing to do, it shouldn't be done only if the user chooses to install `cysignals`. Thus, either `cysignals` should become a hard requirement of `prompt_toolkit` or it should have its own method to save and restore these signals.

We really need some guidance from upstream about whether they intend to care about this problem at all and, if so, how they intend to solve it. I don't want to maintain indefinitely a custom `prompt_toolkit` patch that pulls in `cysignals` to manage these signals. If upstream wants to depend on it, so be it. If they don't care about this problem at all, we'll need another solution.