Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] .github: improve the PR template
@ 2022-03-23 14:40 tibequadorian
  2022-03-23 14:46 ` [PR PATCH] [Updated] " tibequadorian
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: tibequadorian @ 2022-03-23 14:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]

There is a new pull request by tibequadorian against master on the void-packages repository

https://github.com/tibequadorian/void-packages pr-template
https://github.com/void-linux/void-packages/pull/36297

.github: improve the PR template
related #36263

Currently the PR template may be a bit confusing because we write [skip CI] as markdown syntax which is very similar to [ci skip].
This syntax in a comment which is not meant to be uncommented is unintuitive so I propose wording it differently.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36297.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pr-template-36297.patch --]
[-- Type: text/x-diff, Size: 1235 bytes --]

From fd20e7e2901d07a3e55dbcdbcedaae883d83f0b2 Mon Sep 17 00:00:00 2001
From: tibequadorian <tibequadorian@posteo.de>
Date: Wed, 23 Mar 2022 15:23:00 +0100
Subject: [PATCH] .github: improve the PR template

* avoid confusion with [skip CI] and [ci skip]
---
 .github/pull_request_template.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index cc4b5721590e..e41e301a381d 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -8,7 +8,8 @@
 - This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
 -->
 
-<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
+<!-- Note: If the build is likely to take more than 2 hours, please skip CI as described in
+https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
 and test at least one native build and, if supported, at least one cross build.
 Ignore this section if this PR is not skipping CI.
 -->

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-03-26 15:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-23 14:40 [PR PATCH] .github: improve the PR template tibequadorian
2022-03-23 14:46 ` [PR PATCH] [Updated] " tibequadorian
2022-03-24  3:35 ` classabbyamp
2022-03-24 19:04 ` Chocimier
2022-03-26 13:43 ` [PR PATCH] [Updated] " tibequadorian
2022-03-26 15:45 ` [PR PATCH] [Merged]: " leahneukirchen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).