Github messages for voidlinux
 help / color / mirror / Atom feed
From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] mongoose: update to 7.6
Date: Tue, 29 Mar 2022 10:58:38 +0200	[thread overview]
Message-ID: <20220329085838.cjnJ--9RWoV2jDcjt5gi29mKd9Y1rvzkegeZzlcnm7Q@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36395@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/36395#discussion_r837228858

Comment:
Why patch the Makefile to install the docs? Just do it in the template. Patching here increases the chance that the patch will break with the next update.

  parent reply	other threads:[~2022-03-29  8:58 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 18:23 [PR PATCH] " subnut
2022-03-28 18:30 ` subnut
2022-03-28 18:31 ` subnut
2022-03-28 18:49 ` [PR REVIEW] " ahesford
2022-03-28 18:49 ` ahesford
2022-03-28 18:49 ` ahesford
2022-03-28 18:49 ` ahesford
2022-03-28 19:42 ` [PR PATCH] [Updated] " subnut
2022-03-28 19:44 ` [PR REVIEW] " subnut
2022-03-28 19:45 ` subnut
2022-03-28 20:17 ` Johnnynator
2022-03-29  2:16 ` subnut
2022-03-29  2:16 ` subnut
2022-03-29  3:39 ` [PR PATCH] [Updated] " subnut
2022-03-29  4:59 ` subnut
2022-03-29  5:21 ` subnut
2022-03-29  5:22 ` subnut
2022-03-29  5:32 ` subnut
2022-03-29  5:35 ` subnut
2022-03-29  6:05 ` subnut
2022-03-29  6:11 ` subnut
2022-03-29  6:15 ` [PR REVIEW] " subnut
2022-03-29  6:29 ` [PR PATCH] [Updated] " subnut
2022-03-29  6:36 ` subnut
2022-03-29  6:37 ` subnut
2022-03-29  6:38 ` subnut
2022-03-29  8:58 ` ahesford [this message]
2022-03-29  8:58 ` [PR REVIEW] " ahesford
2022-03-29 11:36 ` subnut
2022-03-29 12:07 ` ahesford
2022-03-29 12:21 ` [PR PATCH] [Updated] " subnut
2022-03-29 12:22 ` subnut
2022-03-29 12:37 ` subnut
2022-03-29 12:38 ` [PR REVIEW] " subnut
2022-03-29 12:47 ` [PR PATCH] [Updated] " subnut
2022-03-29 18:29 ` [PR REVIEW] " 0x5c
2022-03-29 18:57 ` subnut
2022-03-29 19:07 ` ahesford
2022-03-29 19:29 ` ahesford
2022-03-30  3:51 ` [PR PATCH] [Updated] " subnut
2022-03-30  4:03 ` [PR REVIEW] " subnut
2022-03-30  4:07 ` subnut
2022-03-30 15:10 ` [PR PATCH] [Updated] " subnut
2022-03-30 15:14 ` [PR REVIEW] " ahesford
2022-03-30 15:15 ` [PR PATCH] [Updated] " subnut
2022-03-30 15:19 ` subnut
2022-03-30 15:19 ` subnut
2022-03-30 15:50 ` subnut
2022-03-30 15:55 ` subnut
2022-03-30 15:55 ` subnut
2022-03-30 15:57 ` subnut
2022-03-30 16:11 ` subnut
2022-03-31 10:31 ` [PR REVIEW] " ahesford
2022-03-31 10:31 ` ahesford
2022-03-31 11:52 ` [PR PATCH] [Updated] " subnut
2022-03-31 11:54 ` subnut
2022-03-31 12:14 ` [PR PATCH] [Closed]: " ahesford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220329085838.cjnJ--9RWoV2jDcjt5gi29mKd9Y1rvzkegeZzlcnm7Q@z \
    --to=ahesford@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).