From: 0x5c <0x5c@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] Manual.md: document the check functions
Date: Thu, 31 Mar 2022 01:13:44 +0200 [thread overview]
Message-ID: <20220330231344.x8VCXQQu7x-eoCpcJRwcxNfomJmTUlkCKAAZ29lET6A@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36412@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 390 bytes --]
New review comment by 0x5c on void-packages repository
https://github.com/void-linux/void-packages/pull/36412#discussion_r839038013
Comment:
I was under the impression from the manual's description of `make_check` that `*_check()` won't always run. Same impression from the complete lack of running checks when doing anything but `xbps-src check` in an unmodified void-packages checkout.
next prev parent reply other threads:[~2022-03-30 23:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 6:21 [PR PATCH] " 0x5c
2022-03-30 18:17 ` [PR REVIEW] " Chocimier
2022-03-30 23:13 ` 0x5c [this message]
2022-03-31 17:00 ` Chocimier
2022-03-31 18:22 ` 0x5c
2022-04-01 0:20 ` [PR PATCH] [Updated] " 0x5c
2022-04-02 16:39 ` Chocimier
2022-04-02 16:39 ` [PR PATCH] [Merged]: " Chocimier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220330231344.x8VCXQQu7x-eoCpcJRwcxNfomJmTUlkCKAAZ29lET6A@z \
--to=0x5c@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).