Github messages for voidlinux
 help / color / mirror / Atom feed
From: 0x5c <0x5c@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] Manual.md: document the check functions
Date: Fri, 01 Apr 2022 02:20:29 +0200	[thread overview]
Message-ID: <20220401002029.eTwU4nOgvYG-xAY5GSziEHUKu2LYNlXB-nCCIuw_UIs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36412@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1451 bytes --]

There is an updated pull request by 0x5c against master on the void-packages repository

https://github.com/0x5c/void-packages manual-post-functions
https://github.com/void-linux/void-packages/pull/36412

Manual.md: document the check functions
The pre_/do_/post_check functions were not listed in the list of building
phase functions, and were not mentioned elsewhere (do_check was mentioned
once). This documents their existence.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36412.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-manual-post-functions-36412.patch --]
[-- Type: text/x-diff, Size: 1100 bytes --]

From 8b5fc7a7b28d177e68c779c7f8d5ee68f8b8e502 Mon Sep 17 00:00:00 2001
From: 0x5c <dev@0x5c.io>
Date: Wed, 30 Mar 2022 02:05:43 -0400
Subject: [PATCH] Manual.md: document the check functions

The pre_/do_/post_check functions were not listed in the list of building
phase functions, and were not mentioned elsewhere (do_check was mentioned
once). This documents their existence.
---
 Manual.md | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Manual.md b/Manual.md
index af5f698debae..8ec755499bbe 100644
--- a/Manual.md
+++ b/Manual.md
@@ -1101,7 +1101,13 @@ still be passed in if it's a GNU configure script.
 
 - `post_build()` Actions to execute after `do_build()`.
 
-- `pre_install()` Actions to execute after `post_build()`.
+- `pre_check()` Actions to execute after `post_build()`.
+
+- `do_check()` Actions to execute to run checks for the package.
+
+- `post_check()` Actions to execute after `do_check()`.
+
+- `pre_install()` Actions to execute after `post_check()`.
 
 - `do_install()` Actions to execute to install the package files into the `fake destdir`.
 

  parent reply	other threads:[~2022-04-01  0:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-30  6:21 [PR PATCH] " 0x5c
2022-03-30 18:17 ` [PR REVIEW] " Chocimier
2022-03-30 23:13 ` 0x5c
2022-03-31 17:00 ` Chocimier
2022-03-31 18:22 ` 0x5c
2022-04-01  0:20 ` 0x5c [this message]
2022-04-02 16:39 ` Chocimier
2022-04-02 16:39 ` [PR PATCH] [Merged]: " Chocimier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220401002029.eTwU4nOgvYG-xAY5GSziEHUKu2LYNlXB-nCCIuw_UIs@z \
    --to=0x5c@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).