From: tibequadorian <tibequadorian@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] [RFC] patch_args: allow use of --directory parameter
Date: Thu, 31 Mar 2022 21:59:45 +0200 [thread overview]
Message-ID: <20220331195945.Ts6S9bQjw4C9iEA4G7tlpXS3E12KF2XkOgCCq_4uGEA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36409@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 265 bytes --]
New review comment by tibequadorian on void-packages repository
https://github.com/void-linux/void-packages/pull/36409#discussion_r839971784
Comment:
Oh you mean `patch_args+=" --directory=${build_wrksrc}"`? I think this won't work because it overwrites `_args`.
next prev parent reply other threads:[~2022-03-31 19:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 23:10 [PR PATCH] " tibequadorian
2022-03-29 23:20 ` [PR PATCH] [Updated] " tibequadorian
2022-03-31 18:58 ` [PR REVIEW] " paper42
2022-03-31 19:19 ` tibequadorian
2022-03-31 19:26 ` paper42
2022-03-31 19:59 ` tibequadorian [this message]
2022-03-31 20:45 ` paper42
2022-04-09 11:03 ` paper42
2022-04-09 11:38 ` [PR PATCH] [Updated] " tibequadorian
2022-04-10 9:06 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220331195945.Ts6S9bQjw4C9iEA4G7tlpXS3E12KF2XkOgCCq_4uGEA@z \
--to=tibequadorian@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).