From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: [RFC] patch_args: allow use of --directory parameter
Date: Sun, 10 Apr 2022 11:06:33 +0200 [thread overview]
Message-ID: <20220410090633.rw40-siYCi3ayWrIC79SznZSsAGQNWxICfNYnCtKm3E@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36409@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1745 bytes --]
There's a merged pull request on the void-packages repository
[RFC] patch_args: allow use of --directory parameter
https://github.com/void-linux/void-packages/pull/36409
Description:
`patch(1)` has a `-d/--directory` parameter which allows us to specify a directory where the patch will be applied.
This is especially useful when we have multiple distfiles and want to patch in $build_wrksrc because that's where the patch is usually applied. So far, these patches had to be updated if $build_wrksrc changes, which is suboptimal.
Problem is, that the `-i` parameter is also relative to the the `-d` parameter and thus fails to find the patch, when `-d` is set.
This PR tries to solve that by using standard input instead of `-i`.
Included are examples with wine and chatterino2 making use of that change.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
prev parent reply other threads:[~2022-04-10 9:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 23:10 [PR PATCH] " tibequadorian
2022-03-29 23:20 ` [PR PATCH] [Updated] " tibequadorian
2022-03-31 18:58 ` [PR REVIEW] " paper42
2022-03-31 19:19 ` tibequadorian
2022-03-31 19:26 ` paper42
2022-03-31 19:59 ` tibequadorian
2022-03-31 20:45 ` paper42
2022-04-09 11:03 ` paper42
2022-04-09 11:38 ` [PR PATCH] [Updated] " tibequadorian
2022-04-10 9:06 ` paper42 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220410090633.rw40-siYCi3ayWrIC79SznZSsAGQNWxICfNYnCtKm3E@z \
--to=paper42@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).