From: the-maldridge <the-maldridge@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: onboard: fix SyntaxWarnings and disable tests
Date: Sat, 02 Apr 2022 03:54:21 +0200 [thread overview]
Message-ID: <20220402015421.EnmvdmmLN7p-25O8oQkGu0fVOFEEqkUC5EW-Um2vJx4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36398@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]
There's a merged pull request on the void-packages repository
onboard: fix SyntaxWarnings and disable tests
https://github.com/void-linux/void-packages/pull/36398
Description:
- A missing % operator was breaking a c-style format string, causing a
SyntaxWarning to be trown twice at package install time (during
byte-compilation).
- The tests were failing since they try to run 'killall' before executing
onboard in xautomation(7), both not being possible in xbps-src.
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
prev parent reply other threads:[~2022-04-02 1:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 23:28 [PR PATCH] onboard: fix SyntaxWarning in install 0x5c
2022-03-28 23:36 ` 0x5c
2022-03-29 0:12 ` 0x5c
2022-03-29 9:27 ` [PR PATCH] [Updated] " 0x5c
2022-03-29 9:30 ` onboard: fix SyntaxWarnings and disable tests 0x5c
2022-03-29 9:36 ` 0x5c
2022-04-02 1:54 ` the-maldridge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220402015421.EnmvdmmLN7p-25O8oQkGu0fVOFEEqkUC5EW-Um2vJx4@z \
--to=the-maldridge@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).