From: 0x5c <0x5c@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] onboard: fix SyntaxWarning in install
Date: Tue, 29 Mar 2022 11:27:35 +0200 [thread overview]
Message-ID: <20220329092735._Ptjct31A8oQB8togQjX5wUWu-nnTgRp-Ct-MUnSJXM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36398@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]
There is an updated pull request by 0x5c against master on the void-packages repository
https://github.com/0x5c/void-packages obboard-fix
https://github.com/void-linux/void-packages/pull/36398
onboard: fix SyntaxWarning in install
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/36398.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-obboard-fix-36398.patch --]
[-- Type: text/x-diff, Size: 2275 bytes --]
From 053b72f1b64e86bdbc5aa6d15fbf2491951fa402 Mon Sep 17 00:00:00 2001
From: 0x5c <dev@0x5c.io>
Date: Tue, 29 Mar 2022 05:26:18 -0400
Subject: [PATCH] onboard: fix SyntaxWarnings and disable tests
- A missing % operator was breaking a c-style format string, causing a
SyntaxWarning to be trown twice at package install time (during
byte-compilation).
- The tests were failing since they try to run 'killall' before executing
onboard in xautomation(7), both not being possible in xbps-src.
---
srcpkgs/onboard/patches/fix-brokenformat.patch | 15 +++++++++++++++
srcpkgs/onboard/template | 4 +++-
2 files changed, 18 insertions(+), 1 deletion(-)
create mode 100644 srcpkgs/onboard/patches/fix-brokenformat.patch
diff --git a/srcpkgs/onboard/patches/fix-brokenformat.patch b/srcpkgs/onboard/patches/fix-brokenformat.patch
new file mode 100644
index 000000000000..e5d200208a93
--- /dev/null
+++ b/srcpkgs/onboard/patches/fix-brokenformat.patch
@@ -0,0 +1,15 @@
+Fix for https://bugs.launchpad.net/onboard/+bug/1948723
+
+
+--
+--- a/Onboard/LayoutLoaderSVG.py
++++ b/Onboard/LayoutLoaderSVG.py
+@@ -445,7 +445,7 @@
+ except KeyError as ex:
+ (strerror) = ex
+ raise Exceptions.LayoutFileError("Unrecognized modifier %s in" \
+- "definition of %s" (strerror, full_id))
++ "definition of %s" % (strerror, full_id))
+
+ value = attributes.get("action")
+ if value:
diff --git a/srcpkgs/onboard/template b/srcpkgs/onboard/template
index c147bf58a65c..b138fae61897 100644
--- a/srcpkgs/onboard/template
+++ b/srcpkgs/onboard/template
@@ -1,7 +1,7 @@
# Template file for 'onboard'
pkgname=onboard
version=1.4.1
-revision=9
+revision=10
build_style=python3-module
hostmakedepends="intltool pkg-config python3-distutils-extra"
makedepends="dconf-devel eudev-libudev-devel gtk+3-devel hunspell-devel
@@ -14,3 +14,5 @@ license="GPL-3.0-or-later"
homepage="https://launchpad.net/onboard"
distfiles="https://launchpad.net/${pkgname}/${version%.*}/${version}/+download/${pkgname}-${version}.tar.gz"
checksum=01cae1ac5b1ef1ab985bd2d2d79ded6fc99ee04b1535cc1bb191e43a231a3865
+# Tries to run onboard in tests, using xautomation(7)
+make_check=no
next prev parent reply other threads:[~2022-03-29 9:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 23:28 [PR PATCH] " 0x5c
2022-03-28 23:36 ` 0x5c
2022-03-29 0:12 ` 0x5c
2022-03-29 9:27 ` 0x5c [this message]
2022-03-29 9:30 ` onboard: fix SyntaxWarnings and disable tests 0x5c
2022-03-29 9:36 ` 0x5c
2022-04-02 1:54 ` [PR PATCH] [Merged]: " the-maldridge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220329092735._Ptjct31A8oQB8togQjX5wUWu-nnTgRp-Ct-MUnSJXM@z \
--to=0x5c@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).