* Re: scripts/lint-commits: report github noreply emails
2021-05-21 17:48 [PR PATCH] scripts/lint-commits: report github noreply emails paper42
@ 2021-05-21 19:05 ` Chocimier
2021-05-21 20:08 ` ericonr
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Chocimier @ 2021-05-21 19:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 217 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/31053#issuecomment-846184457
Comment:
What's the point of asking for mail, when know github account of commiter?
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: scripts/lint-commits: report github noreply emails
2021-05-21 17:48 [PR PATCH] scripts/lint-commits: report github noreply emails paper42
2021-05-21 19:05 ` Chocimier
@ 2021-05-21 20:08 ` ericonr
2021-05-21 20:12 ` paper42
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: ericonr @ 2021-05-21 20:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/31053#issuecomment-846225730
Comment:
This is a big policy matter, because it means we won't accept contributions via GitHub UI anymore. Are we sure about it?
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: scripts/lint-commits: report github noreply emails
2021-05-21 17:48 [PR PATCH] scripts/lint-commits: report github noreply emails paper42
2021-05-21 19:05 ` Chocimier
2021-05-21 20:08 ` ericonr
@ 2021-05-21 20:12 ` paper42
2021-05-22 2:27 ` [PR REVIEW] [RFC]: " sgn
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: paper42 @ 2021-05-21 20:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/31053#issuecomment-846227386
Comment:
I sometimes contact package maintainers by email when I want to let them know about something (that's not suitable for an issue and they are not on IRC). I didn't have to contact a maintainer who doesn't have their email address public yet.
Also, people who have a github noreply email address often make their pull requests from the Github UI. I think that by itself is fine, but there is a higher probability that these changes are not well tested. Adding an email address shouldn't be a big problem for people. Void already requires email addresses in the maintainer field in package templates.
This is just a lint, so exceptions can be made, but I think having this information can be valuable.
> This is a big policy matter, because it means we won't accept contributions via GitHub UI anymore. Are we sure about it?
When people add a public email address to their account, they can use that address in the Github UI.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] [RFC]: scripts/lint-commits: report github noreply emails
2021-05-21 17:48 [PR PATCH] scripts/lint-commits: report github noreply emails paper42
` (2 preceding siblings ...)
2021-05-21 20:12 ` paper42
@ 2021-05-22 2:27 ` sgn
2021-05-22 8:50 ` [PR PATCH] [Updated] " paper42
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: sgn @ 2021-05-22 2:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/31053#discussion_r637341280
Comment:
Notwithstanding other non-technical questions. `NR == 3` sounds incorrect.
In my opinion, it should be
```suggestion
/^author .*noreply/ { print C ": commit author has a noreply email" }
```
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] [RFC]: scripts/lint-commits: report github noreply emails
2021-05-21 17:48 [PR PATCH] scripts/lint-commits: report github noreply emails paper42
` (3 preceding siblings ...)
2021-05-22 2:27 ` [PR REVIEW] [RFC]: " sgn
@ 2021-05-22 8:50 ` paper42
2021-05-22 8:50 ` [PR REVIEW] " paper42
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: paper42 @ 2021-05-22 8:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 370 bytes --]
There is an updated pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages lint-commits-noreply
https://github.com/void-linux/void-packages/pull/31053
[RFC]: scripts/lint-commits: report github noreply emails
ping @sgn
A patch file from https://github.com/void-linux/void-packages/pull/31053.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lint-commits-noreply-31053.patch --]
[-- Type: text/x-diff, Size: 753 bytes --]
From e7cc79c47f349d2119f90341239c6ea35a54159b Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Fri, 21 May 2021 19:06:36 +0200
Subject: [PATCH] scripts/lint-commits: report github noreply emails
---
common/scripts/lint-commits | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/scripts/lint-commits b/common/scripts/lint-commits
index 785bf0ef1d0d..2b15ba55ad67 100755
--- a/common/scripts/lint-commits
+++ b/common/scripts/lint-commits
@@ -31,6 +31,7 @@ for cmt in $("$GIT_CMD" rev-list --abbrev-commit $base..$tip)
do
"$GIT_CMD" cat-file commit "$cmt" |
awk -vC="$cmt" '
+ /author .*<.*noreply.*>/ { print C ": commit author has a noreply email" }
# skip header
/^$/ && !msg { msg = 1; next }
!msg { next }
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] [RFC]: scripts/lint-commits: report github noreply emails
2021-05-21 17:48 [PR PATCH] scripts/lint-commits: report github noreply emails paper42
` (4 preceding siblings ...)
2021-05-22 8:50 ` [PR PATCH] [Updated] " paper42
@ 2021-05-22 8:50 ` paper42
2021-05-23 3:39 ` sgn
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: paper42 @ 2021-05-22 8:50 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/31053#discussion_r637376305
Comment:
Thanks, I modified your suggestion a bit to fix some potential false positives
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] [RFC]: scripts/lint-commits: report github noreply emails
2021-05-21 17:48 [PR PATCH] scripts/lint-commits: report github noreply emails paper42
` (5 preceding siblings ...)
2021-05-22 8:50 ` [PR REVIEW] " paper42
@ 2021-05-23 3:39 ` sgn
2021-05-23 13:34 ` [PR PATCH] [Updated] " paper42
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: sgn @ 2021-05-23 3:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 166 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/31053#discussion_r637480970
Comment:
Please anchor `^author`
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] [RFC]: scripts/lint-commits: report github noreply emails
2021-05-21 17:48 [PR PATCH] scripts/lint-commits: report github noreply emails paper42
` (6 preceding siblings ...)
2021-05-23 3:39 ` sgn
@ 2021-05-23 13:34 ` paper42
2022-04-02 16:04 ` paper42
2022-04-02 16:04 ` [PR PATCH] [Closed]: " paper42
9 siblings, 0 replies; 11+ messages in thread
From: paper42 @ 2021-05-23 13:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 370 bytes --]
There is an updated pull request by paper42 against master on the void-packages repository
https://github.com/paper42/void-packages lint-commits-noreply
https://github.com/void-linux/void-packages/pull/31053
[RFC]: scripts/lint-commits: report github noreply emails
ping @sgn
A patch file from https://github.com/void-linux/void-packages/pull/31053.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lint-commits-noreply-31053.patch --]
[-- Type: text/x-diff, Size: 754 bytes --]
From 991de290567d9a3b9425e20c05159d22a52fe147 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Fri, 21 May 2021 19:06:36 +0200
Subject: [PATCH] scripts/lint-commits: report github noreply emails
---
common/scripts/lint-commits | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/scripts/lint-commits b/common/scripts/lint-commits
index 785bf0ef1d0d..eb13376d6051 100755
--- a/common/scripts/lint-commits
+++ b/common/scripts/lint-commits
@@ -31,6 +31,7 @@ for cmt in $("$GIT_CMD" rev-list --abbrev-commit $base..$tip)
do
"$GIT_CMD" cat-file commit "$cmt" |
awk -vC="$cmt" '
+ /^author .*<.*noreply.*>/ { print C ": commit author has a noreply email" }
# skip header
/^$/ && !msg { msg = 1; next }
!msg { next }
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [RFC]: scripts/lint-commits: report github noreply emails
2021-05-21 17:48 [PR PATCH] scripts/lint-commits: report github noreply emails paper42
` (7 preceding siblings ...)
2021-05-23 13:34 ` [PR PATCH] [Updated] " paper42
@ 2022-04-02 16:04 ` paper42
2022-04-02 16:04 ` [PR PATCH] [Closed]: " paper42
9 siblings, 0 replies; 11+ messages in thread
From: paper42 @ 2022-04-02 16:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/31053#issuecomment-1086669077
Comment:
This proposal doesn't seem to have support among team members, closing.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Closed]: [RFC]: scripts/lint-commits: report github noreply emails
2021-05-21 17:48 [PR PATCH] scripts/lint-commits: report github noreply emails paper42
` (8 preceding siblings ...)
2022-04-02 16:04 ` paper42
@ 2022-04-02 16:04 ` paper42
9 siblings, 0 replies; 11+ messages in thread
From: paper42 @ 2022-04-02 16:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 201 bytes --]
There's a closed pull request on the void-packages repository
[RFC]: scripts/lint-commits: report github noreply emails
https://github.com/void-linux/void-packages/pull/31053
Description:
ping @sgn
^ permalink raw reply [flat|nested] 11+ messages in thread