Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] python3-svg.path: update to 5.1.
@ 2022-04-02 17:05 karl-nilsson
  2022-04-02 20:19 ` [PR REVIEW] " paper42
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: karl-nilsson @ 2022-04-02 17:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]

There is a new pull request by karl-nilsson against master on the void-packages repository

https://github.com/karl-nilsson/void-packages python3-svg
https://github.com/void-linux/void-packages/pull/36471

python3-svg.path: update to 5.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x64_glibc

One test fails because of cross-platform font rendering discrepancies, so I disabled it.
I opened an issue upstream https://github.com/regebro/svg.path/issues/84



A patch file from https://github.com/void-linux/void-packages/pull/36471.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-svg-36471.patch --]
[-- Type: text/x-diff, Size: 1306 bytes --]

From 4026b9736317e013b9a8185630a273c08d972956 Mon Sep 17 00:00:00 2001
From: Karl Nilsson <karl.robert.nilsson@gmail.com>
Date: Sat, 2 Apr 2022 11:09:17 -0400
Subject: [PATCH] python3-svg.path: update to 5.1.

---
 srcpkgs/python3-svg.path/template | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/python3-svg.path/template b/srcpkgs/python3-svg.path/template
index 6abf6ff8ca83..a31156a63bab 100644
--- a/srcpkgs/python3-svg.path/template
+++ b/srcpkgs/python3-svg.path/template
@@ -1,17 +1,19 @@
 # Template file for 'python3-svg.path'
 pkgname=python3-svg.path
-version=4.1
-revision=3
+version=5.1
+revision=1
 wrksrc="svg.path-${version}"
 build_style=python3-module
+# disable failing test
+make_check_args="-k not(ImageTest)"
 hostmakedepends="python3-setuptools"
-depends="python3"
+checkdepends="python3-pytest-cov python3-Pillow"
 short_desc="Python3 SVG path parser"
 maintainer="Karl Nilsson <karl.robert.nilsson@gmail.com>"
 license="MIT"
 homepage="https://github.com/regebro/svg.path"
 distfiles="https://github.com/regebro/svg.path/archive/${version}.tar.gz"
-checksum=8fe78a5ff8f379c78dac4a3ba623068a8a2af434dace24103a053e06525d400d
+checksum=2ea5351a5886f8c55ae8fddb2f7182dca3d5760c03abade9cb256b91e4bb9bb4
 
 post_install() {
 	vlicense LICENSE.txt

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] python3-svg.path: update to 5.1.
  2022-04-02 17:05 [PR PATCH] python3-svg.path: update to 5.1 karl-nilsson
@ 2022-04-02 20:19 ` paper42
  2022-04-02 20:25 ` [PR PATCH] [Updated] " karl-nilsson
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2022-04-02 20:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36471#discussion_r841115501

Comment:
Was $depends removed by mistake?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] python3-svg.path: update to 5.1.
  2022-04-02 17:05 [PR PATCH] python3-svg.path: update to 5.1 karl-nilsson
  2022-04-02 20:19 ` [PR REVIEW] " paper42
@ 2022-04-02 20:25 ` karl-nilsson
  2022-04-02 20:26 ` [PR REVIEW] " karl-nilsson
  2022-04-02 21:08 ` [PR PATCH] [Merged]: " paper42
  3 siblings, 0 replies; 5+ messages in thread
From: karl-nilsson @ 2022-04-02 20:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]

There is an updated pull request by karl-nilsson against master on the void-packages repository

https://github.com/karl-nilsson/void-packages python3-svg
https://github.com/void-linux/void-packages/pull/36471

python3-svg.path: update to 5.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x64_glibc

One test fails because of cross-platform font rendering discrepancies, so I disabled it.
I opened an issue upstream https://github.com/regebro/svg.path/issues/84



A patch file from https://github.com/void-linux/void-packages/pull/36471.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-python3-svg-36471.patch --]
[-- Type: text/x-diff, Size: 1304 bytes --]

From 130d416ac18f69267209c6c48c8fc280ecdad6c1 Mon Sep 17 00:00:00 2001
From: Karl Nilsson <karl.robert.nilsson@gmail.com>
Date: Sat, 2 Apr 2022 11:09:17 -0400
Subject: [PATCH] python3-svg.path: update to 5.1.

---
 srcpkgs/python3-svg.path/template | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-svg.path/template b/srcpkgs/python3-svg.path/template
index 6abf6ff8ca83..0d92697a0a9a 100644
--- a/srcpkgs/python3-svg.path/template
+++ b/srcpkgs/python3-svg.path/template
@@ -1,17 +1,20 @@
 # Template file for 'python3-svg.path'
 pkgname=python3-svg.path
-version=4.1
-revision=3
+version=5.1
+revision=1
 wrksrc="svg.path-${version}"
 build_style=python3-module
+# disable failing test
+make_check_args="-k not(ImageTest)"
 hostmakedepends="python3-setuptools"
 depends="python3"
+checkdepends="python3-pytest-cov python3-Pillow"
 short_desc="Python3 SVG path parser"
 maintainer="Karl Nilsson <karl.robert.nilsson@gmail.com>"
 license="MIT"
 homepage="https://github.com/regebro/svg.path"
 distfiles="https://github.com/regebro/svg.path/archive/${version}.tar.gz"
-checksum=8fe78a5ff8f379c78dac4a3ba623068a8a2af434dace24103a053e06525d400d
+checksum=2ea5351a5886f8c55ae8fddb2f7182dca3d5760c03abade9cb256b91e4bb9bb4
 
 post_install() {
 	vlicense LICENSE.txt

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] python3-svg.path: update to 5.1.
  2022-04-02 17:05 [PR PATCH] python3-svg.path: update to 5.1 karl-nilsson
  2022-04-02 20:19 ` [PR REVIEW] " paper42
  2022-04-02 20:25 ` [PR PATCH] [Updated] " karl-nilsson
@ 2022-04-02 20:26 ` karl-nilsson
  2022-04-02 21:08 ` [PR PATCH] [Merged]: " paper42
  3 siblings, 0 replies; 5+ messages in thread
From: karl-nilsson @ 2022-04-02 20:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New review comment by karl-nilsson on void-packages repository

https://github.com/void-linux/void-packages/pull/36471#discussion_r841116052

Comment:
yep! thanks for catching that

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: python3-svg.path: update to 5.1.
  2022-04-02 17:05 [PR PATCH] python3-svg.path: update to 5.1 karl-nilsson
                   ` (2 preceding siblings ...)
  2022-04-02 20:26 ` [PR REVIEW] " karl-nilsson
@ 2022-04-02 21:08 ` paper42
  3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2022-04-02 21:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]

There's a merged pull request on the void-packages repository

python3-svg.path: update to 5.1.
https://github.com/void-linux/void-packages/pull/36471

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, x64_glibc

One test fails because of cross-platform font rendering discrepancies, so I disabled it.
I opened an issue upstream https://github.com/regebro/svg.path/issues/84



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-04-02 21:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-02 17:05 [PR PATCH] python3-svg.path: update to 5.1 karl-nilsson
2022-04-02 20:19 ` [PR REVIEW] " paper42
2022-04-02 20:25 ` [PR PATCH] [Updated] " karl-nilsson
2022-04-02 20:26 ` [PR REVIEW] " karl-nilsson
2022-04-02 21:08 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).