Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] mdocml: fix readability issues in void-man-cgi.
@ 2022-04-07 16:20 mjyut
  2022-04-07 16:44 ` leahneukirchen
  2022-04-07 16:59 ` [PR PATCH] [Merged]: " leahneukirchen
  0 siblings, 2 replies; 3+ messages in thread
From: mjyut @ 2022-04-07 16:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 725 bytes --]

There is a new pull request by mjyut against master on the void-packages repository

https://github.com/mjyut/void-packages master
https://github.com/void-linux/void-packages/pull/36558

mdocml: fix readability issues in void-man-cgi.
Fix: #36557

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**
  I've confirmed the changes in CSS.
  However, I have not tested it in the same environment as https://man.voidlinux.org/ .

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/36558.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-36558.patch --]
[-- Type: text/x-diff, Size: 2122 bytes --]

From 6bb71ee45271c57047ff412caabf54a313e470f8 Mon Sep 17 00:00:00 2001
From: Mizuno Jan Yuta <mjy@8x9.space>
Date: Fri, 8 Apr 2022 01:05:47 +0900
Subject: [PATCH] mdocml: fix readability issues in void-man-cgi.

Fix: #36557
---
 srcpkgs/mdocml/files/void.css | 37 +++++++++++++++++++++++++----------
 srcpkgs/mdocml/template       |  2 +-
 2 files changed, 28 insertions(+), 11 deletions(-)

diff --git a/srcpkgs/mdocml/files/void.css b/srcpkgs/mdocml/files/void.css
index 289145066991..4e2f75357213 100644
--- a/srcpkgs/mdocml/files/void.css
+++ b/srcpkgs/mdocml/files/void.css
@@ -1,8 +1,24 @@
 
 /** Void style **/
-body { color: #333; }
-a { color: #478061; }
-a:hover { color: #000; }
+html {
+	--fg: #333;
+	--bg: #fff;
+	--fg-accent: #478061;
+	--nav-fg: #fff;
+	--nav-bg: #478061;
+}
+@media (prefers-color-scheme: dark) {
+	html {
+		--fg: #ccc;
+		--bg: #222;
+		--fg-accent: #62b086;
+		--nav-fg: #fff;
+		--nav-bg: #295340;
+	}
+}
+
+a, :link, :visited { color: var(--fg-accent); }
+a:hover { color: var(--fg); }
 
 html { max-width: 100% }
 body { margin: 0 }
@@ -11,29 +27,30 @@ body { margin: 0 }
 nav#void-nav {
 	width:100%;
 	min-height:50px;
-	background:#478061;
+	color:var(--nav-fg);
+	background-color:var(--nav-bg);
 	z-index:110;
 	font-size:14px
 }
 nav#void-nav ul {
-	float:right;
+	display:block;
 	list-style:none;
 	margin:0
 }
 nav#void-nav ul li {
-	float:left;
+	display:inline-block;
 	margin:0;
-	clear:initial
 }
 nav#void-nav ul li a {
-	display:block;
+	display:inline-block;
 	padding:15px;
 	line-height:20px;
 	font-size:1.2em;
-	color:#fff;
+	color:var(--nav-fg);
 	text-decoration: none
 }
 nav#void-nav ul li a:hover,nav#void-nav ul li a:focus {
-	background:#000;
+	color:#fff;
+	background-color:#000;
 	text-decoration:none
 }
diff --git a/srcpkgs/mdocml/template b/srcpkgs/mdocml/template
index 41e07f089ab2..e8aa98cdb158 100644
--- a/srcpkgs/mdocml/template
+++ b/srcpkgs/mdocml/template
@@ -1,7 +1,7 @@
 # Template file for 'mdocml'
 pkgname=mdocml
 version=1.14.6
-revision=1
+revision=2
 wrksrc="mandoc-${version}"
 build_style=configure
 make_build_args="all man.cgi"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: mdocml: fix readability issues in void-man-cgi.
  2022-04-07 16:20 [PR PATCH] mdocml: fix readability issues in void-man-cgi mjyut
@ 2022-04-07 16:44 ` leahneukirchen
  2022-04-07 16:59 ` [PR PATCH] [Merged]: " leahneukirchen
  1 sibling, 0 replies; 3+ messages in thread
From: leahneukirchen @ 2022-04-07 16:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New comment by leahneukirchen on void-packages repository

https://github.com/void-linux/void-packages/pull/36558#issuecomment-1091972104

Comment:
Thanks, LGTM.

I'd replace the `#mandoc` line with
```
.manual-text { max-width: 65em; padding: 0 1em; }
```

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: mdocml: fix readability issues in void-man-cgi.
  2022-04-07 16:20 [PR PATCH] mdocml: fix readability issues in void-man-cgi mjyut
  2022-04-07 16:44 ` leahneukirchen
@ 2022-04-07 16:59 ` leahneukirchen
  1 sibling, 0 replies; 3+ messages in thread
From: leahneukirchen @ 2022-04-07 16:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

There's a merged pull request on the void-packages repository

mdocml: fix readability issues in void-man-cgi.
https://github.com/void-linux/void-packages/pull/36558

Description:
Fix: #36557

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**
  I've confirmed the changes in CSS.
  However, I have not tested it in the same environment as https://man.voidlinux.org/ .

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-04-07 16:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 16:20 [PR PATCH] mdocml: fix readability issues in void-man-cgi mjyut
2022-04-07 16:44 ` leahneukirchen
2022-04-07 16:59 ` [PR PATCH] [Merged]: " leahneukirchen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).