Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] font-ibm-plex-ttf: update to 6.0.0.
@ 2021-12-20 19:28 z-erica
  2021-12-20 19:45 ` ericonr
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: z-erica @ 2021-12-20 19:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

There is a new pull request by z-erica against master on the void-packages repository

https://github.com/z-erica/void-packages master
https://github.com/void-linux/void-packages/pull/34631

font-ibm-plex-ttf: update to 6.0.0.
When there’s a choice between hinted and unhinted variants for a font family, this template chooses the former. This is more or less an arbitrary choice, since I’m unaware of any specific guidelines of this sort. It’s impossible to include both, as the files themselves overlap, and including neither (where applicable) would completely remove support for some languages.

#### Testing the changes
- I tested the changes in this PR: **YES**

A patch file from https://github.com/void-linux/void-packages/pull/34631.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-34631.patch --]
[-- Type: text/x-diff, Size: 1529 bytes --]

From 288c91a02e80d44469feca83da526a77d2c89ffb Mon Sep 17 00:00:00 2001
From: Erica Z <zerica@tilde.team>
Date: Mon, 20 Dec 2021 19:57:16 +0100
Subject: [PATCH] font-ibm-plex-ttf: update to 6.0.0.

---
 srcpkgs/font-ibm-plex-ttf/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/font-ibm-plex-ttf/template b/srcpkgs/font-ibm-plex-ttf/template
index c5226d6761fd..b1717b8831c0 100644
--- a/srcpkgs/font-ibm-plex-ttf/template
+++ b/srcpkgs/font-ibm-plex-ttf/template
@@ -1,6 +1,6 @@
 # Template file for 'font-ibm-plex-ttf'
 pkgname=font-ibm-plex-ttf
-version=5.2.1
+version=6.0.0
 revision=1
 wrksrc="plex-${version}"
 depends="font-util"
@@ -9,13 +9,14 @@ maintainer="Felipe Nogueira <contato.fnog@gmail.com>"
 license="OFL-1.1"
 homepage="https://github.com/IBM/plex"
 distfiles="https://github.com/IBM/plex/archive/v${version}.tar.gz"
-checksum=6b43a97a116a4beba474b9a9c646fb6ded8ba255fa8d3b252e669f67cbeb9d7f
+checksum=e78cc68cb40ccca0318facade727a0deb32f73e931a2e31bb2fcaf8a6d386dff
 
 font_dirs="/usr/share/fonts/TTF"
 
 do_install() {
 	vmkdir usr/share/fonts/TTF
 	vcopy "IBM-Plex-*/fonts/complete/ttf/*.ttf" usr/share/fonts/TTF
+	vcopy "IBM-Plex-*/fonts/complete/ttf/hinted/*.ttf" usr/share/fonts/TTF
 }
 
 font-ibm-plex-otf_package() {
@@ -25,5 +26,6 @@ font-ibm-plex-otf_package() {
 	pkg_install() {
 		vmkdir usr/share/fonts/OTF
 		vcopy "IBM-Plex-*/fonts/complete/otf/*.otf" usr/share/fonts/OTF
+		vcopy "IBM-Plex-*/fonts/complete/otf/hinted/*.otf" usr/share/fonts/OTF
 	}
 }

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: font-ibm-plex-ttf: update to 6.0.0.
  2021-12-20 19:28 [PR PATCH] font-ibm-plex-ttf: update to 6.0.0 z-erica
@ 2021-12-20 19:45 ` ericonr
  2021-12-20 20:04 ` [PR PATCH] [Updated] " z-erica
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-12-20 19:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/34631#issuecomment-998219656

Comment:
Do you have any thoughts about https://github.com/void-linux/void-packages/pull/33351 ? Not sure how best to deal with it.

I think preferring hinted is ok, but please document the choice in the commit message. Copying the PR comment should be enough.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] font-ibm-plex-ttf: update to 6.0.0.
  2021-12-20 19:28 [PR PATCH] font-ibm-plex-ttf: update to 6.0.0 z-erica
  2021-12-20 19:45 ` ericonr
@ 2021-12-20 20:04 ` z-erica
  2021-12-20 20:04 ` z-erica
  2022-04-07 17:18 ` [PR PATCH] [Merged]: " leahneukirchen
  3 siblings, 0 replies; 5+ messages in thread
From: z-erica @ 2021-12-20 20:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 773 bytes --]

There is an updated pull request by z-erica against master on the void-packages repository

https://github.com/z-erica/void-packages master
https://github.com/void-linux/void-packages/pull/34631

font-ibm-plex-ttf: update to 6.0.0.
When there’s a choice between hinted and unhinted variants for a font family, this template chooses the former. This is more or less an arbitrary choice, since I’m unaware of any specific guidelines of this sort. It’s impossible to include both, as the files themselves overlap, and including neither (where applicable) would completely remove support for some languages.

#### Testing the changes
- I tested the changes in this PR: **YES**

A patch file from https://github.com/void-linux/void-packages/pull/34631.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-34631.patch --]
[-- Type: text/x-diff, Size: 1997 bytes --]

From 984dbe5bdfe0e309e722f9eaa8f75162c0b8dba5 Mon Sep 17 00:00:00 2001
From: Erica Z <zerica@tilde.team>
Date: Mon, 20 Dec 2021 19:57:16 +0100
Subject: [PATCH] font-ibm-plex-ttf: update to 6.0.0.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

When there’s a choice between hinted and unhinted variants for a font
family, this template chooses the former. This is more or less an
arbitrary choice, since I’m unaware of any specific guidelines of this
sort. It’s impossible to include both, as the files themselves overlap,
and including neither (where applicable) would completely remove support
for some languages.
---
 srcpkgs/font-ibm-plex-ttf/template | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/font-ibm-plex-ttf/template b/srcpkgs/font-ibm-plex-ttf/template
index c5226d6761fd..b1717b8831c0 100644
--- a/srcpkgs/font-ibm-plex-ttf/template
+++ b/srcpkgs/font-ibm-plex-ttf/template
@@ -1,6 +1,6 @@
 # Template file for 'font-ibm-plex-ttf'
 pkgname=font-ibm-plex-ttf
-version=5.2.1
+version=6.0.0
 revision=1
 wrksrc="plex-${version}"
 depends="font-util"
@@ -9,13 +9,14 @@ maintainer="Felipe Nogueira <contato.fnog@gmail.com>"
 license="OFL-1.1"
 homepage="https://github.com/IBM/plex"
 distfiles="https://github.com/IBM/plex/archive/v${version}.tar.gz"
-checksum=6b43a97a116a4beba474b9a9c646fb6ded8ba255fa8d3b252e669f67cbeb9d7f
+checksum=e78cc68cb40ccca0318facade727a0deb32f73e931a2e31bb2fcaf8a6d386dff
 
 font_dirs="/usr/share/fonts/TTF"
 
 do_install() {
 	vmkdir usr/share/fonts/TTF
 	vcopy "IBM-Plex-*/fonts/complete/ttf/*.ttf" usr/share/fonts/TTF
+	vcopy "IBM-Plex-*/fonts/complete/ttf/hinted/*.ttf" usr/share/fonts/TTF
 }
 
 font-ibm-plex-otf_package() {
@@ -25,5 +26,6 @@ font-ibm-plex-otf_package() {
 	pkg_install() {
 		vmkdir usr/share/fonts/OTF
 		vcopy "IBM-Plex-*/fonts/complete/otf/*.otf" usr/share/fonts/OTF
+		vcopy "IBM-Plex-*/fonts/complete/otf/hinted/*.otf" usr/share/fonts/OTF
 	}
 }

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: font-ibm-plex-ttf: update to 6.0.0.
  2021-12-20 19:28 [PR PATCH] font-ibm-plex-ttf: update to 6.0.0 z-erica
  2021-12-20 19:45 ` ericonr
  2021-12-20 20:04 ` [PR PATCH] [Updated] " z-erica
@ 2021-12-20 20:04 ` z-erica
  2022-04-07 17:18 ` [PR PATCH] [Merged]: " leahneukirchen
  3 siblings, 0 replies; 5+ messages in thread
From: z-erica @ 2021-12-20 20:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

New comment by z-erica on void-packages repository

https://github.com/void-linux/void-packages/pull/34631#issuecomment-998231258

Comment:
About #33351, I primarily use IBM Plex Sans as a system font, so the naming of the intermediate weight variants doesn’t personally cause me any issues.

Firefox seems to apply the correct variant for each numerical CSS weight without any extra configuration, so it might be good enough to go. Either way, if there are issues, it could be possible to include some mappings in `/etc/fonts/conf.d`.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: font-ibm-plex-ttf: update to 6.0.0.
  2021-12-20 19:28 [PR PATCH] font-ibm-plex-ttf: update to 6.0.0 z-erica
                   ` (2 preceding siblings ...)
  2021-12-20 20:04 ` z-erica
@ 2022-04-07 17:18 ` leahneukirchen
  3 siblings, 0 replies; 5+ messages in thread
From: leahneukirchen @ 2022-04-07 17:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

There's a merged pull request on the void-packages repository

font-ibm-plex-ttf: update to 6.0.0.
https://github.com/void-linux/void-packages/pull/34631

Description:
When there’s a choice between hinted and unhinted variants for a font family, this template chooses the former. This is more or less an arbitrary choice, since I’m unaware of any specific guidelines of this sort. It’s impossible to include both, as the files themselves overlap, and including neither (where applicable) would completely remove support for some languages.

#### Testing the changes
- I tested the changes in this PR: **YES**

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-04-07 17:18 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-20 19:28 [PR PATCH] font-ibm-plex-ttf: update to 6.0.0 z-erica
2021-12-20 19:45 ` ericonr
2021-12-20 20:04 ` [PR PATCH] [Updated] " z-erica
2021-12-20 20:04 ` z-erica
2022-04-07 17:18 ` [PR PATCH] [Merged]: " leahneukirchen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).