Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] revive: update to 1.2.0.
@ 2022-04-03 16:06 4ricci
  2022-04-07 23:10 ` [PR PATCH] [Updated] " 4ricci
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: 4ricci @ 2022-04-03 16:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]

There is a new pull request by 4ricci against master on the void-packages repository

https://github.com/4ricci/void-packages revive
https://github.com/void-linux/void-packages/pull/36505

revive: update to 1.2.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36505.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-revive-36505.patch --]
[-- Type: text/x-diff, Size: 1131 bytes --]

From b3f4e5d51e6db9021e508b2b7912369711c5da80 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Sun, 3 Apr 2022 17:07:41 +0200
Subject: [PATCH] revive: update to 1.2.0.

---
 srcpkgs/revive/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/revive/template b/srcpkgs/revive/template
index 55a011447362..b48789a4abd5 100644
--- a/srcpkgs/revive/template
+++ b/srcpkgs/revive/template
@@ -1,16 +1,16 @@
 # Template file for 'revive'
 pkgname=revive
-version=1.1.4
+version=1.2.0
 revision=1
 build_style=go
-go_ldflags="-X main.version=$version -X main.builtBy=xbps"
+go_ldflags="-X github.com/mgechev/revive/cli.version=$version"
 go_import_path="github.com/mgechev/revive"
 short_desc="Drop-in replacement for golint"
 maintainer="Roberto Ricci <ricci@disroot.org>"
 license="MIT"
 homepage="https://revive.run/"
 distfiles="https://github.com/mgechev/revive/archive/v$version.tar.gz"
-checksum=afe0d11a614d5ca706485b7f6ca1e53b374b45017ea75f14149a4434d3ef74b5
+checksum=877ffa80e8abc57ef5a0627cd671d53edb99df4fc0b88f52e3249206cf59813c
 
 do_check() {
 	go test -v ./...

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] revive: update to 1.2.0.
  2022-04-03 16:06 [PR PATCH] revive: update to 1.2.0 4ricci
@ 2022-04-07 23:10 ` 4ricci
  2022-04-07 23:28 ` 4ricci
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: 4ricci @ 2022-04-07 23:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]

There is an updated pull request by 4ricci against master on the void-packages repository

https://github.com/4ricci/void-packages revive
https://github.com/void-linux/void-packages/pull/36505

revive: update to 1.2.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36505.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-revive-36505.patch --]
[-- Type: text/x-diff, Size: 1131 bytes --]

From 7f8050d7b42f82e4487e7e308effa7c7485ae726 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Fri, 8 Apr 2022 01:03:06 +0200
Subject: [PATCH] revive: update to 1.2.1.

---
 srcpkgs/revive/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/revive/template b/srcpkgs/revive/template
index 55a011447362..38f2018570e8 100644
--- a/srcpkgs/revive/template
+++ b/srcpkgs/revive/template
@@ -1,16 +1,16 @@
 # Template file for 'revive'
 pkgname=revive
-version=1.1.4
+version=1.2.1
 revision=1
 build_style=go
-go_ldflags="-X main.version=$version -X main.builtBy=xbps"
+go_ldflags="-X github.com/mgechev/revive/cli.version=$version"
 go_import_path="github.com/mgechev/revive"
 short_desc="Drop-in replacement for golint"
 maintainer="Roberto Ricci <ricci@disroot.org>"
 license="MIT"
 homepage="https://revive.run/"
 distfiles="https://github.com/mgechev/revive/archive/v$version.tar.gz"
-checksum=afe0d11a614d5ca706485b7f6ca1e53b374b45017ea75f14149a4434d3ef74b5
+checksum=47e9f371e934fe4dfce44098fd54a0aaeaa47079184a14ad263990a24fab1b35
 
 do_check() {
 	go test -v ./...

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] revive: update to 1.2.0.
  2022-04-03 16:06 [PR PATCH] revive: update to 1.2.0 4ricci
  2022-04-07 23:10 ` [PR PATCH] [Updated] " 4ricci
@ 2022-04-07 23:28 ` 4ricci
  2022-04-10  9:26 ` [PR REVIEW] " paper42
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: 4ricci @ 2022-04-07 23:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]

There is an updated pull request by 4ricci against master on the void-packages repository

https://github.com/4ricci/void-packages revive
https://github.com/void-linux/void-packages/pull/36505

revive: update to 1.2.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36505.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-revive-36505.patch --]
[-- Type: text/x-diff, Size: 1131 bytes --]

From f79f3bf720d2baa11f414463321550135d4387c4 Mon Sep 17 00:00:00 2001
From: Roberto Ricci <ricci@disroot.org>
Date: Fri, 8 Apr 2022 01:03:06 +0200
Subject: [PATCH] revive: update to 1.2.1.

---
 srcpkgs/revive/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/revive/template b/srcpkgs/revive/template
index 55a011447362..38f2018570e8 100644
--- a/srcpkgs/revive/template
+++ b/srcpkgs/revive/template
@@ -1,16 +1,16 @@
 # Template file for 'revive'
 pkgname=revive
-version=1.1.4
+version=1.2.1
 revision=1
 build_style=go
-go_ldflags="-X main.version=$version -X main.builtBy=xbps"
+go_ldflags="-X github.com/mgechev/revive/cli.version=$version"
 go_import_path="github.com/mgechev/revive"
 short_desc="Drop-in replacement for golint"
 maintainer="Roberto Ricci <ricci@disroot.org>"
 license="MIT"
 homepage="https://revive.run/"
 distfiles="https://github.com/mgechev/revive/archive/v$version.tar.gz"
-checksum=afe0d11a614d5ca706485b7f6ca1e53b374b45017ea75f14149a4434d3ef74b5
+checksum=47e9f371e934fe4dfce44098fd54a0aaeaa47079184a14ad263990a24fab1b35
 
 do_check() {
 	go test -v ./...

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] revive: update to 1.2.0.
  2022-04-03 16:06 [PR PATCH] revive: update to 1.2.0 4ricci
  2022-04-07 23:10 ` [PR PATCH] [Updated] " 4ricci
  2022-04-07 23:28 ` 4ricci
@ 2022-04-10  9:26 ` paper42
  2022-04-10  9:40 ` 4ricci
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2022-04-10  9:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36505#discussion_r846747621

Comment:
```suggestion
go_ldflags="-X cli.version=$version"
```
would this work?

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] revive: update to 1.2.0.
  2022-04-03 16:06 [PR PATCH] revive: update to 1.2.0 4ricci
                   ` (2 preceding siblings ...)
  2022-04-10  9:26 ` [PR REVIEW] " paper42
@ 2022-04-10  9:40 ` 4ricci
  2022-04-10  9:41 ` 4ricci
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: 4ricci @ 2022-04-10  9:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

New review comment by 4ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/36505#discussion_r846749547

Comment:
Yes, mgechev/revive@d2ab719a0ee3513500eb36460b2d49a90bbbd6c1.
I also removed `builtBy` because it's unused unless built time is also set <https://github.com/mgechev/revive/blob/31fbdb18332df7d1db76f8223e5dfb0285cd46aa/cli/main.go#L151>.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] revive: update to 1.2.0.
  2022-04-03 16:06 [PR PATCH] revive: update to 1.2.0 4ricci
                   ` (3 preceding siblings ...)
  2022-04-10  9:40 ` 4ricci
@ 2022-04-10  9:41 ` 4ricci
  2022-04-10  9:47 ` 4ricci
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: 4ricci @ 2022-04-10  9:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

New review comment by 4ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/36505#discussion_r846749547

Comment:
Yes, mgechev/revive@d2ab719a0ee3513500eb36460b2d49a90bbbd6c1.
I also removed `builtBy` because it's unused unless build time is also set <https://github.com/mgechev/revive/blob/31fbdb18332df7d1db76f8223e5dfb0285cd46aa/cli/main.go#L151>.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] revive: update to 1.2.0.
  2022-04-03 16:06 [PR PATCH] revive: update to 1.2.0 4ricci
                   ` (4 preceding siblings ...)
  2022-04-10  9:41 ` 4ricci
@ 2022-04-10  9:47 ` 4ricci
  2022-04-10  9:53 ` 4ricci
  2022-04-10 13:33 ` [PR PATCH] [Merged]: " paper42
  7 siblings, 0 replies; 9+ messages in thread
From: 4ricci @ 2022-04-10  9:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New review comment by 4ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/36505#discussion_r846750616

Comment:
Sorry, I misread your comment. I don't know if the suggestion would work, I have to test.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] revive: update to 1.2.0.
  2022-04-03 16:06 [PR PATCH] revive: update to 1.2.0 4ricci
                   ` (5 preceding siblings ...)
  2022-04-10  9:47 ` 4ricci
@ 2022-04-10  9:53 ` 4ricci
  2022-04-10 13:33 ` [PR PATCH] [Merged]: " paper42
  7 siblings, 0 replies; 9+ messages in thread
From: 4ricci @ 2022-04-10  9:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 191 bytes --]

New review comment by 4ricci on void-packages repository

https://github.com/void-linux/void-packages/pull/36505#discussion_r846751478

Comment:
It doesn't work, it prints `version (devel)`.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Merged]: revive: update to 1.2.0.
  2022-04-03 16:06 [PR PATCH] revive: update to 1.2.0 4ricci
                   ` (6 preceding siblings ...)
  2022-04-10  9:53 ` 4ricci
@ 2022-04-10 13:33 ` paper42
  7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2022-04-10 13:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

There's a merged pull request on the void-packages repository

revive: update to 1.2.0.
https://github.com/void-linux/void-packages/pull/36505

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-04-10 13:33 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-03 16:06 [PR PATCH] revive: update to 1.2.0 4ricci
2022-04-07 23:10 ` [PR PATCH] [Updated] " 4ricci
2022-04-07 23:28 ` 4ricci
2022-04-10  9:26 ` [PR REVIEW] " paper42
2022-04-10  9:40 ` 4ricci
2022-04-10  9:41 ` 4ricci
2022-04-10  9:47 ` 4ricci
2022-04-10  9:53 ` 4ricci
2022-04-10 13:33 ` [PR PATCH] [Merged]: " paper42

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).