Github messages for voidlinux
 help / color / mirror / Atom feed
From: basploeger <basploeger@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: apcupsd-3.14.14
Date: Tue, 12 Apr 2022 21:47:52 +0200	[thread overview]
Message-ID: <20220412194752.35Dpz0LvAXM5AcElMh9AvOR9xPTi5pT2cEooWLGauSU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36654@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

New review comment by basploeger on void-packages repository

https://github.com/void-linux/void-packages/pull/36654#discussion_r848806371

Comment:
Yes. I tried both omitting the `=` and replacing them by `=''`, but then the args end up with non-empty values. And they need to be empty.

  parent reply	other threads:[~2022-04-12 19:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12  7:27 [PR PATCH] " basploeger
2022-04-12  7:34 ` [PR PATCH] [Updated] " basploeger
2022-04-12 18:13 ` [PR REVIEW] " classabbyamp
2022-04-12 18:13 ` classabbyamp
2022-04-12 19:33 ` [PR PATCH] [Updated] " basploeger
2022-04-12 19:40 ` [PR REVIEW] " basploeger
2022-04-12 19:40 ` basploeger
2022-04-12 19:42 ` basploeger
2022-04-12 19:47 ` basploeger [this message]
2022-04-12 20:02 ` [PR PATCH] [Updated] " basploeger
2022-04-12 20:03 ` basploeger
2022-04-12 20:08 ` basploeger
2022-04-29 16:54 ` basploeger
2022-04-29 17:06 ` [PR REVIEW] " classabbyamp
2022-04-29 19:48 ` basploeger
2022-04-29 19:48 ` basploeger
2022-05-04 18:51 ` basploeger
2022-05-05  0:03 ` classabbyamp
2022-05-05 20:11 ` [PR PATCH] [Merged]: " abenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220412194752.35Dpz0LvAXM5AcElMh9AvOR9xPTi5pT2cEooWLGauSU@z \
    --to=basploeger@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).