From: basploeger <basploeger@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: apcupsd-3.14.14
Date: Fri, 29 Apr 2022 21:48:21 +0200 [thread overview]
Message-ID: <20220429194821.4LrVYAd15lYhzPeLFBWRZYoiv2GBVYXlw4Xl0ARj6kg@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36654@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]
New review comment by basploeger on void-packages repository
https://github.com/void-linux/void-packages/pull/36654#discussion_r862099852
Comment:
This line is needed to work around a problem in the package's configure/make setup. If I omit it, then `./xbps-src install apcupsd` fails with:
```
COPY apcupsd => /destdir//apcupsd-3.14.14/usr/bin/apcupsd
/usr/bin/install: target '/destdir//apcupsd-3.14.14/usr/bin/apcupsd' is not a directory
make[2]: *** [Makefile:49: install-base] Error 1
make[1]: *** [../autoconf/targets.mak:69: install] Error 2
make: *** [autoconf/targets.mak:111: src_DIR] Error 2
=> ERROR: apcupsd-3.14.14_1: do_install: '${make_cmd} DESTDIR=${DESTDIR} ${make_install_args} ${make_install_target}' exited with 2
=> ERROR: in do_install() at common/build-style/gnu-configure.sh:40
```
The problem is that the `install` command that `make` is executing, gets an argument `strip` rather than `--strip` (I am not sure why, but this seems an error in the configure/make files). This wrong argument means `install` tries to copy files `strip` and `apcupsd` into a _directory_ `/usr/bin/apcupsd`, which is not the intention. The intention is to copy file `apcupsd` to file `/usr/bin/apcupsd`.
The only way I found to work around this error, is by clearing the env var `STRIP`, which ensures the `strip` argument is not passed to `install`.
next prev parent reply other threads:[~2022-04-29 19:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 7:27 [PR PATCH] " basploeger
2022-04-12 7:34 ` [PR PATCH] [Updated] " basploeger
2022-04-12 18:13 ` [PR REVIEW] " classabbyamp
2022-04-12 18:13 ` classabbyamp
2022-04-12 19:33 ` [PR PATCH] [Updated] " basploeger
2022-04-12 19:40 ` [PR REVIEW] " basploeger
2022-04-12 19:40 ` basploeger
2022-04-12 19:42 ` basploeger
2022-04-12 19:47 ` basploeger
2022-04-12 20:02 ` [PR PATCH] [Updated] " basploeger
2022-04-12 20:03 ` basploeger
2022-04-12 20:08 ` basploeger
2022-04-29 16:54 ` basploeger
2022-04-29 17:06 ` [PR REVIEW] " classabbyamp
2022-04-29 19:48 ` basploeger [this message]
2022-04-29 19:48 ` basploeger
2022-05-04 18:51 ` basploeger
2022-05-05 0:03 ` classabbyamp
2022-05-05 20:11 ` [PR PATCH] [Merged]: " abenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220429194821.4LrVYAd15lYhzPeLFBWRZYoiv2GBVYXlw4Xl0ARj6kg@z \
--to=basploeger@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).