From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: mongoose: improve template and patches
Date: Wed, 13 Apr 2022 16:48:27 +0200 [thread overview]
Message-ID: <20220413144827.OLyGGAuMJiGMf1xU7j6Ny32wX66jni3ZUMmagaJpA4s@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36561@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/36561#issuecomment-1098145229
Comment:
The place for the Makefile patch to do the right thing when packing is disabled is upstream, not here. They should also fix the Makefile to build everything required to make the library work in the default build configuration. It would also help if they move the `pack` source out of a `test` directory so it's more obvious that it's intended as a key component of the library.
That the "packed" version of the library *requires* the client application to expose symbols that are defined by the `pack` executable is a terrible design decision that very tightly couples the library to the design of the application. As you note, this screams for direct integration of the library source code into the client source tree.
Why are we even packaging this?
next prev parent reply other threads:[~2022-04-13 14:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 18:18 [PR PATCH] mongoose: improve patches subnut
2022-04-07 18:41 ` subnut
2022-04-07 18:42 ` subnut
2022-04-07 18:56 ` [PR PATCH] [Updated] " subnut
2022-04-07 19:13 ` [PR PATCH] [Updated] mongoose: add missing binary subnut
2022-04-07 19:16 ` [PR PATCH] [Updated] mongoose: fix missing functionality subnut
2022-04-09 11:53 ` subnut
2022-04-10 6:56 ` subnut
2022-04-10 6:56 ` subnut
2022-04-10 18:26 ` subnut
2022-04-10 18:28 ` subnut
2022-04-10 18:29 ` subnut
2022-04-13 13:41 ` mongoose: improve template and patches ahesford
2022-04-13 14:13 ` subnut
2022-04-13 14:13 ` subnut
2022-04-13 14:15 ` subnut
2022-04-13 14:17 ` subnut
2022-04-13 14:21 ` subnut
2022-04-13 14:24 ` subnut
2022-04-13 14:48 ` ahesford [this message]
2022-04-13 15:07 ` subnut
2022-04-13 15:07 ` [PR PATCH] [Closed]: " subnut
2022-04-13 15:07 ` subnut
2022-04-16 13:30 ` subnut
2022-04-16 13:32 ` [PR PATCH] [Updated] " subnut
2022-04-16 14:47 ` ahesford
2022-04-17 17:21 ` [PR PATCH] [Updated] " subnut
2022-04-17 17:34 ` subnut
2022-07-17 2:14 ` github-actions
2022-08-01 2:14 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220413144827.OLyGGAuMJiGMf1xU7j6Ny32wX66jni3ZUMmagaJpA4s@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).