Github messages for voidlinux
 help / color / mirror / Atom feed
From: subnut <subnut@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] mongoose: improve patches
Date: Thu, 07 Apr 2022 20:18:06 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36561@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

There is a new pull request by subnut against master on the void-packages repository

https://github.com/subnut/void-packages mongoose
https://github.com/void-linux/void-packages/pull/36561

mongoose: improve patches
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
<!-- 
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/36561.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mongoose-36561.patch --]
[-- Type: text/x-diff, Size: 2896 bytes --]

From 92cabc0a7cc56180141792758ee4354eb91ffa65 Mon Sep 17 00:00:00 2001
From: Subhaditya Nath <sn03.general@gmail.com>
Date: Thu, 7 Apr 2022 23:43:02 +0530
Subject: [PATCH] mongoose: improve patches

---
 srcpkgs/mongoose/patches/fix-makefile.patch |  9 +++++++--
 srcpkgs/mongoose/patches/fix-tests.patch    | 21 ++++++++++++++++++---
 srcpkgs/mongoose/template                   |  2 +-
 3 files changed, 26 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/mongoose/patches/fix-makefile.patch b/srcpkgs/mongoose/patches/fix-makefile.patch
index d829ea8adc8c..eb3e7e2fc546 100644
--- a/srcpkgs/mongoose/patches/fix-makefile.patch
+++ b/srcpkgs/mongoose/patches/fix-makefile.patch
@@ -1,10 +1,15 @@
 --- a/Makefile
 +++ b/Makefile
-@@ -5,5 +5,5 @@ SRCS = mongoose.c test/unit_test.c test/packed_fs.c
+@@ -1,9 +1,9 @@
+-SRCS = mongoose.c test/unit_test.c test/packed_fs.c
++SRCS = mongoose.c test/unit_test.c
+ HDRS = $(wildcard src/*.h)
+ DEFS ?= -DMG_MAX_HTTP_HEADERS=7 -DMG_ENABLE_LINES -DMG_ENABLE_PACKED_FS=1
+ WARN ?= -W -Wall -Werror -Wshadow -Wdouble-promotion -fno-common -Wconversion -Wundef
  OPTS ?= -O3 -g3
  INCS ?= -Isrc -I.
 -CFLAGS ?= $(OPTS) $(WARN) $(INCS) $(DEFS) $(TFLAGS) $(EXTRA)
-+CFLAGS := $(OPTS) $(WARN) $(INCS) $(DEFS) $(TFLAGS) $(CFLAGS)
++CFLAGS := $(OPTS) $(WARN) $(INCS) $(CFLAGS)
  SSL ?= MBEDTLS
  CWD ?= $(realpath $(CURDIR))
 @@ -10,6 +10,9 @@ CWD ?= $(realpath $(CURDIR))
diff --git a/srcpkgs/mongoose/patches/fix-tests.patch b/srcpkgs/mongoose/patches/fix-tests.patch
index 8b25527492d5..4e1d4683eef0 100644
--- a/srcpkgs/mongoose/patches/fix-tests.patch
+++ b/srcpkgs/mongoose/patches/fix-tests.patch
@@ -1,8 +1,24 @@
-Skip tests that want to connect to the internet
+Skip broken tests
 
 --- a/test/unit_test.c
 +++ b/test/unit_test.c
-@@ -1680,11 +1562,9 @@ int main(void) {
+@@ -954,7 +954,6 @@ static void test_http_parse(void) {
+     ASSERT(mg_http_parse(s, strlen(s), &req) == (int) strlen(s));
+     ASSERT((v = mg_http_get_header(&req, "e")) != NULL);
+     ASSERT(mg_vcmp(v, "5") == 0);
+-    ASSERT((v = mg_http_get_header(&req, "h")) == NULL);
+   }
+ 
+   {
+@@ -1660,7 +1659,6 @@ int main(void) {
+   test_check_ip_acl();
+   test_udp();
+   test_pipe();
+-  test_packed();
+   test_crc32();
+   test_multipart();
+   test_http_chunked();
+@@ -1680,11 +1678,9 @@ int main(void) {
    test_ws();
    test_ws_fragmentation();
    test_http_server();
@@ -14,4 +30,3 @@ Skip tests that want to connect to the internet
    printf("SUCCESS. Total tests: %d\n", s_num_tests);
    return EXIT_SUCCESS;
  }
-
diff --git a/srcpkgs/mongoose/template b/srcpkgs/mongoose/template
index a81658710d7b..d3cfac982a12 100644
--- a/srcpkgs/mongoose/template
+++ b/srcpkgs/mongoose/template
@@ -1,7 +1,7 @@
 # Template file for 'mongoose'
 pkgname=mongoose
 version=7.6
-revision=1
+revision=2
 build_style=gnu-makefile
 make_use_env=yes
 make_check_target=test

             reply	other threads:[~2022-04-07 18:18 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 18:18 subnut [this message]
2022-04-07 18:41 ` subnut
2022-04-07 18:42 ` subnut
2022-04-07 18:56 ` [PR PATCH] [Updated] " subnut
2022-04-07 19:13 ` [PR PATCH] [Updated] mongoose: add missing binary subnut
2022-04-07 19:16 ` [PR PATCH] [Updated] mongoose: fix missing functionality subnut
2022-04-09 11:53 ` subnut
2022-04-10  6:56 ` subnut
2022-04-10  6:56 ` subnut
2022-04-10 18:26 ` subnut
2022-04-10 18:28 ` subnut
2022-04-10 18:29 ` subnut
2022-04-13 13:41 ` mongoose: improve template and patches ahesford
2022-04-13 14:13 ` subnut
2022-04-13 14:13 ` subnut
2022-04-13 14:15 ` subnut
2022-04-13 14:17 ` subnut
2022-04-13 14:21 ` subnut
2022-04-13 14:24 ` subnut
2022-04-13 14:48 ` ahesford
2022-04-13 15:07 ` [PR PATCH] [Closed]: " subnut
2022-04-13 15:07 ` subnut
2022-04-13 15:07 ` subnut
2022-04-16 13:30 ` subnut
2022-04-16 13:32 ` [PR PATCH] [Updated] " subnut
2022-04-16 14:47 ` ahesford
2022-04-17 17:21 ` [PR PATCH] [Updated] " subnut
2022-04-17 17:34 ` subnut
2022-07-17  2:14 ` github-actions
2022-08-01  2:14 ` [PR PATCH] [Closed]: " github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36561@inbox.vuxu.org \
    --to=subnut@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).