From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [RFC] Stale issues/pulls action
Date: Fri, 15 Apr 2022 01:44:49 +0200 [thread overview]
Message-ID: <20220414234449.c1-LACL59A6NnwWGJ81z59poCJsHAuRBWYVNJZiqvyE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36657@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/issues/36657#issuecomment-1099723238
Comment:
> Also there seems is another issue with the action - it doesn't count PR review comments as updates for the action, example https://github.com/void-linux/void-packages/pull/34884. That PR got marked Stale, received a review, and the next day the action saw the changes, but didn't count them as comments and left the Stale label. Thus it seems, only real comments are counted.
this looks like a bug to me. The github API shows it was updated after the stale label was added (it's the time paper added their review comments):
```
$ gh pr view --json updatedAt 34884
{
"updatedAt": "2022-04-10T11:45:44Z"
}
```
next prev parent reply other threads:[~2022-04-14 23:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 13:30 [ISSUE] " dmarto
2022-04-14 23:44 ` classabbyamp [this message]
2022-04-15 0:13 ` dmarto
2022-04-15 0:19 ` dmarto
2022-04-15 0:20 ` dmarto
2022-04-15 0:21 ` dmarto
2022-04-15 0:23 ` dmarto
2022-04-15 6:43 ` 0x5c
2022-04-15 6:50 ` 0x5c
2022-04-15 8:05 ` 0x5c
2022-04-15 11:05 ` dmarto
2022-04-15 21:17 ` 0x5c
2022-06-20 23:22 ` dmarto
2022-06-20 23:45 ` 0x5c
2022-09-19 2:14 ` github-actions
2022-10-04 2:14 ` [ISSUE] [CLOSED] " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220414234449.c1-LACL59A6NnwWGJ81z59poCJsHAuRBWYVNJZiqvyE@z \
--to=classabbyamp@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).