Re: [RFC] Stale issues/pulls action

[dmarto <dmarto@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 3753 bytes --]

New comment by dmarto on void-packages repository

https://github.com/void-linux/void-packages/issues/36657#issuecomment-1099734310

Comment:
indeed, but here is what the action tell us (on runs after the marking)

```
[#34884] Pull request #34884
  [#34884] Found this pull request last updated at: 2022-04-10T11:45:44Z
  [#34884] The option only-labels (​https://github.com/actions/stale#only-labels​) was not specified
  [#34884] └── Continuing the process for this pull request
  [#34884] Days before pull request stale: 90
  [#34884] The pull request is not closed nor locked. Trying to remove the close label...
  [#34884] ├── The close-pr-label (​https://github.com/actions/stale#close-pr-label​) option was not set
  [#34884] └── Skipping the removal of the close label
  [#34884] This pull request has a stale label
  [#34884] The option any-of-labels (​https://github.com/actions/stale#any-of-labels​) was not specified
  [#34884] └── Continuing the process for this pull request
  [#34884] This pull request has no milestone
  [#34884] └── Skip the milestones checks
  [#34884] This pull request has no assignee
  [#34884] └── Skip the assignees checks
  [#34884] This pull request is already stale
  [#34884] Checking for label on this pull request
  [#34884] Pull request marked stale on: 2022-04-10T02:05:37Z
  [#34884] Checking for comments on pull request since: 2022-04-10T02:05:37Z
  [#34884] Comments that are not the stale comment or another bot: 0
  [#34884] Pull request has been commented on: false
  [#34884] Days before pull request close: 14
  [#34884] Pull request has been updated: true
  [#34884] The option remove-stale-when-updated (​https://github.com/actions/stale#remove-stale-when-updated​) is: true
  [#34884] The stale label should not be removed
  [#34884] Stale pull request is not old enough to close yet (hasComments? false, hasUpdate? true)
  [#34884] 1 operation consumed for this pull request
 ```

the important lines are 

```
..
  [#34884] Pull request has been commented on: false
..
  [#34884] Pull request has been updated: true
..
```

fast reference in the source of the action, [_hasCommentsSince](https://github.com/actions/stale/blob/a88f7b30b9de416a7c04936636bb18b49f4ec6a5/src/classes/issues-processor.ts#L731=) -> [listIssueComments](https://github.com/actions/stale/blob/a88f7b30b9de416a7c04936636bb18b49f4ec6a5/src/classes/issues-processor.ts#L519=)

it checks only for comments, and if we check what the API gives us, we can confirm 
```sh
$ gh pr view --json comments 34884
{
  "comments": [
    {
      "author": {
        "login": "ericonr"
      },
      "authorAssociation": "MEMBER",
      "body": "Please mention in the commit that you're switching upstream to the version that has the newest releases.",
      "createdAt": "2022-01-06T04:39:54Z",
      "includesCreatedEdit": false,
      "isMinimized": false,
      "minimizedReason": "",
      "reactionGroups": [
        {
          "content": "THUMBS_UP",
          "users": {
            "totalCount": 1
          }
        }
      ]
    },
    {
      "author": {
        "login": "github-actions"
      },
      "authorAssociation": "NONE",
      "body": "Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.",
      "createdAt": "2022-04-10T02:05:36Z",
      "includesCreatedEdit": false,
      "isMinimized": false,
      "minimizedReason": "",
      "reactionGroups": []
    }
  ]
}
```

so it is not exactly a bug (as in code mistake/error), it just not a feature that the action offers