* [PR PATCH] New package: hut-0.1.0
@ 2022-04-16 3:57 kotajacob
2022-04-16 3:58 ` the-maldridge
` (8 more replies)
0 siblings, 9 replies; 10+ messages in thread
From: kotajacob @ 2022-04-16 3:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]
There is a new pull request by kotajacob against master on the void-packages repository
https://github.com/kotajacob/void-packages hub
https://github.com/void-linux/void-packages/pull/36716
New package: hut-0.1.0
This is the official command line client for https://sourcehut.org/
It's basically the sourcehut equivalent to Github's hub or gh tools.
It's been in development for a while now, but they've put out their
first release earlier this month. I've been using it happily for a while
before this release.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/36716.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hub-36716.patch --]
[-- Type: text/x-diff, Size: 1631 bytes --]
From 3629f84375d9847f4754d4c9b02d3188b051c9d2 Mon Sep 17 00:00:00 2001
From: Dakota Walsh <kota@nilsu.org>
Date: Sat, 16 Apr 2022 15:52:54 +1200
Subject: [PATCH] New package: hut-0.1.0
This is the official command line client for https://sourcehut.org/
It's basically the sourcehut equivalent to Github's hub or gh tools.
It's been in development for a while now, but they've put out their
first release earlier this month. I've been using it happily for a while
before this release.
---
srcpkgs/hut/template | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
create mode 100644 srcpkgs/hut/template
diff --git a/srcpkgs/hut/template b/srcpkgs/hut/template
new file mode 100644
index 000000000000..25f1d9bdd2d1
--- /dev/null
+++ b/srcpkgs/hut/template
@@ -0,0 +1,30 @@
+# Template file for 'hut'
+pkgname=hut
+version=0.1.0
+revision=1
+wrksrc="${pkgname}-v${version}"
+build_style=go
+go_import_path="git.sr.ht/~emersion/hut"
+hostmakedepends="scdoc"
+short_desc="CLI tool for sr.ht"
+maintainer="Dakota Walsh <kota@nilsu.org>"
+license="AGPL-3.0-only"
+homepage="https://git.sr.ht/~emersion/hut"
+changelog="https://git.sr.ht/~emersion/hut/log"
+distfiles="https://git.sr.ht/~emersion/hut/archive/v${version}.tar.gz"
+checksum=5af8f1111f9ec1da9a818978eb1f013dfd50ad4311c79d95b0e62ad428ac1c59
+
+post_install() {
+ $GOPATH/bin/hut completion bash >hut.bash
+ $GOPATH/bin/hut completion zsh >hut.zsh
+ $GOPATH/bin/hut completion fish >hut.fish
+
+ vcompletion hut.bash bash
+ vcompletion hut.zsh zsh
+ vcompletion hut.fish fish
+
+ vlicense LICENSE
+
+ scdoc < doc/hut.1.scd > doc/hut.1
+ vman doc/hut.1
+}
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: New package: hut-0.1.0
2022-04-16 3:57 [PR PATCH] New package: hut-0.1.0 kotajacob
@ 2022-04-16 3:58 ` the-maldridge
2022-04-16 4:04 ` [PR REVIEW] " classabbyamp
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: the-maldridge @ 2022-04-16 3:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 166 bytes --]
New comment by the-maldridge on void-packages repository
https://github.com/void-linux/void-packages/pull/36716#issuecomment-1100558296
Comment:
Supercedes #36715
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] New package: hut-0.1.0
2022-04-16 3:57 [PR PATCH] New package: hut-0.1.0 kotajacob
2022-04-16 3:58 ` the-maldridge
@ 2022-04-16 4:04 ` classabbyamp
2022-04-16 4:29 ` kotajacob
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2022-04-16 4:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 318 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/36716#discussion_r851582223
Comment:
this could be wrapped in a loop:
````sh
for $shell in bash zsh fish; do
$GOPATH/bin/hut completion $shell > hut.$shell
vcompletion hut.$shell $shell
done
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] New package: hut-0.1.0
2022-04-16 3:57 [PR PATCH] New package: hut-0.1.0 kotajacob
2022-04-16 3:58 ` the-maldridge
2022-04-16 4:04 ` [PR REVIEW] " classabbyamp
@ 2022-04-16 4:29 ` kotajacob
2022-04-16 22:43 ` kotajacob
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: kotajacob @ 2022-04-16 4:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 203 bytes --]
New review comment by kotajacob on void-packages repository
https://github.com/void-linux/void-packages/pull/36716#discussion_r851584184
Comment:
Will fix this and the crossbuild issues later tonight.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: New package: hut-0.1.0
2022-04-16 3:57 [PR PATCH] New package: hut-0.1.0 kotajacob
` (2 preceding siblings ...)
2022-04-16 4:29 ` kotajacob
@ 2022-04-16 22:43 ` kotajacob
2022-04-16 23:33 ` [PR REVIEW] " classabbyamp
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: kotajacob @ 2022-04-16 22:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 2013 bytes --]
New comment by kotajacob on void-packages repository
https://github.com/void-linux/void-packages/pull/36716#issuecomment-1100765735
Comment:
The thing causing the build to fail on arm is generating shell completions. The `hut` package doesn't ship with completion scripts; you're meant to run `hut completion bash > hut.bash` to generate the script. There are two issues with this:
1. It seems like you need to set `build_helper=qemu` and run `hut` with `vtargetrun` in the post install stage rather than trying to run hut itself normally. Otherwise I don't think crosscompiles will work.
2. On arm (or maybe just crossbuilds in general) it seems like the binary for hut is not located in `$GOPATH/bin/hut` after compiling, but instead in `$GOPATH/bin/linux_arm64/hut`.
Number 1 seems to work fine with `vtargetrun`, but for number 2 I'm not sure the best way to handle this. I was thinking I could do something like `hutbin=$(find $GOPATH/bin -type f)` to get the `hut` binary path, but that throws a weird error message:
```
=> hut-0.1.0_1: running pre-install hook: 98-fixup-gir-path ...
ln: /destdir/aarch64-linux-gnu/hut-0.1.0/usr/aarch64-linux-gnu/usr/..: cannot overwrite directory
=> ERROR: hut-0.1.0_1: pre-install_98-fixup-gir-path: 'ln -sf ".." "${PKGDESTDIR}/usr/${XBPS_CROSS_TRIPLET}/usr"' exited with 1
=> ERROR: in hook() at common/hooks/pre-install/98-fixup-gir-path.sh:9
=> ERROR: in run_func() at common/xbps-src/shutils/common.sh:21
=> ERROR: in run_pkg_hooks() at common/xbps-src/shutils/common.sh:245
=> ERROR: in run_step() at common/xbps-src/shutils/common.sh:43
=> ERROR: in main() at common/xbps-src/libexec/xbps-src-doinstall.sh:37
```
Another option would be a switch statement for the arm architectures, but both of these seem hacky and not ideal. Maybe there's a simple environment variable that points to the binary you just installed or something? Will look into this further when I get some more time. Just wanted to update with the current progress.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR REVIEW] New package: hut-0.1.0
2022-04-16 3:57 [PR PATCH] New package: hut-0.1.0 kotajacob
` (3 preceding siblings ...)
2022-04-16 22:43 ` kotajacob
@ 2022-04-16 23:33 ` classabbyamp
2022-04-16 23:37 ` classabbyamp
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2022-04-16 23:33 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 317 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/36716#discussion_r851582223
Comment:
this could be wrapped in a loop:
````sh
for shell in bash zsh fish; do
$GOPATH/bin/hut completion $shell > hut.$shell
vcompletion hut.$shell $shell
done
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: New package: hut-0.1.0
2022-04-16 3:57 [PR PATCH] New package: hut-0.1.0 kotajacob
` (4 preceding siblings ...)
2022-04-16 23:33 ` [PR REVIEW] " classabbyamp
@ 2022-04-16 23:37 ` classabbyamp
2022-04-17 1:02 ` [PR PATCH] [Updated] " kotajacob
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2022-04-16 23:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/36716#issuecomment-1100770941
Comment:
I was able to get it to work with `hut=$(find $GOPATH/bin -name hut)` and `vtargetrun`
```diff
diff --git a/srcpkgs/hut/template b/srcpkgs/hut/template
index 25f1d9bdd2..f1448fcf1f 100644
--- a/srcpkgs/hut/template
+++ b/srcpkgs/hut/template
@@ -4,6 +4,7 @@ version=0.1.0
revision=1
wrksrc="${pkgname}-v${version}"
build_style=go
+build_helper=qemu
go_import_path="git.sr.ht/~emersion/hut"
hostmakedepends="scdoc"
short_desc="CLI tool for sr.ht"
@@ -15,13 +16,11 @@ distfiles="https://git.sr.ht/~emersion/hut/archive/v${version}.tar.gz"
checksum=5af8f1111f9ec1da9a818978eb1f013dfd50ad4311c79d95b0e62ad428ac1c59
post_install() {
- $GOPATH/bin/hut completion bash >hut.bash
- $GOPATH/bin/hut completion zsh >hut.zsh
- $GOPATH/bin/hut completion fish >hut.fish
-
- vcompletion hut.bash bash
- vcompletion hut.zsh zsh
- vcompletion hut.fish fish
+ hut=$(find $GOPATH/bin -name hut)
+ for sh in bash fish zsh; do
+ vtargetrun $hut completion $sh > hut.$sh
+ vcompletion hut.$sh $sh
+ done
vlicense LICENSE
```
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Updated] New package: hut-0.1.0
2022-04-16 3:57 [PR PATCH] New package: hut-0.1.0 kotajacob
` (5 preceding siblings ...)
2022-04-16 23:37 ` classabbyamp
@ 2022-04-17 1:02 ` kotajacob
2022-04-17 1:05 ` kotajacob
2022-07-01 6:03 ` [PR PATCH] [Merged]: " classabbyamp
8 siblings, 0 replies; 10+ messages in thread
From: kotajacob @ 2022-04-17 1:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]
There is an updated pull request by kotajacob against master on the void-packages repository
https://github.com/kotajacob/void-packages hub
https://github.com/void-linux/void-packages/pull/36716
New package: hut-0.1.0
This is the official command line client for https://sourcehut.org/
It's basically the sourcehut equivalent to Github's hub or gh tools.
It's been in development for a while now, but they've put out their
first release earlier this month. I've been using it happily for a while
before this release.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/36716.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hub-36716.patch --]
[-- Type: text/x-diff, Size: 1579 bytes --]
From beb0af0976530fe6d25e82e379c5391bbcd1e641 Mon Sep 17 00:00:00 2001
From: Dakota Walsh <kota@nilsu.org>
Date: Sat, 16 Apr 2022 15:52:54 +1200
Subject: [PATCH] New package: hut-0.1.0
This is the official command line client for https://sourcehut.org/
It's basically the sourcehut equivalent to Github's hub or gh tools.
It's been in development for a while now, but they've put out their
first release earlier this month. I've been using it happily for a while
before this release.
---
srcpkgs/hut/template | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
create mode 100644 srcpkgs/hut/template
diff --git a/srcpkgs/hut/template b/srcpkgs/hut/template
new file mode 100644
index 000000000000..f1448fcf1f49
--- /dev/null
+++ b/srcpkgs/hut/template
@@ -0,0 +1,29 @@
+# Template file for 'hut'
+pkgname=hut
+version=0.1.0
+revision=1
+wrksrc="${pkgname}-v${version}"
+build_style=go
+build_helper=qemu
+go_import_path="git.sr.ht/~emersion/hut"
+hostmakedepends="scdoc"
+short_desc="CLI tool for sr.ht"
+maintainer="Dakota Walsh <kota@nilsu.org>"
+license="AGPL-3.0-only"
+homepage="https://git.sr.ht/~emersion/hut"
+changelog="https://git.sr.ht/~emersion/hut/log"
+distfiles="https://git.sr.ht/~emersion/hut/archive/v${version}.tar.gz"
+checksum=5af8f1111f9ec1da9a818978eb1f013dfd50ad4311c79d95b0e62ad428ac1c59
+
+post_install() {
+ hut=$(find $GOPATH/bin -name hut)
+ for sh in bash fish zsh; do
+ vtargetrun $hut completion $sh > hut.$sh
+ vcompletion hut.$sh $sh
+ done
+
+ vlicense LICENSE
+
+ scdoc < doc/hut.1.scd > doc/hut.1
+ vman doc/hut.1
+}
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: New package: hut-0.1.0
2022-04-16 3:57 [PR PATCH] New package: hut-0.1.0 kotajacob
` (6 preceding siblings ...)
2022-04-17 1:02 ` [PR PATCH] [Updated] " kotajacob
@ 2022-04-17 1:05 ` kotajacob
2022-07-01 6:03 ` [PR PATCH] [Merged]: " classabbyamp
8 siblings, 0 replies; 10+ messages in thread
From: kotajacob @ 2022-04-17 1:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
New comment by kotajacob on void-packages repository
https://github.com/void-linux/void-packages/pull/36716#issuecomment-1100780514
Comment:
> I was able to get it to work with `hut=$(find $GOPATH/bin -name hut)` and `vtargetrun`
Huh perhaps I made a typo when I tried earlier. Just made that change and force pushed. Seems to be working now!
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PR PATCH] [Merged]: New package: hut-0.1.0
2022-04-16 3:57 [PR PATCH] New package: hut-0.1.0 kotajacob
` (7 preceding siblings ...)
2022-04-17 1:05 ` kotajacob
@ 2022-07-01 6:03 ` classabbyamp
8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2022-07-01 6:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
There's a merged pull request on the void-packages repository
New package: hut-0.1.0
https://github.com/void-linux/void-packages/pull/36716
Description:
This is the official command line client for https://sourcehut.org/
It's basically the sourcehut equivalent to Github's hub or gh tools.
It's been in development for a while now, but they've put out their
first release earlier this month. I've been using it happily for a while
before this release.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-07-01 6:03 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-16 3:57 [PR PATCH] New package: hut-0.1.0 kotajacob
2022-04-16 3:58 ` the-maldridge
2022-04-16 4:04 ` [PR REVIEW] " classabbyamp
2022-04-16 4:29 ` kotajacob
2022-04-16 22:43 ` kotajacob
2022-04-16 23:33 ` [PR REVIEW] " classabbyamp
2022-04-16 23:37 ` classabbyamp
2022-04-17 1:02 ` [PR PATCH] [Updated] " kotajacob
2022-04-17 1:05 ` kotajacob
2022-07-01 6:03 ` [PR PATCH] [Merged]: " classabbyamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).