[PR PATCH] New package: fx-21.0.0

[PR PATCH] New package: fx-21.0.0

[nulldutra]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

There is a new pull request by nulldutra against master on the void-packages repository

https://github.com/nulldutra/void-packages new-package-fx
https://github.com/void-linux/void-packages/pull/36805

New package: fx-21.0.0
https://github.com/antonmedv/fx

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the quality requirements: **YES**


A patch file from https://github.com/void-linux/void-packages/pull/36805.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new-package-fx-36805.patch --]
[-- Type: text/x-diff, Size: 944 bytes --]

From 6775eb3ad0cfb5ca5bee8938359313d140d69d24 Mon Sep 17 00:00:00 2001
From: "Gabriel M. Dutra" <nulldutra@gmail.com>
Date: Thu, 21 Apr 2022 13:20:50 -0300
Subject: [PATCH] New package: fx-21.0.0

---
 srcpkgs/fx/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/fx/template

diff --git a/srcpkgs/fx/template b/srcpkgs/fx/template
new file mode 100644
index 000000000000..56305e90d09e
--- /dev/null
+++ b/srcpkgs/fx/template
@@ -0,0 +1,17 @@
+# Template file for 'fx'
+pkgname=fx
+version=21.0.0
+revision=1
+build_style=go
+go_import_path="github.com/antonmedv/fx"
+hostmakedepends="git"
+short_desc="Terminal JSON viewer"
+maintainer="Gabriel M. Dutra <nulldutra@gmail.com>"
+license="MIT"
+homepage="https://github.com/antonmedv/fx"
+distfiles="$homepage/archive/$version.tar.gz"
+checksum=4711c582ce69c53f5ee8a348d603e0fab5f302859a020609ef33c2ef566f0d68
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: fx-21.0.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/36805#discussion_r855376311

Comment:
why does this need git?

Re: [PR REVIEW] New package: fx-21.0.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/36805#discussion_r855375853

Comment:
expand $homepage here

Re: [PR PATCH] [Updated] New package: fx-21.0.0

[nulldutra]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

There is an updated pull request by nulldutra against master on the void-packages repository

https://github.com/nulldutra/void-packages new-package-fx
https://github.com/void-linux/void-packages/pull/36805

New package: fx-21.0.0
https://github.com/antonmedv/fx

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the quality requirements: **YES**


A patch file from https://github.com/void-linux/void-packages/pull/36805.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new-package-fx-36805.patch --]
[-- Type: text/x-diff, Size: 1877 bytes --]

From 6775eb3ad0cfb5ca5bee8938359313d140d69d24 Mon Sep 17 00:00:00 2001
From: "Gabriel M. Dutra" <nulldutra@gmail.com>
Date: Thu, 21 Apr 2022 13:20:50 -0300
Subject: [PATCH 1/2] New package: fx-21.0.0

---
 srcpkgs/fx/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/fx/template

diff --git a/srcpkgs/fx/template b/srcpkgs/fx/template
new file mode 100644
index 000000000000..56305e90d09e
--- /dev/null
+++ b/srcpkgs/fx/template
@@ -0,0 +1,17 @@
+# Template file for 'fx'
+pkgname=fx
+version=21.0.0
+revision=1
+build_style=go
+go_import_path="github.com/antonmedv/fx"
+hostmakedepends="git"
+short_desc="Terminal JSON viewer"
+maintainer="Gabriel M. Dutra <nulldutra@gmail.com>"
+license="MIT"
+homepage="https://github.com/antonmedv/fx"
+distfiles="$homepage/archive/$version.tar.gz"
+checksum=4711c582ce69c53f5ee8a348d603e0fab5f302859a020609ef33c2ef566f0d68
+
+post_install() {
+	vlicense LICENSE
+}

From 6ca7d448a1f59d0d6340ba3b3febd85126ac79a4 Mon Sep 17 00:00:00 2001
From: "Gabriel M. Dutra" <nulldutra@gmail.com>
Date: Fri, 22 Apr 2022 12:59:08 -0300
Subject: [PATCH 2/2] fx: removing git dependency and expand homepage variable

---
 srcpkgs/fx/template | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/srcpkgs/fx/template b/srcpkgs/fx/template
index 56305e90d09e..69c9d066de8a 100644
--- a/srcpkgs/fx/template
+++ b/srcpkgs/fx/template
@@ -4,12 +4,11 @@ version=21.0.0
 revision=1
 build_style=go
 go_import_path="github.com/antonmedv/fx"
-hostmakedepends="git"
 short_desc="Terminal JSON viewer"
 maintainer="Gabriel M. Dutra <nulldutra@gmail.com>"
 license="MIT"
 homepage="https://github.com/antonmedv/fx"
-distfiles="$homepage/archive/$version.tar.gz"
+distfiles="${homepage}/archive/$version.tar.gz"
 checksum=4711c582ce69c53f5ee8a348d603e0fab5f302859a020609ef33c2ef566f0d68
 
 post_install() {

Re: [PR REVIEW] New package: fx-21.0.0

[nulldutra]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New review comment by nulldutra on void-packages repository

https://github.com/void-linux/void-packages/pull/36805#discussion_r856374029

Comment:
In other packages, $homepage variable is not expanded. What motivation for this? but, I made the adjustment in the variable.

Re: [PR REVIEW] New package: fx-21.0.0

[nulldutra]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by nulldutra on void-packages repository

https://github.com/void-linux/void-packages/pull/36805#discussion_r856374165

Comment:
Sorry, git is not needed. Removed!

Re: [PR REVIEW] New package: fx-21.0.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/36805#discussion_r856391752

Comment:
having variables other than $version (like $homepage or $pkgname) in distfiles urls cause more changes to be needed if one changes. some packages did this before and they haven't been changed yet.

Re: New package: fx-21.0.0

[abenson]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/36805#issuecomment-1106763878

Comment:
[Squash the two into a single commit.](https://www.git-tower.com/learn/git/faq/git-squash)