[PR PATCH] New package: r2ghidra-dec-4.5.0

[PR PATCH] New package: r2ghidra-dec-4.5.0

[phirecc]

[-- Attachment #1: Type: text/plain, Size: 808 bytes --]

There is a new pull request by phirecc against master on the void-packages repository

https://github.com/phirecc/void-packages master
https://github.com/void-linux/void-packages/pull/24453

New package: r2ghidra-dec-4.5.0
See [Issue for Cutter](https://github.com/void-linux/void-packages/issues/21159) but it is instead packaged seperate, like arch does it ([PKGBUILD](https://github.com/archlinux/svntogit-community/blob/packages/r2ghidra-dec/trunk/PKGBUILD)).
The `11-pkglint-elf-in-usrshare.sh` post-install hook fails, but radare2 expects plugins in `/usr/share/radare2/plugins` and Cutter expects them in `/usr/share/RadareOrg/Cutter/plugins`, with the only alternative being `~/.local`, as far as I'm aware.

A patch file from https://github.com/void-linux/void-packages/pull/24453.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-24453.patch --]
[-- Type: text/x-diff, Size: 1374 bytes --]

From 224cb993b9ea7d7c045ceb3703ade697943df8c0 Mon Sep 17 00:00:00 2001
From: phire <me@phire.cc>
Date: Mon, 24 Aug 2020 13:38:13 +0200
Subject: [PATCH] New package: r2ghidra-dec-4.5.0

---
 srcpkgs/r2ghidra-dec/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/r2ghidra-dec/template

diff --git a/srcpkgs/r2ghidra-dec/template b/srcpkgs/r2ghidra-dec/template
new file mode 100644
index 00000000000..4da536b414a
--- /dev/null
+++ b/srcpkgs/r2ghidra-dec/template
@@ -0,0 +1,23 @@
+# Template file for 'r2ghidra-dec'
+_cutterversion=1.11.1
+pkgname=r2ghidra-dec
+version=4.5.0
+revision=1
+archs="x86_64"
+build_style=cmake
+configure_args="-DCMAKE_INSTALL_PREFIX=/usr -DBUILD_CUTTER_PLUGIN=ON -DCUTTER_SOURCE_DIR=../cutter .."
+hostmakedepends="pkg-config cmake git bison flex"
+makedepends="radare2 qt5-devel capstone-devel"
+depends="radare2"
+short_desc="Deep ghidra decompiler integration for radare2 and Cutter"
+maintainer="phire <me@phire.cc>"
+license="LGPL-3.0-only"
+homepage="https://github.com/radareorg/r2ghidra-dec"
+
+do_fetch() {
+	git clone --depth 1 --branch v${version} https://github.com/radareorg/r2ghidra-dec.git ${wrksrc}
+	git clone --depth 1 --branch v${_cutterversion} https://github.com/radareorg/cutter.git ${wrksrc}/cutter
+	cd ${wrksrc}
+	git submodule init
+	git submodule update --recursive
+}

Re: [PR REVIEW] New package: r2ghidra-dec-4.5.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#discussion_r475551924

Comment:
This isn't a good solution. The build can change if they make updates to the branch. You should fetch all the files, including submodules, by adding a definitive file to `distfiles`. So either a tag or specific commit.

Re: New package: r2ghidra-dec-4.5.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#issuecomment-679087213

Comment:
Once #23601 is merged, you can use it.

Re: [PR PATCH] [Updated] New package: r2ghidra-dec-4.5.0

[phirecc]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

There is an updated pull request by phirecc against master on the void-packages repository

https://github.com/phirecc/void-packages master
https://github.com/void-linux/void-packages/pull/24453

New package: r2ghidra-dec-4.5.0
See [Issue for Cutter](https://github.com/void-linux/void-packages/issues/21159) but it is instead packaged seperate, like arch does it ([PKGBUILD](https://github.com/archlinux/svntogit-community/blob/packages/r2ghidra-dec/trunk/PKGBUILD)).
The `11-pkglint-elf-in-usrshare.sh` post-install hook fails, but radare2 expects plugins in `/usr/share/radare2/plugins` and Cutter expects them in `/usr/share/RadareOrg/Cutter/plugins`, with the only alternative being `~/.local`, as far as I'm aware.

A patch file from https://github.com/void-linux/void-packages/pull/24453.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-24453.patch --]
[-- Type: text/x-diff, Size: 1991 bytes --]

From f097f83bb6135303ed1d6429a1acb88aff547675 Mon Sep 17 00:00:00 2001
From: phire <me@phire.cc>
Date: Mon, 24 Aug 2020 13:38:13 +0200
Subject: [PATCH] New package: r2ghidra-dec-4.5.0

---
 srcpkgs/r2ghidra-dec/template | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 srcpkgs/r2ghidra-dec/template

diff --git a/srcpkgs/r2ghidra-dec/template b/srcpkgs/r2ghidra-dec/template
new file mode 100644
index 00000000000..caac50b3dac
--- /dev/null
+++ b/srcpkgs/r2ghidra-dec/template
@@ -0,0 +1,30 @@
+# Template file for 'r2ghidra-dec'
+_cutterversion=1.11.1
+_ghidracommit=6c10f36f06468f866188cccf960c019779fb9028
+_pugixmlcommit=fdf02957533645069bbea7cd2ed85a3014b42cf3
+pkgname=r2ghidra-dec
+version=4.5.0
+revision=1
+archs="x86_64"
+build_style=cmake
+configure_args="-DCMAKE_INSTALL_PREFIX=/usr -DBUILD_CUTTER_PLUGIN=ON -DCUTTER_SOURCE_DIR=${XBPS_BUILDDIR}/cutter-${_cutterversion} .."
+hostmakedepends="pkg-config cmake git bison flex"
+makedepends="radare2 qt5-devel capstone-devel"
+depends="radare2"
+short_desc="Deep ghidra decompiler integration for radare2 and Cutter"
+maintainer="phire <me@phire.cc>"
+license="LGPL-3.0-only"
+homepage="https://github.com/radareorg/r2ghidra-dec"
+distfiles="https://github.com/radareorg/r2ghidra-dec/archive/v${version}.tar.gz \
+	https://github.com/radareorg/cutter/archive/v${_cutterversion}.tar.gz \
+	https://github.com/thestr4ng3r/ghidra/archive/${_ghidracommit}.tar.gz \
+	https://github.com/zeux/pugixml/archive/${_pugixmlcommit}.tar.gz"
+checksum="cca6ed8bc1bf4626bcf8e1fab65e85d1320635f5b5f6903b22d66e376faf5108 \
+	07ed1b71a7f4ea8a99aab56839893c1d59aabbf5c8a4ffbd6ecf36bbb00f6ab3 \
+	f94d81919bddc5f1095250e02b1fdf57acba15e68c818d6c33088875e6759d21 \
+	cad9cf37ec54bb98b40afc03cd5e2fdc78682fe0f235fd02c575d9b4d9443b83"
+
+pre_configure() {
+	mv -T ${XBPS_BUILDDIR}/ghidra-${_ghidracommit} ${wrksrc}/ghidra/ghidra
+	mv -T ${XBPS_BUILDDIR}/pugixml-${_pugixmlcommit} ${wrksrc}/third-party/pugixml
+}

Re: [PR REVIEW] New package: r2ghidra-dec-4.5.0

[phirecc]

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New review comment by phirecc on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#discussion_r475588708

Comment:
Updated

Re: New package: r2ghidra-dec-4.5.0

[phirecc]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

New comment by phirecc on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#issuecomment-679118094

Comment:
> Once #23601 is merged, you can use it.

I just noticed Arch just moves them to lib in their PKGBUILD `mv "${pkgdir}"/usr/share/radare2/plugins/*.so -t "${pkgdir}/usr/lib/radare2/${r2version}"`. Should I still wait for #23601 or just move it too?

Re: New package: r2ghidra-dec-4.5.0

[phirecc]

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

New comment by phirecc on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#issuecomment-679118094

Comment:
> Once #23601 is merged, you can use it.

I just noticed Arch just moves them to lib in their PKGBUILD `mv "${pkgdir}"/usr/share/radare2/plugins/*.so -t "${pkgdir}/usr/lib/radare2/${r2version}"`. Should I still wait for #23601 or just move too?

Re: New package: r2ghidra-dec-4.5.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#issuecomment-679120558

Comment:
I guess it depends. If the program works fine with the files there, it should be fine to move. Not sure what's preferred, though.

Re: [PR PATCH] [Updated] New package: r2ghidra-dec-4.5.0

[phirecc]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

There is an updated pull request by phirecc against master on the void-packages repository

https://github.com/phirecc/void-packages master
https://github.com/void-linux/void-packages/pull/24453

New package: r2ghidra-dec-4.5.0
See [Issue for Cutter](https://github.com/void-linux/void-packages/issues/21159) but it is instead packaged seperate, like arch does it ([PKGBUILD](https://github.com/archlinux/svntogit-community/blob/packages/r2ghidra-dec/trunk/PKGBUILD)).
The `11-pkglint-elf-in-usrshare.sh` post-install hook fails, but radare2 expects plugins in `/usr/share/radare2/plugins` and Cutter expects them in `/usr/share/RadareOrg/Cutter/plugins`, with the only alternative being `~/.local`, as far as I'm aware.

A patch file from https://github.com/void-linux/void-packages/pull/24453.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-24453.patch --]
[-- Type: text/x-diff, Size: 1980 bytes --]

From 89143c0376094974cfd75e61f3f9255fa7fae444 Mon Sep 17 00:00:00 2001
From: phire <me@phire.cc>
Date: Mon, 24 Aug 2020 13:38:13 +0200
Subject: [PATCH] New package: r2ghidra-dec-4.5.0

---
 srcpkgs/r2ghidra-dec/template | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 srcpkgs/r2ghidra-dec/template

diff --git a/srcpkgs/r2ghidra-dec/template b/srcpkgs/r2ghidra-dec/template
new file mode 100644
index 00000000000..b3e413c166c
--- /dev/null
+++ b/srcpkgs/r2ghidra-dec/template
@@ -0,0 +1,30 @@
+# Template file for 'r2ghidra-dec'
+_cutterversion=1.11.1
+_ghidracommit=6c10f36f06468f866188cccf960c019779fb9028
+_pugixmlcommit=fdf02957533645069bbea7cd2ed85a3014b42cf3
+pkgname=r2ghidra-dec
+version=4.5.0
+revision=1
+archs="x86_64"
+build_style=cmake
+configure_args="-DCMAKE_INSTALL_PREFIX=/usr -DBUILD_CUTTER_PLUGIN=ON -DCUTTER_SOURCE_DIR=${XBPS_BUILDDIR}/cutter-${_cutterversion} .."
+hostmakedepends="pkg-config cmake git bison flex"
+makedepends="radare2 qt5-devel capstone-devel"
+depends="radare2"
+short_desc="Deep ghidra decompiler integration for radare2 and Cutter"
+maintainer="phire <me@phire.cc>"
+license="LGPL-3.0-only"
+homepage="https://github.com/radareorg/r2ghidra-dec"
+distfiles="https://github.com/radareorg/r2ghidra-dec/archive/v${version}.tar.gz
+ https://github.com/radareorg/cutter/archive/v${_cutterversion}.tar.gz 
+ https://github.com/thestr4ng3r/ghidra/archive/${_ghidracommit}.tar.gz
+ https://github.com/zeux/pugixml/archive/${_pugixmlcommit}.tar.gz"
+checksum="cca6ed8bc1bf4626bcf8e1fab65e85d1320635f5b5f6903b22d66e376faf5108
+ 07ed1b71a7f4ea8a99aab56839893c1d59aabbf5c8a4ffbd6ecf36bbb00f6ab3
+ f94d81919bddc5f1095250e02b1fdf57acba15e68c818d6c33088875e6759d21
+ cad9cf37ec54bb98b40afc03cd5e2fdc78682fe0f235fd02c575d9b4d9443b83"
+
+pre_configure() {
+	mv -T ${XBPS_BUILDDIR}/ghidra-${_ghidracommit} ${wrksrc}/ghidra/ghidra
+	mv -T ${XBPS_BUILDDIR}/pugixml-${_pugixmlcommit} ${wrksrc}/third-party/pugixml
+}

Re: New package: r2ghidra-dec-4.5.0

[phirecc]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by phirecc on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#issuecomment-679121785

Comment:
I'll try if it works with moving. Also just fixed the listing in distfiles and checksum

Re: [PR PATCH] [Updated] New package: r2ghidra-dec-4.5.0

[phirecc]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

There is an updated pull request by phirecc against master on the void-packages repository

https://github.com/phirecc/void-packages master
https://github.com/void-linux/void-packages/pull/24453

New package: r2ghidra-dec-4.5.0
See [Issue for Cutter](https://github.com/void-linux/void-packages/issues/21159) but it is instead packaged seperate, like arch does it ([PKGBUILD](https://github.com/archlinux/svntogit-community/blob/packages/r2ghidra-dec/trunk/PKGBUILD)).
The `11-pkglint-elf-in-usrshare.sh` post-install hook fails, but radare2 expects plugins in `/usr/share/radare2/plugins` and Cutter expects them in `/usr/share/RadareOrg/Cutter/plugins`, with the only alternative being `~/.local`, as far as I'm aware.

A patch file from https://github.com/void-linux/void-packages/pull/24453.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-24453.patch --]
[-- Type: text/x-diff, Size: 1979 bytes --]

From cba3752a5f63e98ddd09e5de3087020d12f4aefc Mon Sep 17 00:00:00 2001
From: phire <me@phire.cc>
Date: Mon, 24 Aug 2020 13:38:13 +0200
Subject: [PATCH] New package: r2ghidra-dec-4.5.0

---
 srcpkgs/r2ghidra-dec/template | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 srcpkgs/r2ghidra-dec/template

diff --git a/srcpkgs/r2ghidra-dec/template b/srcpkgs/r2ghidra-dec/template
new file mode 100644
index 00000000000..6076411a1e2
--- /dev/null
+++ b/srcpkgs/r2ghidra-dec/template
@@ -0,0 +1,30 @@
+# Template file for 'r2ghidra-dec'
+_cutterversion=1.11.1
+_ghidracommit=6c10f36f06468f866188cccf960c019779fb9028
+_pugixmlcommit=fdf02957533645069bbea7cd2ed85a3014b42cf3
+pkgname=r2ghidra-dec
+version=4.5.0
+revision=1
+archs="x86_64"
+build_style=cmake
+configure_args="-DCMAKE_INSTALL_PREFIX=/usr -DBUILD_CUTTER_PLUGIN=ON -DCUTTER_SOURCE_DIR=${XBPS_BUILDDIR}/cutter-${_cutterversion} .."
+hostmakedepends="pkg-config cmake git bison flex"
+makedepends="radare2 qt5-devel capstone-devel"
+depends="radare2"
+short_desc="Deep ghidra decompiler integration for radare2 and Cutter"
+maintainer="phire <me@phire.cc>"
+license="LGPL-3.0-only"
+homepage="https://github.com/radareorg/r2ghidra-dec"
+distfiles="https://github.com/radareorg/r2ghidra-dec/archive/v${version}.tar.gz
+ https://github.com/radareorg/cutter/archive/v${_cutterversion}.tar.gz
+ https://github.com/thestr4ng3r/ghidra/archive/${_ghidracommit}.tar.gz
+ https://github.com/zeux/pugixml/archive/${_pugixmlcommit}.tar.gz"
+checksum="cca6ed8bc1bf4626bcf8e1fab65e85d1320635f5b5f6903b22d66e376faf5108
+ 07ed1b71a7f4ea8a99aab56839893c1d59aabbf5c8a4ffbd6ecf36bbb00f6ab3
+ f94d81919bddc5f1095250e02b1fdf57acba15e68c818d6c33088875e6759d21
+ cad9cf37ec54bb98b40afc03cd5e2fdc78682fe0f235fd02c575d9b4d9443b83"
+
+pre_configure() {
+	mv -T ${XBPS_BUILDDIR}/ghidra-${_ghidracommit} ${wrksrc}/ghidra/ghidra
+	mv -T ${XBPS_BUILDDIR}/pugixml-${_pugixmlcommit} ${wrksrc}/third-party/pugixml
+}

Re: New package: r2ghidra-dec-4.5.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#issuecomment-679123630

Comment:
Out of curitosity, any reason this can't be built into the ghidra template?

Re: New package: r2ghidra-dec-4.5.0

[phirecc]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

New comment by phirecc on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#issuecomment-679126578

Comment:
This is only the decompiler part of ghidra, which is portable and written in C++ while the rest of ghidra is written in Java. People who want to use ghidra's decompiler in radare2/cutter don't necessarily want the entire ghidra installed, and people who want to install ghidra don't necessarily want the radare2/cutter plugins installed.

Re: [PR PATCH] [Updated] New package: r2ghidra-dec-4.5.0

[phirecc]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

There is an updated pull request by phirecc against master on the void-packages repository

https://github.com/phirecc/void-packages master
https://github.com/void-linux/void-packages/pull/24453

New package: r2ghidra-dec-4.5.0
See [Issue for Cutter](https://github.com/void-linux/void-packages/issues/21159) but it is instead packaged seperate, like arch does it ([PKGBUILD](https://github.com/archlinux/svntogit-community/blob/packages/r2ghidra-dec/trunk/PKGBUILD)).
The `11-pkglint-elf-in-usrshare.sh` post-install hook fails, but radare2 expects plugins in `/usr/share/radare2/plugins` and Cutter expects them in `/usr/share/RadareOrg/Cutter/plugins`, with the only alternative being `~/.local`, as far as I'm aware.

A patch file from https://github.com/void-linux/void-packages/pull/24453.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-24453.patch --]
[-- Type: text/x-diff, Size: 1976 bytes --]

From 98885035c689afe1dd69b18ba67d20db21c36fcb Mon Sep 17 00:00:00 2001
From: phire <me@phire.cc>
Date: Mon, 24 Aug 2020 13:38:13 +0200
Subject: [PATCH] New package: r2ghidra-dec-4.5.0

---
 srcpkgs/r2ghidra-dec/template | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 srcpkgs/r2ghidra-dec/template

diff --git a/srcpkgs/r2ghidra-dec/template b/srcpkgs/r2ghidra-dec/template
new file mode 100644
index 00000000000..46294828af7
--- /dev/null
+++ b/srcpkgs/r2ghidra-dec/template
@@ -0,0 +1,30 @@
+# Template file for 'r2ghidra-dec'
+_cutterversion=1.11.1
+_ghidracommit=6c10f36f06468f866188cccf960c019779fb9028
+_pugixmlcommit=fdf02957533645069bbea7cd2ed85a3014b42cf3
+pkgname=r2ghidra-dec
+version=4.5.0
+revision=1
+archs="x86_64"
+build_style=cmake
+configure_args="-DCMAKE_INSTALL_PREFIX=/usr -DBUILD_CUTTER_PLUGIN=ON -DCUTTER_SOURCE_DIR=${XBPS_BUILDDIR}/cutter-${_cutterversion}"
+hostmakedepends="pkg-config cmake git bison flex"
+makedepends="radare2 qt5-devel capstone-devel"
+depends="radare2"
+short_desc="Deep ghidra decompiler integration for radare2 and Cutter"
+maintainer="phire <me@phire.cc>"
+license="LGPL-3.0-only"
+homepage="https://github.com/radareorg/r2ghidra-dec"
+distfiles="https://github.com/radareorg/r2ghidra-dec/archive/v${version}.tar.gz
+ https://github.com/radareorg/cutter/archive/v${_cutterversion}.tar.gz
+ https://github.com/thestr4ng3r/ghidra/archive/${_ghidracommit}.tar.gz
+ https://github.com/zeux/pugixml/archive/${_pugixmlcommit}.tar.gz"
+checksum="cca6ed8bc1bf4626bcf8e1fab65e85d1320635f5b5f6903b22d66e376faf5108
+ 07ed1b71a7f4ea8a99aab56839893c1d59aabbf5c8a4ffbd6ecf36bbb00f6ab3
+ f94d81919bddc5f1095250e02b1fdf57acba15e68c818d6c33088875e6759d21
+ cad9cf37ec54bb98b40afc03cd5e2fdc78682fe0f235fd02c575d9b4d9443b83"
+
+pre_configure() {
+	mv -T ${XBPS_BUILDDIR}/ghidra-${_ghidracommit} ${wrksrc}/ghidra/ghidra
+	mv -T ${XBPS_BUILDDIR}/pugixml-${_pugixmlcommit} ${wrksrc}/third-party/pugixml
+}

Re: New package: r2ghidra-dec-4.5.0

[phirecc]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

New comment by phirecc on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#issuecomment-679216462

Comment:
Arch only moves the radare2 plugin .so and not the Cutter one. I couldn't get Cutter to load the plugin when I placed it in lib, so I guess this will have to wait for #23601 to be merged.

Re: [PR PATCH] [Updated] New package: r2ghidra-dec-4.5.0

[phirecc]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

There is an updated pull request by phirecc against master on the void-packages repository

https://github.com/phirecc/void-packages master
https://github.com/void-linux/void-packages/pull/24453

New package: r2ghidra-dec-4.5.0
See [Issue for Cutter](https://github.com/void-linux/void-packages/issues/21159) but it is instead packaged seperate, like arch does it ([PKGBUILD](https://github.com/archlinux/svntogit-community/blob/packages/r2ghidra-dec/trunk/PKGBUILD)).
The `11-pkglint-elf-in-usrshare.sh` post-install hook fails, but radare2 expects plugins in `/usr/share/radare2/plugins` and Cutter expects them in `/usr/share/RadareOrg/Cutter/plugins`, with the only alternative being `~/.local`, as far as I'm aware.

A patch file from https://github.com/void-linux/void-packages/pull/24453.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-24453.patch --]
[-- Type: text/x-diff, Size: 2135 bytes --]

From 47c8a57078312b595e65681ac6383beeb8e22e66 Mon Sep 17 00:00:00 2001
From: phire <me@phire.cc>
Date: Mon, 24 Aug 2020 13:38:13 +0200
Subject: [PATCH] New package: r2ghidra-dec-4.5.0

---
 srcpkgs/r2ghidra-dec/template | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 srcpkgs/r2ghidra-dec/template

diff --git a/srcpkgs/r2ghidra-dec/template b/srcpkgs/r2ghidra-dec/template
new file mode 100644
index 00000000000..d4f0d002a9a
--- /dev/null
+++ b/srcpkgs/r2ghidra-dec/template
@@ -0,0 +1,35 @@
+# Template file for 'r2ghidra-dec'
+_cutterversion=1.11.1
+_ghidracommit=6c10f36f06468f866188cccf960c019779fb9028
+_pugixmlcommit=fdf02957533645069bbea7cd2ed85a3014b42cf3
+pkgname=r2ghidra-dec
+version=4.5.0
+revision=1
+archs="x86_64"
+build_style=cmake
+configure_args="-DCMAKE_INSTALL_PREFIX=/usr -DBUILD_CUTTER_PLUGIN=ON -DCUTTER_SOURCE_DIR=${XBPS_BUILDDIR}/cutter-${_cutterversion}"
+hostmakedepends="pkg-config cmake git bison flex"
+makedepends="radare2 qt5-devel capstone-devel"
+depends="radare2"
+short_desc="Deep ghidra decompiler integration for radare2 and Cutter"
+maintainer="phire <me@phire.cc>"
+license="LGPL-3.0-only"
+homepage="https://github.com/radareorg/r2ghidra-dec"
+distfiles="https://github.com/radareorg/r2ghidra-dec/archive/v${version}.tar.gz
+ https://github.com/radareorg/cutter/archive/v${_cutterversion}.tar.gz
+ https://github.com/thestr4ng3r/ghidra/archive/${_ghidracommit}.tar.gz
+ https://github.com/zeux/pugixml/archive/${_pugixmlcommit}.tar.gz"
+checksum="cca6ed8bc1bf4626bcf8e1fab65e85d1320635f5b5f6903b22d66e376faf5108
+ 07ed1b71a7f4ea8a99aab56839893c1d59aabbf5c8a4ffbd6ecf36bbb00f6ab3
+ f94d81919bddc5f1095250e02b1fdf57acba15e68c818d6c33088875e6759d21
+ cad9cf37ec54bb98b40afc03cd5e2fdc78682fe0f235fd02c575d9b4d9443b83"
+
+pre_configure() {
+	mv -T ${XBPS_BUILDDIR}/ghidra-${_ghidracommit} ${wrksrc}/ghidra/ghidra
+	mv -T ${XBPS_BUILDDIR}/pugixml-${_pugixmlcommit} ${wrksrc}/third-party/pugixml
+}
+
+post-install() {
+	mkdir ${DESTDIR}/usr/lib/radare2/${version}
+	mv ${DESTDIR}/usr/share/radare2/plugins/*.so ${DESTDIR}/usr/lib/radare2/${version}
+}

Re: [PR PATCH] [Updated] New package: r2ghidra-dec-4.5.0

[phirecc]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

There is an updated pull request by phirecc against master on the void-packages repository

https://github.com/phirecc/void-packages master
https://github.com/void-linux/void-packages/pull/24453

New package: r2ghidra-dec-4.5.0
See [Issue for Cutter](https://github.com/void-linux/void-packages/issues/21159) but it is instead packaged seperate, like arch does it ([PKGBUILD](https://github.com/archlinux/svntogit-community/blob/packages/r2ghidra-dec/trunk/PKGBUILD)).
The `11-pkglint-elf-in-usrshare.sh` post-install hook fails, but radare2 expects plugins in `/usr/share/radare2/plugins` and Cutter expects them in `/usr/share/RadareOrg/Cutter/plugins`, with the only alternative being `~/.local`, as far as I'm aware.

A patch file from https://github.com/void-linux/void-packages/pull/24453.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-24453.patch --]
[-- Type: text/x-diff, Size: 2262 bytes --]

From 3c79a73d974743f53c826bcce79229e7ace07b36 Mon Sep 17 00:00:00 2001
From: phire <me@phire.cc>
Date: Mon, 24 Aug 2020 13:38:13 +0200
Subject: [PATCH] New package: r2ghidra-dec-4.5.0

---
 srcpkgs/r2ghidra-dec/template | 36 +++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 srcpkgs/r2ghidra-dec/template

diff --git a/srcpkgs/r2ghidra-dec/template b/srcpkgs/r2ghidra-dec/template
new file mode 100644
index 00000000000..59e857ff03d
--- /dev/null
+++ b/srcpkgs/r2ghidra-dec/template
@@ -0,0 +1,36 @@
+# Template file for 'r2ghidra-dec'
+_cutterversion=1.11.1
+_ghidracommit=6c10f36f06468f866188cccf960c019779fb9028
+_pugixmlcommit=fdf02957533645069bbea7cd2ed85a3014b42cf3
+pkgname=r2ghidra-dec
+version=4.5.0
+revision=1
+archs="x86_64"
+build_style=cmake
+configure_args="-DCMAKE_INSTALL_PREFIX=/usr -DBUILD_CUTTER_PLUGIN=ON -DCUTTER_SOURCE_DIR=${XBPS_BUILDDIR}/cutter-${_cutterversion}"
+ignore_elf_files="/usr/share/RadareOrg/Cutter/plugins/native/libr2ghidra_cutter.so /usr/share/radare2/plugins/core_ghidra.so"
+hostmakedepends="pkg-config cmake git bison flex"
+makedepends="radare2 qt5-devel capstone-devel"
+depends="radare2"
+short_desc="Deep ghidra decompiler integration for radare2 and Cutter"
+maintainer="phire <me@phire.cc>"
+license="LGPL-3.0-only"
+homepage="https://github.com/radareorg/r2ghidra-dec"
+distfiles="https://github.com/radareorg/r2ghidra-dec/archive/v${version}.tar.gz
+ https://github.com/radareorg/cutter/archive/v${_cutterversion}.tar.gz
+ https://github.com/thestr4ng3r/ghidra/archive/${_ghidracommit}.tar.gz
+ https://github.com/zeux/pugixml/archive/${_pugixmlcommit}.tar.gz"
+checksum="cca6ed8bc1bf4626bcf8e1fab65e85d1320635f5b5f6903b22d66e376faf5108
+ 07ed1b71a7f4ea8a99aab56839893c1d59aabbf5c8a4ffbd6ecf36bbb00f6ab3
+ f94d81919bddc5f1095250e02b1fdf57acba15e68c818d6c33088875e6759d21
+ cad9cf37ec54bb98b40afc03cd5e2fdc78682fe0f235fd02c575d9b4d9443b83"
+
+pre_configure() {
+	mv -T ${XBPS_BUILDDIR}/ghidra-${_ghidracommit} ${wrksrc}/ghidra/ghidra
+	mv -T ${XBPS_BUILDDIR}/pugixml-${_pugixmlcommit} ${wrksrc}/third-party/pugixml
+}
+
+post-install() {
+	mkdir ${DESTDIR}/usr/lib/radare2/${version}
+	mv ${DESTDIR}/usr/share/radare2/plugins/*.so ${DESTDIR}/usr/lib/radare2/${version}
+}

Re: New package: r2ghidra-dec-4.5.0

[phirecc]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New comment by phirecc on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#issuecomment-681158746

Comment:
`xlint` should be updated for `ignore_elf_files`, but the package works now. Please review

Re: [PR REVIEW] New package: r2ghidra-dec-4.5.0

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New review comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#discussion_r478083414

Comment:
`post_extract()` is better.

Re: [PR REVIEW] New package: r2ghidra-dec-4.5.0

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New review comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#discussion_r478083914

Comment:
Is this really only for `x86_64`, or is it `nocross`?

Re: [PR REVIEW] New package: r2ghidra-dec-4.5.0

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

New review comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#discussion_r478085533

Comment:
`-DCMAKE_INSTALL_PREFIX=/usr ` is unneeded, specified in the `cmake` build_style. Also split across two lines, line length should be only 80 characters.

Re: [PR REVIEW] New package: r2ghidra-dec-4.5.0

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]

New review comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#discussion_r478086152

Comment:
`git` is no longer needed AFAICT.

Re: [PR REVIEW] New package: r2ghidra-dec-4.5.0

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 177 bytes --]

New review comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#discussion_r478085769

Comment:
Also split across two lines.

Re: [PR REVIEW] New package: r2ghidra-dec-4.5.0

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#discussion_r478315354

Comment:
`ghidra` seems to be `x86_64*`, perhaps it's the same issue? @abenson is there some comment that can be left on the template?

Re: [PR REVIEW] New package: r2ghidra-dec-4.5.0

[fosslinux]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New review comment by fosslinux on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#discussion_r478320664

Comment:
Well this should then be at least `x86_64*` then probably.

Re: [PR PATCH] [Updated] New package: r2ghidra-dec-4.5.0

[phirecc]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

There is an updated pull request by phirecc against master on the void-packages repository

https://github.com/phirecc/void-packages master
https://github.com/void-linux/void-packages/pull/24453

New package: r2ghidra-dec-4.5.0
See [Issue for Cutter](https://github.com/void-linux/void-packages/issues/21159) but it is instead packaged seperate, like arch does it ([PKGBUILD](https://github.com/archlinux/svntogit-community/blob/packages/r2ghidra-dec/trunk/PKGBUILD)).
The `11-pkglint-elf-in-usrshare.sh` post-install hook fails, but radare2 expects plugins in `/usr/share/radare2/plugins` and Cutter expects them in `/usr/share/RadareOrg/Cutter/plugins`, with the only alternative being `~/.local`, as far as I'm aware.

A patch file from https://github.com/void-linux/void-packages/pull/24453.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-24453.patch --]
[-- Type: text/x-diff, Size: 2195 bytes --]

From 66683ec57fc64e7e16b4bc83ba63d2ab879f223f Mon Sep 17 00:00:00 2001
From: phire <me@phire.cc>
Date: Mon, 24 Aug 2020 13:38:13 +0200
Subject: [PATCH] New package: r2ghidra-dec-4.5.0

---
 srcpkgs/r2ghidra-dec/template | 37 +++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 srcpkgs/r2ghidra-dec/template

diff --git a/srcpkgs/r2ghidra-dec/template b/srcpkgs/r2ghidra-dec/template
new file mode 100644
index 00000000000..ef1f916f508
--- /dev/null
+++ b/srcpkgs/r2ghidra-dec/template
@@ -0,0 +1,37 @@
+# Template file for 'r2ghidra-dec'
+_cutterversion=1.11.1
+_ghidracommit=6c10f36f06468f866188cccf960c019779fb9028
+_pugixmlcommit=fdf02957533645069bbea7cd2ed85a3014b42cf3
+pkgname=r2ghidra-dec
+version=4.5.0
+revision=1
+archs="x86_64*"
+build_style=cmake
+configure_args="-DBUILD_CUTTER_PLUGIN=ON \
+	-DCUTTER_SOURCE_DIR=${XBPS_BUILDDIR}/cutter-${_cutterversion}"
+ignore_elf_files="/usr/share/RadareOrg/Cutter/plugins/native/libr2ghidra_cutter.so"
+hostmakedepends="pkg-config cmake bison flex"
+makedepends="radare2 qt5-devel capstone-devel"
+depends="radare2"
+short_desc="Deep ghidra decompiler integration for radare2 and Cutter"
+maintainer="phire <me@phire.cc>"
+license="LGPL-3.0-only"
+homepage="https://github.com/radareorg/r2ghidra-dec"
+distfiles="https://github.com/radareorg/r2ghidra-dec/archive/v${version}.tar.gz
+ https://github.com/radareorg/cutter/archive/v${_cutterversion}.tar.gz
+ https://github.com/thestr4ng3r/ghidra/archive/${_ghidracommit}.tar.gz
+ https://github.com/zeux/pugixml/archive/${_pugixmlcommit}.tar.gz"
+checksum="cca6ed8bc1bf4626bcf8e1fab65e85d1320635f5b5f6903b22d66e376faf5108
+ 07ed1b71a7f4ea8a99aab56839893c1d59aabbf5c8a4ffbd6ecf36bbb00f6ab3
+ f94d81919bddc5f1095250e02b1fdf57acba15e68c818d6c33088875e6759d21
+ cad9cf37ec54bb98b40afc03cd5e2fdc78682fe0f235fd02c575d9b4d9443b83"
+
+post_extract() {
+	mv -T ${XBPS_BUILDDIR}/ghidra-${_ghidracommit} ${wrksrc}/ghidra/ghidra
+	mv -T ${XBPS_BUILDDIR}/pugixml-${_pugixmlcommit} ${wrksrc}/third-party/pugixml
+}
+
+post_install() {
+	mkdir -p ${DESTDIR}/usr/lib/radare2/${version}
+	mv ${DESTDIR}/usr/share/radare2/plugins/*.so ${DESTDIR}/usr/lib/radare2/${version}
+}

Re: New package: r2ghidra-dec-4.5.0

[phirecc]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New comment by phirecc on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#issuecomment-681967258

Comment:
Thanks, done

Re: New package: r2ghidra-dec-4.5.0

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#issuecomment-682111185

Comment:
Usage of ignore_elf is wrong here, because /usr/share should be still architecture independent.

Re: [PR PATCH] [Updated] New package: r2ghidra-dec-4.5.0

[phirecc]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

There is an updated pull request by phirecc against master on the void-packages repository

https://github.com/phirecc/void-packages master
https://github.com/void-linux/void-packages/pull/24453

New package: r2ghidra-dec-4.5.0
See [Issue for Cutter](https://github.com/void-linux/void-packages/issues/21159) but it is instead packaged seperate, like arch does it ([PKGBUILD](https://github.com/archlinux/svntogit-community/blob/packages/r2ghidra-dec/trunk/PKGBUILD)).
The `11-pkglint-elf-in-usrshare.sh` post-install hook fails, but radare2 expects plugins in `/usr/share/radare2/plugins` and Cutter expects them in `/usr/share/RadareOrg/Cutter/plugins`, with the only alternative being `~/.local`, as far as I'm aware.

A patch file from https://github.com/void-linux/void-packages/pull/24453.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-24453.patch --]
[-- Type: text/x-diff, Size: 2286 bytes --]

From c1cbbc92ce25db2dc71259fd736d69ca06465b6d Mon Sep 17 00:00:00 2001
From: phire <me@phire.cc>
Date: Mon, 24 Aug 2020 13:38:13 +0200
Subject: [PATCH] New package: r2ghidra-dec-4.5.0

---
 srcpkgs/r2ghidra-dec/template | 38 +++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 srcpkgs/r2ghidra-dec/template

diff --git a/srcpkgs/r2ghidra-dec/template b/srcpkgs/r2ghidra-dec/template
new file mode 100644
index 00000000000..23e7b1f7c75
--- /dev/null
+++ b/srcpkgs/r2ghidra-dec/template
@@ -0,0 +1,38 @@
+# Template file for 'r2ghidra-dec'
+_cutterversion=1.11.1
+_ghidracommit=6c10f36f06468f866188cccf960c019779fb9028
+_pugixmlcommit=fdf02957533645069bbea7cd2ed85a3014b42cf3
+pkgname=r2ghidra-dec
+version=4.5.0
+revision=1
+archs="x86_64*"
+build_style=cmake
+configure_args="-DBUILD_CUTTER_PLUGIN=ON \
+	-DCUTTER_SOURCE_DIR=${XBPS_BUILDDIR}/cutter-${_cutterversion}"
+hostmakedepends="pkg-config cmake bison flex"
+makedepends="radare2 qt5-devel capstone-devel"
+depends="radare2"
+short_desc="Deep ghidra decompiler integration for radare2 and Cutter"
+maintainer="phire <me@phire.cc>"
+license="LGPL-3.0-only"
+homepage="https://github.com/radareorg/r2ghidra-dec"
+distfiles="https://github.com/radareorg/r2ghidra-dec/archive/v${version}.tar.gz
+ https://github.com/radareorg/cutter/archive/v${_cutterversion}.tar.gz
+ https://github.com/thestr4ng3r/ghidra/archive/${_ghidracommit}.tar.gz
+ https://github.com/zeux/pugixml/archive/${_pugixmlcommit}.tar.gz"
+checksum="cca6ed8bc1bf4626bcf8e1fab65e85d1320635f5b5f6903b22d66e376faf5108
+ 07ed1b71a7f4ea8a99aab56839893c1d59aabbf5c8a4ffbd6ecf36bbb00f6ab3
+ f94d81919bddc5f1095250e02b1fdf57acba15e68c818d6c33088875e6759d21
+ cad9cf37ec54bb98b40afc03cd5e2fdc78682fe0f235fd02c575d9b4d9443b83"
+
+post_extract() {
+	mv -T ${XBPS_BUILDDIR}/ghidra-${_ghidracommit} ${wrksrc}/ghidra/ghidra
+	mv -T ${XBPS_BUILDDIR}/pugixml-${_pugixmlcommit} ${wrksrc}/third-party/pugixml
+}
+
+post_install() {
+	mkdir -p ${DESTDIR}/usr/lib/radare2/${version}
+	mv ${DESTDIR}/usr/share/radare2/plugins/*.so ${DESTDIR}/usr/lib/radare2/${version}
+	mkdir -p ${DESTDIR}/usr/lib/RadareOrg/Cutter/plugins/native
+	mv ${DESTDIR}/usr/share/RadareOrg/Cutter/plugins/native/*.so ${DESTDIR}/usr/lib/RadareOrg/Cutter/plugins/native
+}

Re: New package: r2ghidra-dec-4.5.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/24453#issuecomment-1101026396

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: r2ghidra-dec-4.5.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 658 bytes --]

There's a closed pull request on the void-packages repository

New package: r2ghidra-dec-4.5.0
https://github.com/void-linux/void-packages/pull/24453

Description:
See [Issue for Cutter](https://github.com/void-linux/void-packages/issues/21159) but it is instead packaged seperate, like arch does it ([PKGBUILD](https://github.com/archlinux/svntogit-community/blob/packages/r2ghidra-dec/trunk/PKGBUILD)).
The `11-pkglint-elf-in-usrshare.sh` post-install hook fails, but radare2 expects plugins in `/usr/share/radare2/plugins` and Cutter expects them in `/usr/share/RadareOrg/Cutter/plugins`, with the only alternative being `~/.local`, as far as I'm aware.