* Re: [PR PATCH] [Updated] New Package: OpenCoarrays-2.9.2
2021-01-17 21:11 [PR PATCH] New Package: OpenCoarrays-2.9.2 ramos
@ 2021-01-17 21:15 ` ramos
2021-01-17 22:35 ` [PR REVIEW] " ericonr
` (3 subsequent siblings)
4 siblings, 0 replies; 16+ messages in thread
From: ramos @ 2021-01-17 21:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 346 bytes --]
There is an updated pull request by ramos against master on the void-packages repository
https://github.com/ramos/void-packages opencoarrays
https://github.com/void-linux/void-packages/pull/27993
New Package: OpenCoarrays-2.9.2
Hopefully final attempt.
A patch file from https://github.com/void-linux/void-packages/pull/27993.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-opencoarrays-27993.patch --]
[-- Type: text/x-diff, Size: 1184 bytes --]
From e28d92f6e7147f6a3432491decde0225f477af7e Mon Sep 17 00:00:00 2001
From: Alberto Ramos <alberto.ramos@ific.uv.es>
Date: Sun, 17 Jan 2021 22:08:07 +0100
Subject: [PATCH] New Package: OpenCoarrays-2.9.2
---
srcpkgs/OpenCoarrays/template | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 srcpkgs/OpenCoarrays/template
diff --git a/srcpkgs/OpenCoarrays/template b/srcpkgs/OpenCoarrays/template
new file mode 100644
index 00000000000..7c84d3546d7
--- /dev/null
+++ b/srcpkgs/OpenCoarrays/template
@@ -0,0 +1,18 @@
+# Template file for 'OpenCoarrays'
+pkgname=OpenCoarrays
+version=2.9.2
+revision=1
+build_style=cmake
+hostmakedepends="gcc-fortran openmpi"
+makedepends="libgfortran-devel openmpi-devel"
+short_desc="Parallel application binary interface for Fortran 2018 compilers"
+maintainer="Alberto Ramos <alberto.ramos@ific.uv.es>"
+license="BSD-3-Clause"
+homepage="https://opencoarrays.org"
+distfiles="https://github.com/sourceryinstitute/OpenCoarrays/archive/${version}.tar.gz"
+checksum=a11639034ecc2445b6e5efa187ab4fac2b0b384ddae5872d62f717b40922d259
+nocross="openmpi not available on cross build"
+#
+post_install() {
+ vlicense LICENSE
+}
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] New Package: OpenCoarrays-2.9.2
2021-01-17 21:11 [PR PATCH] New Package: OpenCoarrays-2.9.2 ramos
2021-01-17 21:15 ` [PR PATCH] [Updated] " ramos
@ 2021-01-17 22:35 ` ericonr
2021-02-04 6:22 ` ericonr
` (2 subsequent siblings)
4 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-01-17 22:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27993#discussion_r559248811
Comment:
You don't need to specify this, the build system will detect that `openmpi` isn't available when building.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR REVIEW] New Package: OpenCoarrays-2.9.2
2021-01-17 21:11 [PR PATCH] New Package: OpenCoarrays-2.9.2 ramos
2021-01-17 21:15 ` [PR PATCH] [Updated] " ramos
2021-01-17 22:35 ` [PR REVIEW] " ericonr
@ 2021-02-04 6:22 ` ericonr
2022-05-02 2:16 ` github-actions
2022-05-17 2:13 ` [PR PATCH] [Closed]: " github-actions
4 siblings, 0 replies; 16+ messages in thread
From: ericonr @ 2021-02-04 6:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 187 bytes --]
New review comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/27993#discussion_r569973245
Comment:
Shouldn't be a comment, just empty line.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New Package: OpenCoarrays-2.9.2
2021-01-17 21:11 [PR PATCH] New Package: OpenCoarrays-2.9.2 ramos
` (2 preceding siblings ...)
2021-02-04 6:22 ` ericonr
@ 2022-05-02 2:16 ` github-actions
2022-05-17 2:13 ` [PR PATCH] [Closed]: " github-actions
4 siblings, 0 replies; 16+ messages in thread
From: github-actions @ 2022-05-02 2:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/27993#issuecomment-1114433333
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PR PATCH] [Closed]: New Package: OpenCoarrays-2.9.2
2021-01-17 21:11 [PR PATCH] New Package: OpenCoarrays-2.9.2 ramos
` (3 preceding siblings ...)
2022-05-02 2:16 ` github-actions
@ 2022-05-17 2:13 ` github-actions
4 siblings, 0 replies; 16+ messages in thread
From: github-actions @ 2022-05-17 2:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
There's a closed pull request on the void-packages repository
New Package: OpenCoarrays-2.9.2
https://github.com/void-linux/void-packages/pull/27993
Description:
Hopefully final attempt.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: Opencoarrays-2.9.2
2021-01-02 10:14 [PR PATCH] New package: Opencoarrays-2.9.2 ramos
@ 2021-01-09 13:30 ` kawaiiamber
2021-01-09 13:30 ` kawaiiamber
` (8 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2021-01-09 13:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
New comment by kawaiiamber on void-packages repository
https://github.com/void-linux/void-packages/pull/27618#issuecomment-757190498
Comment:
Get rid of line 15 to pass Link check.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: Opencoarrays-2.9.2
2021-01-02 10:14 [PR PATCH] New package: Opencoarrays-2.9.2 ramos
2021-01-09 13:30 ` kawaiiamber
@ 2021-01-09 13:30 ` kawaiiamber
2021-01-16 10:23 ` kawaiiamber
` (7 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2021-01-09 13:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
New comment by kawaiiamber on void-packages repository
https://github.com/void-linux/void-packages/pull/27618#issuecomment-757190498
Comment:
Get rid of line 15 to pass Lint check.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: Opencoarrays-2.9.2
2021-01-02 10:14 [PR PATCH] New package: Opencoarrays-2.9.2 ramos
2021-01-09 13:30 ` kawaiiamber
2021-01-09 13:30 ` kawaiiamber
@ 2021-01-16 10:23 ` kawaiiamber
2021-01-16 10:41 ` kawaiiamber
` (6 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2021-01-16 10:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 823 bytes --]
New comment by kawaiiamber on void-packages repository
https://github.com/void-linux/void-packages/pull/27618#issuecomment-761539910
Comment:
There are three commits, there should only be one. Try squashing your commits with rebase: `git rebase -i HEAD~3` and squash the last two, having the commit message just be "New package: OpenCoarrays-2.9.2", just use `amend` to commit future changes.
```
git commit --amend
git push origin master -f
```
One thing I might recommend while I'm on git things, I would recommend making a specific branch on your fork, e.g.
```
git checkout -b opencoarrays
<add your template>
git add -A
git commit -m "New package: OpenCoarrays-2.9.2"
git push origin opencoarrays
```
then, on this PR, switch to request merging that branch from your fork to the upstream master branch.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: Opencoarrays-2.9.2
2021-01-02 10:14 [PR PATCH] New package: Opencoarrays-2.9.2 ramos
` (2 preceding siblings ...)
2021-01-16 10:23 ` kawaiiamber
@ 2021-01-16 10:41 ` kawaiiamber
2021-01-16 10:48 ` kawaiiamber
` (5 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2021-01-16 10:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
New comment by kawaiiamber on void-packages repository
https://github.com/void-linux/void-packages/pull/27618#issuecomment-761542134
Comment:
Haven't tested, but, from what I've read on upstream's documentation, [this](https://pastebin.com/z4ea1hEu) template might be helpful as a start point.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: Opencoarrays-2.9.2
2021-01-02 10:14 [PR PATCH] New package: Opencoarrays-2.9.2 ramos
` (3 preceding siblings ...)
2021-01-16 10:41 ` kawaiiamber
@ 2021-01-16 10:48 ` kawaiiamber
2021-01-16 10:59 ` kawaiiamber
` (4 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2021-01-16 10:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
New comment by kawaiiamber on void-packages repository
https://github.com/void-linux/void-packages/pull/27618#issuecomment-761542134
Comment:
Haven't tested, but, from what I've read on upstream's documentation, [this](https://pastebin.com/ZcSugsGe) template might be helpful as a start point.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: Opencoarrays-2.9.2
2021-01-02 10:14 [PR PATCH] New package: Opencoarrays-2.9.2 ramos
` (4 preceding siblings ...)
2021-01-16 10:48 ` kawaiiamber
@ 2021-01-16 10:59 ` kawaiiamber
2021-01-16 11:04 ` kawaiiamber
` (3 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2021-01-16 10:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 813 bytes --]
New comment by kawaiiamber on void-packages repository
https://github.com/void-linux/void-packages/pull/27618#issuecomment-761544111
Comment:
I tried testing on aarch64-musl, and found that:
```
=> OpenCoarrays-2.9.2_1: building [cmake] for aarch64-musl...
[host] gcc-fortran-9.3.0_9: found (https://alpha.de.repo.voidlinux.org/current/musl)
[host] openmpi-4.1.0_1: found (https://alpha.de.repo.voidlinux.org/current/musl)
[host] cmake-3.19.3_1: found (https://alpha.de.repo.voidlinux.org/current/musl)
[target] libgfortran-devel-9.3.0_9: found (https://alpha.de.repo.voidlinux.org/current/aarch64)
[target] openmpi-devel-4.1.0_1: not found
```
`openmpi` isn't on cross platform. I have an updated template [here](https://pastebin.com/pZQzpSQB). I don't know much about fortran, though.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: Opencoarrays-2.9.2
2021-01-02 10:14 [PR PATCH] New package: Opencoarrays-2.9.2 ramos
` (5 preceding siblings ...)
2021-01-16 10:59 ` kawaiiamber
@ 2021-01-16 11:04 ` kawaiiamber
2021-01-17 10:29 ` ramos
` (2 subsequent siblings)
9 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2021-01-16 11:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]
New comment by kawaiiamber on void-packages repository
https://github.com/void-linux/void-packages/pull/27618#issuecomment-761544111
Comment:
I tried testing on aarch64-musl, and found that:
```
=> OpenCoarrays-2.9.2_1: building [cmake] for aarch64-musl...
[host] gcc-fortran-9.3.0_9: found (https://alpha.de.repo.voidlinux.org/current/musl)
[host] openmpi-4.1.0_1: found (https://alpha.de.repo.voidlinux.org/current/musl)
[host] cmake-3.19.3_1: found (https://alpha.de.repo.voidlinux.org/current/musl)
[target] libgfortran-devel-9.3.0_9: found (https://alpha.de.repo.voidlinux.org/current/aarch64)
[target] openmpi-devel-4.1.0_1: not found
```
`openmpi` isn't on cross platform. I have an updated template here:
```
# Template file for 'OpenCoarrays'
pkgname=OpenCoarrays
version=2.9.2
revision=1
build_style=cmake
hostmakedepends="gcc-fortran openmpi"
makedepends="libgfortran-devel openmpi-devel"
short_desc="Parallel application binary interface for Fortran 2018 compilers"
maintainer="Alberto Ramos <alberto.ramos@ific.uv.es>"
license="BSD-3-Clause"
homepage="https://opencoarrays.org"
distfiles="https://github.com/sourceryinstitute/OpenCoarrays/archive/${version}.tar.gz"
checksum=a11639034ecc2445b6e5efa187ab4fac2b0b384ddae5872d62f717b40922d259
nocross="openmpi not available on cross build"
post_install() {
vlicense LICENSE
}
```
This passes `xbps-src` locally on my x86_64-musl machine. The `hostmakedepends` and `makedepends` of the template I made could probably be cleaned up a bit, I don't know much about fortran, though.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: Opencoarrays-2.9.2
2021-01-02 10:14 [PR PATCH] New package: Opencoarrays-2.9.2 ramos
` (6 preceding siblings ...)
2021-01-16 11:04 ` kawaiiamber
@ 2021-01-17 10:29 ` ramos
2021-01-17 10:35 ` kawaiiamber
2022-05-02 2:15 ` github-actions
9 siblings, 0 replies; 16+ messages in thread
From: ramos @ 2021-01-17 10:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 274 bytes --]
New comment by ramos on void-packages repository
https://github.com/void-linux/void-packages/pull/27618#issuecomment-761767785
Comment:
Ok, Many thank
Not sure about the conflicts. I have checked that this builds ok in my system with your new template.
Many thanks!
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: Opencoarrays-2.9.2
2021-01-02 10:14 [PR PATCH] New package: Opencoarrays-2.9.2 ramos
` (7 preceding siblings ...)
2021-01-17 10:29 ` ramos
@ 2021-01-17 10:35 ` kawaiiamber
2022-05-02 2:15 ` github-actions
9 siblings, 0 replies; 16+ messages in thread
From: kawaiiamber @ 2021-01-17 10:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 695 bytes --]
New comment by kawaiiamber on void-packages repository
https://github.com/void-linux/void-packages/pull/27618#issuecomment-761768503
Comment:
It looks like you pulled all changes from latest upstream master branch - over 700 commits! You might want to do a couple of things:
1. Add an upstream remote: `git remote add upstream https://github.com/void-linux/void-packages.git`
2. Rebase your branch against upstream master: `git pull --rebase upstream master`
3. Add a branch specifically for your template: `git checkout -b opencoarrays`, then add your template and push there: `git push origin opencoarrays`, switch this PR to merge from that branch rather than your forked master branch.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: New package: Opencoarrays-2.9.2
2021-01-02 10:14 [PR PATCH] New package: Opencoarrays-2.9.2 ramos
` (8 preceding siblings ...)
2021-01-17 10:35 ` kawaiiamber
@ 2022-05-02 2:15 ` github-actions
9 siblings, 0 replies; 16+ messages in thread
From: github-actions @ 2022-05-02 2:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/27618#issuecomment-1114433107
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 16+ messages in thread