[PR PATCH] New package: leftwm-0.3.0

[PR PATCH] New package: leftwm-0.3.0

[uncomfyhalomacro]

[-- Attachment #1: Type: text/plain, Size: 1118 bytes --]

There is a new pull request by uncomfyhalomacro against master on the void-packages repository

https://github.com/uncomfyhalomacro/void-packages leftwm-0.3.0
https://github.com/void-linux/void-packages/pull/36947

New package: leftwm-0.3.0
#### Testing the changes
- I tested the changes in this PR: **NO**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/36947.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-leftwm-0.3.0-36947.patch --]
[-- Type: text/x-diff, Size: 3232 bytes --]

From a842a022d454e8b58e58e8686af368c825d03a87 Mon Sep 17 00:00:00 2001
From: "Soc Virnyl S. Estela" <socvirnyl.estela@gmail.com>
Date: Mon, 2 May 2022 13:49:24 +0800
Subject: [PATCH] New package: leftwm-0.3.0

---
 srcpkgs/leftwm/patches/fix-arm-builds.patch | 31 ---------------------
 srcpkgs/leftwm/patches/series               |  1 -
 srcpkgs/leftwm/template                     |  4 +--
 3 files changed, 2 insertions(+), 34 deletions(-)
 delete mode 100644 srcpkgs/leftwm/patches/fix-arm-builds.patch
 delete mode 100644 srcpkgs/leftwm/patches/series

diff --git a/srcpkgs/leftwm/patches/fix-arm-builds.patch b/srcpkgs/leftwm/patches/fix-arm-builds.patch
deleted file mode 100644
index 9337bc90ec52..000000000000
--- a/srcpkgs/leftwm/patches/fix-arm-builds.patch
+++ /dev/null
@@ -1,31 +0,0 @@
-From 876216bcc0398fb869240cd51d5ea0d12ba699b1 Mon Sep 17 00:00:00 2001
-From: pkubaj <pkubaj@anongoth.pl>
-Date: Tue, 14 Dec 2021 06:37:11 +0000
-Subject: [PATCH] Fix build errors on architectures with u8 (#623)
-
----
- .../src/display_servers/xlib_display_server/xwrap/getters.rs  | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/leftwm-core/src/display_servers/xlib_display_server/xwrap/getters.rs b/leftwm-core/src/display_servers/xlib_display_server/xwrap/getters.rs
-index 2fe20d3a..b8a90495 100644
---- a/leftwm-core/src/display_servers/xlib_display_server/xwrap/getters.rs
-+++ b/leftwm-core/src/display_servers/xlib_display_server/xwrap/getters.rs
-@@ -3,7 +3,7 @@ use super::{Screen, WindowHandle, XlibError, MAX_PROPERTY_VALUE_LEN};
- use crate::models::{DockArea, WindowState, WindowType, XyhwChange};
- use crate::XWrap;
- use std::ffi::CString;
--use std::os::raw::{c_int, c_long, c_uchar, c_uint, c_ulong};
-+use std::os::raw::{c_char, c_int, c_long, c_uchar, c_uint, c_ulong};
- use std::slice;
- use x11_dl::xlib;
- 
-@@ -575,7 +575,7 @@ impl XWrap {
-             if status == 0 {
-                 return Err(XlibError::FailedStatus);
-             }
--            if let Ok(s) = CString::from_raw(text_prop.value.cast::<i8>()).into_string() {
-+            if let Ok(s) = CString::from_raw(text_prop.value.cast::<c_char>()).into_string() {
-                 return Ok(s);
-             }
-         };
diff --git a/srcpkgs/leftwm/patches/series b/srcpkgs/leftwm/patches/series
deleted file mode 100644
index 5f8e5e089321..000000000000
--- a/srcpkgs/leftwm/patches/series
+++ /dev/null
@@ -1 +0,0 @@
-fix-arm-builds.patch
diff --git a/srcpkgs/leftwm/template b/srcpkgs/leftwm/template
index 6da896578e3b..1c416bae1a65 100644
--- a/srcpkgs/leftwm/template
+++ b/srcpkgs/leftwm/template
@@ -1,6 +1,6 @@
 # Template file for 'leftwm'
 pkgname=leftwm
-version=0.2.11
+version=0.3.0
 revision=1
 build_style=cargo
 makedepends="libX11-devel libXinerama-devel libXrandr-devel xorg-server-devel"
@@ -10,7 +10,7 @@ maintainer="Soc Virnyl S. Estela <socvirnyl.estela@gmail.com>"
 license="MIT"
 homepage="https://github.com/leftwm/leftwm"
 distfiles="https://github.com/leftwm/leftwm/archive/${version}.tar.gz"
-checksum=3a2bd59f12566d94b6be3b162c95d280acbaec1b40da415cb42fe07332a5b709
+checksum=d69d3ec8ea49b4a23e145d42a2f66f5c38642378c762919fce6c56b818fad8c7
 
 do_install() {
 	vdoc README.md

Re: New package: leftwm-0.3.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1114522387

Comment:
I think this is an update, not a new package

Re: [PR PATCH] [Updated] leftwm: update to 0.3.0

[uncomfyhalomacro]

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]

There is an updated pull request by uncomfyhalomacro against master on the void-packages repository

https://github.com/uncomfyhalomacro/void-packages leftwm-0.3.0
https://github.com/void-linux/void-packages/pull/36947

leftwm: update to 0.3.0
#### Testing the changes
- I tested the changes in this PR: **NO**


#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/36947.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-leftwm-0.3.0-36947.patch --]
[-- Type: text/x-diff, Size: 3230 bytes --]

From 7e7560c4504d44e6226b3c7d19afc533a35317d9 Mon Sep 17 00:00:00 2001
From: "Soc Virnyl S. Estela" <socvirnyl.estela@gmail.com>
Date: Mon, 2 May 2022 13:49:24 +0800
Subject: [PATCH] leftwm: update to 0.3.0

---
 srcpkgs/leftwm/patches/fix-arm-builds.patch | 31 ---------------------
 srcpkgs/leftwm/patches/series               |  1 -
 srcpkgs/leftwm/template                     |  4 +--
 3 files changed, 2 insertions(+), 34 deletions(-)
 delete mode 100644 srcpkgs/leftwm/patches/fix-arm-builds.patch
 delete mode 100644 srcpkgs/leftwm/patches/series

diff --git a/srcpkgs/leftwm/patches/fix-arm-builds.patch b/srcpkgs/leftwm/patches/fix-arm-builds.patch
deleted file mode 100644
index 9337bc90ec52..000000000000
--- a/srcpkgs/leftwm/patches/fix-arm-builds.patch
+++ /dev/null
@@ -1,31 +0,0 @@
-From 876216bcc0398fb869240cd51d5ea0d12ba699b1 Mon Sep 17 00:00:00 2001
-From: pkubaj <pkubaj@anongoth.pl>
-Date: Tue, 14 Dec 2021 06:37:11 +0000
-Subject: [PATCH] Fix build errors on architectures with u8 (#623)
-
----
- .../src/display_servers/xlib_display_server/xwrap/getters.rs  | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/leftwm-core/src/display_servers/xlib_display_server/xwrap/getters.rs b/leftwm-core/src/display_servers/xlib_display_server/xwrap/getters.rs
-index 2fe20d3a..b8a90495 100644
---- a/leftwm-core/src/display_servers/xlib_display_server/xwrap/getters.rs
-+++ b/leftwm-core/src/display_servers/xlib_display_server/xwrap/getters.rs
-@@ -3,7 +3,7 @@ use super::{Screen, WindowHandle, XlibError, MAX_PROPERTY_VALUE_LEN};
- use crate::models::{DockArea, WindowState, WindowType, XyhwChange};
- use crate::XWrap;
- use std::ffi::CString;
--use std::os::raw::{c_int, c_long, c_uchar, c_uint, c_ulong};
-+use std::os::raw::{c_char, c_int, c_long, c_uchar, c_uint, c_ulong};
- use std::slice;
- use x11_dl::xlib;
- 
-@@ -575,7 +575,7 @@ impl XWrap {
-             if status == 0 {
-                 return Err(XlibError::FailedStatus);
-             }
--            if let Ok(s) = CString::from_raw(text_prop.value.cast::<i8>()).into_string() {
-+            if let Ok(s) = CString::from_raw(text_prop.value.cast::<c_char>()).into_string() {
-                 return Ok(s);
-             }
-         };
diff --git a/srcpkgs/leftwm/patches/series b/srcpkgs/leftwm/patches/series
deleted file mode 100644
index 5f8e5e089321..000000000000
--- a/srcpkgs/leftwm/patches/series
+++ /dev/null
@@ -1 +0,0 @@
-fix-arm-builds.patch
diff --git a/srcpkgs/leftwm/template b/srcpkgs/leftwm/template
index 6da896578e3b..1c416bae1a65 100644
--- a/srcpkgs/leftwm/template
+++ b/srcpkgs/leftwm/template
@@ -1,6 +1,6 @@
 # Template file for 'leftwm'
 pkgname=leftwm
-version=0.2.11
+version=0.3.0
 revision=1
 build_style=cargo
 makedepends="libX11-devel libXinerama-devel libXrandr-devel xorg-server-devel"
@@ -10,7 +10,7 @@ maintainer="Soc Virnyl S. Estela <socvirnyl.estela@gmail.com>"
 license="MIT"
 homepage="https://github.com/leftwm/leftwm"
 distfiles="https://github.com/leftwm/leftwm/archive/${version}.tar.gz"
-checksum=3a2bd59f12566d94b6be3b162c95d280acbaec1b40da415cb42fe07332a5b709
+checksum=d69d3ec8ea49b4a23e145d42a2f66f5c38642378c762919fce6c56b818fad8c7
 
 do_install() {
 	vdoc README.md

Re: leftwm: update to 0.3.0

[uncomfyhalomacro]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

New comment by uncomfyhalomacro on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1114528519

Comment:
> I think this is an update, not a new package



> I think this is an update, not a new package

yeah my bad. all good now

Re: leftwm: update to 0.3.0

[uncomfyhalomacro]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by uncomfyhalomacro on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1114528519

Comment:
> I think this is an update, not a new package

yeah my bad. all good now

Re: leftwm: update to 0.3.0

[uncomfyhalomacro]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by uncomfyhalomacro on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1114529590

Comment:
@0323pin updated to 0.3.0 now :)

Re: leftwm: update to 0.3.0

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1114533224

Comment:
@uncomfyhalomacro Thanks! 0.3.0 is a big improvement and addresses a number of minor annoyances. Looking forward for it to build and have already updated my config files accordingly.

Re: leftwm: update to 0.3.0

[uncomfyhalomacro]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

New comment by uncomfyhalomacro on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1114534808

Comment:
> @uncomfyhalomacro Thanks! 0.3.0 is a big improvement and addresses a number of minor annoyances. Looking forward for it to build and have already updated my config files accordingly.

it builds correctly without the patches. i just have to commit amend it since it is not supposed to be titled as a new package

Re: leftwm: update to 0.3.0

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1114537019

Comment:
@uncomfyhalomacro I'll wait for it, no worries. Appreciated!
On NetBSD, I'll keep running a build from git-HEAD.

Re: leftwm: update to 0.3.0

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1120134190

Comment:
Anything stopping the merge? This release solves quite a few bugs and drops `chrono` which is outdated and has a known CVE.

Re: leftwm: update to 0.3.0

[uncomfyhalomacro]

[-- Attachment #1: Type: text/plain, Size: 334 bytes --]

New comment by uncomfyhalomacro on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1120135780

Comment:
> Anything stopping the merge? This release solves quite a few bugs and drops `chrono` which is outdated and has a known CVE.

idk i guess. u can maybe contact the void maintainers.

Re: leftwm: update to 0.3.0

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 257 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1120137492

Comment:
> idk i guess. u can maybe contact the void maintainers.

Oh sorry, my question was intended to void maintainers.

Re: leftwm: update to 0.3.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1120301672

Comment:
> Anything stopping the merge?

This update was not tested according to the PR description, otherwise, lgtm.

Re: leftwm: update to 0.3.0

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1120358066

Comment:
> This update was not tested according to the PR description, otherwise, lgtm.

Does it mean it won't be merged until someone tests to build and run?

Re: leftwm: update to 0.3.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1120377693

Comment:
> > This update was not tested according to the PR description, otherwise, lgtm.
> 
> Does it mean it won't be merged until someone tests to build and run?

It was build tested by CI, now someone only needs to run test it. In 99% of cases, the PR author tests the update.

Re: leftwm: update to 0.3.0

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1120382152

Comment:
> > > This update was not tested according to the PR description, otherwise, lgtm.
> > 
> > 
> > Does it mean it won't be merged until someone tests to build and run?
> 
> It was build tested by CI, now someone only needs to run test it. In 99% of cases, the PR author tests the update.

I'm rather short of time but, if no one else does it within a week or so, I'll kick a build on my laptop.

Re: leftwm: update to 0.3.0

[uncomfyhalomacro]

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

New comment by uncomfyhalomacro on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1120439840

Comment:
> > This update was not tested according to the PR description, otherwise, lgtm.
> 
> Does it mean it won't be merged until someone tests to build and run?

i will test it in  a day or so. but i have exams and i have to vote tomorrow. sorry. i will try the build it locally as early as possible.

Re: leftwm: update to 0.3.0

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1120450709

Comment:
> > > This update was not tested according to the PR description, otherwise, lgtm.
> > 
> > 
> > Does it mean it won't be merged until someone tests to build and run?
> 
> i will test it in a day or so. but i have exams and i have to vote tomorrow. sorry. i will try the build it locally as early as possible.

No rush, I understand you.

Re: leftwm: update to 0.3.0

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1120473000

Comment:
@uncomfyhalomacro No need to test the pkg, I've done it. Take care and thanks for the update.

@paper42 Built and running on musl x86_64
![2022-05-08-211908_1920x1080_scrot](https://user-images.githubusercontent.com/90570748/167312271-c131cf0f-2fae-48d2-8b95-060f8159171c.png)

Can this merged now?

Re: leftwm: update to 0.3.0

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1120473000

Comment:
@uncomfyhalomacro No need to test the pkg, I've done it. Take care and thanks for the update.

@paper42 Built natively and running on `musl` x86_64

![2022-05-08-211908_1920x1080_scrot](https://user-images.githubusercontent.com/90570748/167312271-c131cf0f-2fae-48d2-8b95-060f8159171c.png)

Can this merged now?

Re: leftwm: update to 0.3.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1120482905

Comment:
> @uncomfyhalomacro No need to test the pkg, I've done it. Take care and thanks for the update.
> Can this merged now?

Sure, thank you for testing

@uncomfyhalomacro good luck!

Re: [PR PATCH] [Merged]: leftwm: update to 0.3.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

There's a merged pull request on the void-packages repository

leftwm: update to 0.3.0
https://github.com/void-linux/void-packages/pull/36947

Description:
#### Testing the changes
- I tested the changes in this PR: **NO**

Re: leftwm: update to 0.3.0

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1120486122

Comment:
@paper42 thanks!

Re: leftwm: update to 0.3.0

[uncomfyhalomacro]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by uncomfyhalomacro on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1120519589

Comment:
> @paper42 thanks!

oh thanks both of u.!

Re: leftwm: update to 0.3.0

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1264682888

Comment:
Any chance to bump this to 0.4.0?
There are major changes, including a built-in hotkey daemon (`lefthk`) and the use of `ron` instead of `toml` for configuration.
I've been running on it for a month or so on NetBSD.
I can test it if someone bumps the template. Thanks 

Re: leftwm: update to 0.3.0

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 410 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1264682888

Comment:
Any chance to bump this to 0.4.0?
There are major changes, including a built-in hotkey daemon (`lefthk`) and the use of `ron` instead of `toml` for configuration.
I've been running it for a month or so on NetBSD.
I can test it if someone bumps the template. Thanks 

Re: leftwm: update to 0.3.0

[uncomfyhalomacro]

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

New comment by uncomfyhalomacro on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1264888997

Comment:
> Any chance to bump this to 0.4.0?
> There are major changes, including a built-in hotkey daemon (`lefthk`) and the use of `ron` instead of `toml` for configuration.
> I've been running it for a month or so on NetBSD.
> I can test it if someone bumps the template. Thanks

yes i will update this later tonight. im waiting for someone to ping me because im too busy huhu.

Re: leftwm: update to 0.3.0

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/36947#issuecomment-1265015585

Comment:
@uncomfyhalomacro Thanks, appreciated.
An heads-up, though.
I've [merged](http://mail-index.netbsd.org/pkgsrc-changes/2022/10/02/msg261412.html) 0.4.0 on NetBSD yesterday, and you need to build with the default features off. Default now includes logging using `journald-log`, which is a systemd-thing.
You will need to build with the equivalent of `cargo build --release --no-default-features --features=lefthk,sys-log`, which in NetBSD world translates into:

```
CARGO_NO_DEFAULT_FEATURES=	YES
CARGO_FEATURES+=		lefthk sys-log
```

So, use whatever is the Voids equivalent to that.
Once again, thanks! I maintain well over a hundred packages for NetBSD and have no time to contribute to Void as well. Even if I use it on another machine.