From: 0x5c <0x5c@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] common/travis/xlint.sh: print Github annotations
Date: Thu, 05 May 2022 04:09:09 +0200 [thread overview]
Message-ID: <20220505020909.qqriucnVxLab_tz-daxe5DL8cwk6PlDjeQUnwblgN_I@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-36950@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
New review comment by 0x5c on void-packages repository
https://github.com/void-linux/void-packages/pull/36950#discussion_r865513293
Comment:
The current behaviour includes the file and line number in the log message, while the annotation would eat it (the file and line only being visible in the form of the inline annotation itself.
There's a couple of options
1. Remove the plain print and make the message of the annotation the same as the raw lint line (the annotation message would contain the filename [and line] even when inline)
2. Keep as is
3. Not change the annotation and remove the raw print (filename [and line] never shown anywhere)
In all 3 the inline annotations are correctly placed
Imo option 3 is fine but I essentially didn't want to "break" the current behaviour without input from reviewers. The duplicated print is easier to notice than the lack of filename[/line] in the log.
next prev parent reply other threads:[~2022-05-05 2:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 8:33 [PR PATCH] " 0x5c
2022-05-04 21:25 ` [PR REVIEW] " Chocimier
2022-05-05 2:09 ` 0x5c [this message]
2022-05-05 15:41 ` Chocimier
2022-05-05 15:51 ` 0x5c
2022-05-05 16:02 ` [PR PATCH] [Updated] " 0x5c
2022-05-05 16:07 ` [PR REVIEW] " 0x5c
2022-05-05 19:34 ` [PR PATCH] [Merged]: " Chocimier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220505020909.qqriucnVxLab_tz-daxe5DL8cwk6PlDjeQUnwblgN_I@z \
--to=0x5c@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).