[PR PATCH] New package: tlpui-1.5.0

[PR PATCH] New package: tlpui-1.5.0

[Visone-Selektah]

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

There is a new pull request by Visone-Selektah against master on the void-packages repository

https://github.com/Visone-Selektah/void-packages tlpui
https://github.com/void-linux/void-packages/pull/36982

New package: tlpui-1.5.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->



- I built this PR locally for my native architecture, x86_64-musl



A patch file from https://github.com/void-linux/void-packages/pull/36982.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tlpui-36982.patch --]
[-- Type: text/x-diff, Size: 1235 bytes --]

From b0977b9f219487ef7141c33ac1b841ce781be8e3 Mon Sep 17 00:00:00 2001
From: Victor Tebar <victortebar@gmail.com>
Date: Wed, 4 May 2022 22:00:36 +0200
Subject: [PATCH] New package: tlpui-1.5.0

---
 srcpkgs/tlpui/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/tlpui/template

diff --git a/srcpkgs/tlpui/template b/srcpkgs/tlpui/template
new file mode 100644
index 000000000000..c83d6537746f
--- /dev/null
+++ b/srcpkgs/tlpui/template
@@ -0,0 +1,24 @@
+# Template file for 'tlpui'
+pkgname=tlpui
+version=1.5.0
+revision=1
+wrksrc="TLPUI-${pkgname}-${version}"
+makedepends="python-setuptools"
+depends="tlp python-gobject"
+short_desc="A GTK user interface for TLP written in Python"
+maintainer="Visone Selektah <victortebar@gmail.com>"
+license="GPL2"
+homepage="https://github.com/d4nj1/TLPUI"
+distfiles="https://github.com/d4nj1/TLPUI/archive/refs/tags/tlpui-1.5.0.tar.gz"
+checksum=37c31f88798c5dc2b7e77e49bcc2ef3d374abb93b2f903b2cd836fbcc5947b9a
+
+
+do_build() {
+    python ./setup.py build
+}
+
+do_install() {
+    export PYTHONHASHSEED=0
+    python setup.py install --root="${DESTDIR}/" --optimize=1 --skip-build
+    vinstall tlpui.desktop 644 usr/share/xsessions
+}

Re: New package: tlpui-1.5.0

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/36982#issuecomment-1117847908

Comment:
We accept no new python 2 packages, use python3 dependencies.
Use build style instead of defining own `do` functions, and fix issues reported by xlint.

Re: [PR REVIEW] New package: tlpui-1.5.0

[abenson]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/36982#discussion_r865350170

Comment:
`GPL-2.0-or-later`

Re: [PR REVIEW] New package: tlpui-1.5.0

[abenson]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/36982#discussion_r865351803

Comment:
This should be `hostmakedepends` instead.  That will fix the cross-build.

Re: [PR PATCH] [Updated] New package: tlpui-1.5.0

[Visone-Selektah]

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

There is an updated pull request by Visone-Selektah against master on the void-packages repository

https://github.com/Visone-Selektah/void-packages tlpui
https://github.com/void-linux/void-packages/pull/36982

New package: tlpui-1.5.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->



- I built this PR locally for my native architecture, x86_64-musl



A patch file from https://github.com/void-linux/void-packages/pull/36982.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tlpui-36982.patch --]
[-- Type: text/x-diff, Size: 2723 bytes --]

From b0977b9f219487ef7141c33ac1b841ce781be8e3 Mon Sep 17 00:00:00 2001
From: Victor Tebar <victortebar@gmail.com>
Date: Wed, 4 May 2022 22:00:36 +0200
Subject: [PATCH 1/2] New package: tlpui-1.5.0

---
 srcpkgs/tlpui/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/tlpui/template

diff --git a/srcpkgs/tlpui/template b/srcpkgs/tlpui/template
new file mode 100644
index 000000000000..c83d6537746f
--- /dev/null
+++ b/srcpkgs/tlpui/template
@@ -0,0 +1,24 @@
+# Template file for 'tlpui'
+pkgname=tlpui
+version=1.5.0
+revision=1
+wrksrc="TLPUI-${pkgname}-${version}"
+makedepends="python-setuptools"
+depends="tlp python-gobject"
+short_desc="A GTK user interface for TLP written in Python"
+maintainer="Visone Selektah <victortebar@gmail.com>"
+license="GPL2"
+homepage="https://github.com/d4nj1/TLPUI"
+distfiles="https://github.com/d4nj1/TLPUI/archive/refs/tags/tlpui-1.5.0.tar.gz"
+checksum=37c31f88798c5dc2b7e77e49bcc2ef3d374abb93b2f903b2cd836fbcc5947b9a
+
+
+do_build() {
+    python ./setup.py build
+}
+
+do_install() {
+    export PYTHONHASHSEED=0
+    python setup.py install --root="${DESTDIR}/" --optimize=1 --skip-build
+    vinstall tlpui.desktop 644 usr/share/xsessions
+}

From 3e889cceb3d17a012491a13b587926f8b76d7a47 Mon Sep 17 00:00:00 2001
From: Victor Tebar <victortebar@gmail.com>
Date: Wed, 4 May 2022 22:50:34 +0200
Subject: [PATCH 2/2] tlpui: fix errors and add build_style

---
 srcpkgs/tlpui/template | 23 +++++++----------------
 1 file changed, 7 insertions(+), 16 deletions(-)

diff --git a/srcpkgs/tlpui/template b/srcpkgs/tlpui/template
index c83d6537746f..3119444f6543 100644
--- a/srcpkgs/tlpui/template
+++ b/srcpkgs/tlpui/template
@@ -3,22 +3,13 @@ pkgname=tlpui
 version=1.5.0
 revision=1
 wrksrc="TLPUI-${pkgname}-${version}"
-makedepends="python-setuptools"
-depends="tlp python-gobject"
-short_desc="A GTK user interface for TLP written in Python"
+build_style="python3-module"
+hostmakedepends="python3-setuptools"
+depends="tlp python3-gobject"
+short_desc="GTK user interface for TLP written in Python"
 maintainer="Visone Selektah <victortebar@gmail.com>"
-license="GPL2"
+license="GPL-2.0-or-later"
 homepage="https://github.com/d4nj1/TLPUI"
-distfiles="https://github.com/d4nj1/TLPUI/archive/refs/tags/tlpui-1.5.0.tar.gz"
+distfiles="https://github.com/d4nj1/TLPUI/archive/refs/tags/tlpui-${version}.tar.gz"
 checksum=37c31f88798c5dc2b7e77e49bcc2ef3d374abb93b2f903b2cd836fbcc5947b9a
-
-
-do_build() {
-    python ./setup.py build
-}
-
-do_install() {
-    export PYTHONHASHSEED=0
-    python setup.py install --root="${DESTDIR}/" --optimize=1 --skip-build
-    vinstall tlpui.desktop 644 usr/share/xsessions
-}
+make_check=no

Re: [PR REVIEW] New package: tlpui-1.5.0

[Visone-Selektah]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New review comment by Visone-Selektah on void-packages repository

https://github.com/void-linux/void-packages/pull/36982#discussion_r865373681

Comment:
It's my first time, thanks for the points!

Re: [PR REVIEW] New package: tlpui-1.5.0

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/36982#discussion_r865414645

Comment:
gtk+3 in depends and `checkdepends="${depends}"` takes tests till `Gtk-WARNING **: cannot open display:` that is fixable too

Re: New package: tlpui-1.5.0

[Visone-Selektah]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

New comment by Visone-Selektah on void-packages repository

https://github.com/void-linux/void-packages/pull/36982#issuecomment-1119400304

Comment:
I can't find any way to fix the Display error so, I'm gonna close this PR and will make it again when I have it all figure it out.
Thanks 4 the help!!

Re: [PR PATCH] [Closed]: New package: tlpui-1.5.0

[Visone-Selektah]

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

There's a closed pull request on the void-packages repository

New package: tlpui-1.5.0
https://github.com/void-linux/void-packages/pull/36982

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->



- I built this PR locally for my native architecture, x86_64-musl

Re: New package: tlpui-1.5.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 420 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36982#issuecomment-1119408432

Comment:
> I can't find any way to fix the Display error so, I'm gonna close this PR and will make it again when I have it all figure it out. Thanks 4 the help!!

add `xvfb-run` to `$checkdepends` and set `make_check_pre="xvfb-run"` and please don't open a new PR, just reopen this one

Re: [PR PATCH] [Updated] New package: tlpui-1.5.0

[Visone-Selektah]

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

There is an updated pull request by Visone-Selektah against master on the void-packages repository

https://github.com/Visone-Selektah/void-packages tlpui
https://github.com/void-linux/void-packages/pull/36982

New package: tlpui-1.5.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->



- I built this PR locally for my native architecture, x86_64-musl



A patch file from https://github.com/void-linux/void-packages/pull/36982.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tlpui-36982.patch --]
[-- Type: text/x-diff, Size: 3810 bytes --]

From b0977b9f219487ef7141c33ac1b841ce781be8e3 Mon Sep 17 00:00:00 2001
From: Victor Tebar <victortebar@gmail.com>
Date: Wed, 4 May 2022 22:00:36 +0200
Subject: [PATCH 1/3] New package: tlpui-1.5.0

---
 srcpkgs/tlpui/template | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 srcpkgs/tlpui/template

diff --git a/srcpkgs/tlpui/template b/srcpkgs/tlpui/template
new file mode 100644
index 000000000000..c83d6537746f
--- /dev/null
+++ b/srcpkgs/tlpui/template
@@ -0,0 +1,24 @@
+# Template file for 'tlpui'
+pkgname=tlpui
+version=1.5.0
+revision=1
+wrksrc="TLPUI-${pkgname}-${version}"
+makedepends="python-setuptools"
+depends="tlp python-gobject"
+short_desc="A GTK user interface for TLP written in Python"
+maintainer="Visone Selektah <victortebar@gmail.com>"
+license="GPL2"
+homepage="https://github.com/d4nj1/TLPUI"
+distfiles="https://github.com/d4nj1/TLPUI/archive/refs/tags/tlpui-1.5.0.tar.gz"
+checksum=37c31f88798c5dc2b7e77e49bcc2ef3d374abb93b2f903b2cd836fbcc5947b9a
+
+
+do_build() {
+    python ./setup.py build
+}
+
+do_install() {
+    export PYTHONHASHSEED=0
+    python setup.py install --root="${DESTDIR}/" --optimize=1 --skip-build
+    vinstall tlpui.desktop 644 usr/share/xsessions
+}

From 3e889cceb3d17a012491a13b587926f8b76d7a47 Mon Sep 17 00:00:00 2001
From: Victor Tebar <victortebar@gmail.com>
Date: Wed, 4 May 2022 22:50:34 +0200
Subject: [PATCH 2/3] tlpui: fix errors and add build_style

---
 srcpkgs/tlpui/template | 23 +++++++----------------
 1 file changed, 7 insertions(+), 16 deletions(-)

diff --git a/srcpkgs/tlpui/template b/srcpkgs/tlpui/template
index c83d6537746f..3119444f6543 100644
--- a/srcpkgs/tlpui/template
+++ b/srcpkgs/tlpui/template
@@ -3,22 +3,13 @@ pkgname=tlpui
 version=1.5.0
 revision=1
 wrksrc="TLPUI-${pkgname}-${version}"
-makedepends="python-setuptools"
-depends="tlp python-gobject"
-short_desc="A GTK user interface for TLP written in Python"
+build_style="python3-module"
+hostmakedepends="python3-setuptools"
+depends="tlp python3-gobject"
+short_desc="GTK user interface for TLP written in Python"
 maintainer="Visone Selektah <victortebar@gmail.com>"
-license="GPL2"
+license="GPL-2.0-or-later"
 homepage="https://github.com/d4nj1/TLPUI"
-distfiles="https://github.com/d4nj1/TLPUI/archive/refs/tags/tlpui-1.5.0.tar.gz"
+distfiles="https://github.com/d4nj1/TLPUI/archive/refs/tags/tlpui-${version}.tar.gz"
 checksum=37c31f88798c5dc2b7e77e49bcc2ef3d374abb93b2f903b2cd836fbcc5947b9a
-
-
-do_build() {
-    python ./setup.py build
-}
-
-do_install() {
-    export PYTHONHASHSEED=0
-    python setup.py install --root="${DESTDIR}/" --optimize=1 --skip-build
-    vinstall tlpui.desktop 644 usr/share/xsessions
-}
+make_check=no

From e5e9262cac4df050a5c40ad6de27fca8432bf53c Mon Sep 17 00:00:00 2001
From: Victor Tebar <victortebar@gmail.com>
Date: Fri, 6 May 2022 12:06:34 +0200
Subject: [PATCH 3/3] tlpui: fix 'cannot open display' error

---
 srcpkgs/tlpui/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/tlpui/template b/srcpkgs/tlpui/template
index 3119444f6543..f36637637d14 100644
--- a/srcpkgs/tlpui/template
+++ b/srcpkgs/tlpui/template
@@ -5,11 +5,12 @@ revision=1
 wrksrc="TLPUI-${pkgname}-${version}"
 build_style="python3-module"
 hostmakedepends="python3-setuptools"
-depends="tlp python3-gobject"
+depends="gtk+3 tlp python3-gobject "
+checkdepends="xvfb-run ${depends}"
 short_desc="GTK user interface for TLP written in Python"
 maintainer="Visone Selektah <victortebar@gmail.com>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/d4nj1/TLPUI"
 distfiles="https://github.com/d4nj1/TLPUI/archive/refs/tags/tlpui-${version}.tar.gz"
 checksum=37c31f88798c5dc2b7e77e49bcc2ef3d374abb93b2f903b2cd836fbcc5947b9a
-make_check=no
+make_check_pre="xvfb-run"

Re: New package: tlpui-1.5.0

[Visone-Selektah]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New comment by Visone-Selektah on void-packages repository

https://github.com/void-linux/void-packages/pull/36982#issuecomment-1119458514

Comment:
Thank you all for your help!

Re: [PR REVIEW] New package: tlpui-1.5.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/36982#discussion_r867393471

Comment:
```suggestion
depends="gtk+3 tlp python3-gobject"
```
just a tiny mistake

Re: New package: tlpui-1.5.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/36982#issuecomment-1207316047

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: New package: tlpui-1.5.0

[motorto]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New comment by motorto on void-packages repository

https://github.com/void-linux/void-packages/pull/36982#issuecomment-1207980337

Comment:
@Visone-Selektah your package is working, just need to clean that extra space and maybe bump it to the last 1.5.0-5. 

Re: New package: tlpui-1.5.0

[Visone-Selektah]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New comment by Visone-Selektah on void-packages repository

https://github.com/void-linux/void-packages/pull/36982#issuecomment-1239130890

Comment:
Hi!
Sorry for the silent, I didn't see the notification.
I'll close this PR, you already send a new one with the new version.

Re: New package: tlpui-1.5.0

[Visone-Selektah]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New comment by Visone-Selektah on void-packages repository

https://github.com/void-linux/void-packages/pull/36982#issuecomment-1239131564

Comment:
New PR was send with the latest version

Re: [PR PATCH] [Closed]: New package: tlpui-1.5.0

[Visone-Selektah]

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

There's a closed pull request on the void-packages repository

New package: tlpui-1.5.0
https://github.com/void-linux/void-packages/pull/36982

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: YES

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->



- I built this PR locally for my native architecture, x86_64-musl