[PR PATCH] New package: walk-1.0.0

[PR PATCH] New package: walk-1.0.0

[anddam]

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

There is a new pull request by anddam against master on the void-packages repository

https://github.com/anddam/void-packages feature/new-package-walk
https://github.com/void-linux/void-packages/pull/37244

New package: walk-1.0.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


This follows [PR28273](https://github.com/void-linux/void-packages/pull/28273).

A patch file from https://github.com/void-linux/void-packages/pull/37244.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature/new-package-walk-37244.patch --]
[-- Type: text/x-diff, Size: 1019 bytes --]

From df7a2f3af1df934138bed95a8de0979bf85f0370 Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 27 Oct 2020 10:18:43 +0100
Subject: [PATCH] New package: walk-1.0.0

---
 srcpkgs/walk/template | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 srcpkgs/walk/template

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
new file mode 100644
index 000000000000..8fdd3952fa54
--- /dev/null
+++ b/srcpkgs/walk/template
@@ -0,0 +1,13 @@
+# Template file for 'walk'
+pkgname=walk
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+make_install_args="prefix=/destdir/${pkgname}-${version}/usr"
+hostmakedepends="gzip make"
+short_desc="Two utilities collectively replacing find: walk and sor"
+maintainer="Andrea D'Amore <a@d-amo.re>"
+license="Apache-2.0"
+homepage=https://git.benjamin.barenblat.name/walk/
+distfiles="https://github.com/bbarenblat/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=7d733cc106ca81390197f772efd4243ab798fe12ee7de30ceec3ce92cb762375

Re: [PR PATCH] [Updated] New package: walk-1.0.0

[anddam]

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

There is an updated pull request by anddam against master on the void-packages repository

https://github.com/anddam/void-packages feature/new-package-walk
https://github.com/void-linux/void-packages/pull/37244

New package: walk-1.0.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


This follows [PR28273](https://github.com/void-linux/void-packages/pull/28273).

A patch file from https://github.com/void-linux/void-packages/pull/37244.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature/new-package-walk-37244.patch --]
[-- Type: text/x-diff, Size: 1026 bytes --]

From b210a9cbdf8d0ee5b00fcce8daf15407be08d7fe Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 27 Oct 2020 10:18:43 +0100
Subject: [PATCH] New package: walk-1.0.0

---
 srcpkgs/walk/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/walk/template

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
new file mode 100644
index 000000000000..e574cb7b5804
--- /dev/null
+++ b/srcpkgs/walk/template
@@ -0,0 +1,16 @@
+# Template file for 'walk'
+pkgname=walk
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+hostmakedepends="gzip make"
+short_desc="Two utilities collectively replacing find: walk and sor"
+maintainer="Andrea D'Amore <a@d-amo.re>"
+license="Apache-2.0"
+homepage=https://git.benjamin.barenblat.name/walk/
+distfiles="https://github.com/bbarenblat/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=7d733cc106ca81390197f772efd4243ab798fe12ee7de30ceec3ce92cb762375
+
+pre_install() {
+  make_install_args="prefix=${DESTDIR}/usr"
+}

Re: [PR PATCH] [Updated] New package: walk-1.0.0

[anddam]

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

There is an updated pull request by anddam against master on the void-packages repository

https://github.com/anddam/void-packages feature/new-package-walk
https://github.com/void-linux/void-packages/pull/37244

New package: walk-1.0.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


This follows [PR28273](https://github.com/void-linux/void-packages/pull/28273).

A patch file from https://github.com/void-linux/void-packages/pull/37244.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature/new-package-walk-37244.patch --]
[-- Type: text/x-diff, Size: 1025 bytes --]

From 4ce5b3eff6e23fbd9565d220392f554b9eadb4e2 Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 27 Oct 2020 10:18:43 +0100
Subject: [PATCH] New package: walk-1.0.0

---
 srcpkgs/walk/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/walk/template

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
new file mode 100644
index 000000000000..4bffc8290b82
--- /dev/null
+++ b/srcpkgs/walk/template
@@ -0,0 +1,16 @@
+# Template file for 'walk'
+pkgname=walk
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+hostmakedepends="gzip make"
+short_desc="Two utilities collectively replacing find: walk and sor"
+maintainer="Andrea D'Amore <a@d-amo.re>"
+license="Apache-2.0"
+homepage=https://git.benjamin.barenblat.name/walk/
+distfiles="https://github.com/bbarenblat/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=7d733cc106ca81390197f772efd4243ab798fe12ee7de30ceec3ce92cb762375
+
+pre_install() {
+	make_install_args="prefix=${DESTDIR}/usr"
+}

Re: [PR REVIEW] New package: walk-1.0.0

[abenson]

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/37244#discussion_r879994837

Comment:
Add quotes

Re: [PR REVIEW] New package: walk-1.0.0

[anddam]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New review comment by anddam on void-packages repository

https://github.com/void-linux/void-packages/pull/37244#discussion_r880121309

Comment:
How so?

`homepage` does not contain IFS, no accompanying file mentions having to quote it.

Re: [PR REVIEW] New package: walk-1.0.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37244#discussion_r880148383

Comment:
It's not required, but almost every other template does it, so let's be consistent

Re: [PR PATCH] [Updated] New package: walk-1.0.0

[anddam]

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

There is an updated pull request by anddam against master on the void-packages repository

https://github.com/anddam/void-packages feature/new-package-walk
https://github.com/void-linux/void-packages/pull/37244

New package: walk-1.0.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


This follows [PR28273](https://github.com/void-linux/void-packages/pull/28273).

A patch file from https://github.com/void-linux/void-packages/pull/37244.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature/new-package-walk-37244.patch --]
[-- Type: text/x-diff, Size: 2024 bytes --]

From 4ce5b3eff6e23fbd9565d220392f554b9eadb4e2 Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 27 Oct 2020 10:18:43 +0100
Subject: [PATCH 1/2] New package: walk-1.0.0

---
 srcpkgs/walk/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/walk/template

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
new file mode 100644
index 000000000000..4bffc8290b82
--- /dev/null
+++ b/srcpkgs/walk/template
@@ -0,0 +1,16 @@
+# Template file for 'walk'
+pkgname=walk
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+hostmakedepends="gzip make"
+short_desc="Two utilities collectively replacing find: walk and sor"
+maintainer="Andrea D'Amore <a@d-amo.re>"
+license="Apache-2.0"
+homepage=https://git.benjamin.barenblat.name/walk/
+distfiles="https://github.com/bbarenblat/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=7d733cc106ca81390197f772efd4243ab798fe12ee7de30ceec3ce92cb762375
+
+pre_install() {
+	make_install_args="prefix=${DESTDIR}/usr"
+}

From 3e45d77444403805e9b85039bd2f5db2c44bd791 Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 24 May 2022 11:51:25 +0200
Subject: [PATCH 2/2] Quote homepage variable

This was requested in [1].

[1]: https://github.com/void-linux/void-packages/pull/37244#pullrequestreview-982510819
---
 srcpkgs/walk/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
index 4bffc8290b82..85354a5a796a 100644
--- a/srcpkgs/walk/template
+++ b/srcpkgs/walk/template
@@ -7,7 +7,7 @@ hostmakedepends="gzip make"
 short_desc="Two utilities collectively replacing find: walk and sor"
 maintainer="Andrea D'Amore <a@d-amo.re>"
 license="Apache-2.0"
-homepage=https://git.benjamin.barenblat.name/walk/
+homepage="https://git.benjamin.barenblat.name/walk/"
 distfiles="https://github.com/bbarenblat/${pkgname}/archive/refs/tags/v${version}.tar.gz"
 checksum=7d733cc106ca81390197f772efd4243ab798fe12ee7de30ceec3ce92cb762375
 

Re: [PR REVIEW] New package: walk-1.0.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37244#discussion_r880411603

Comment:
can this line be in the main block of variables - outside of this function?

Re: [PR REVIEW] New package: walk-1.0.0

[anddam]

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

New review comment by anddam on void-packages repository

https://github.com/void-linux/void-packages/pull/37244#discussion_r880787820

Comment:
Maybe. But I wasn't able to build on ARM archs while setting make_install_args at root level since `DESTDIR` embeds the cross-compiler into the path and I could figure how to access it at root level.

Re: [PR PATCH] [Updated] New package: walk-1.0.0

[anddam]

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

There is an updated pull request by anddam against master on the void-packages repository

https://github.com/anddam/void-packages feature/new-package-walk
https://github.com/void-linux/void-packages/pull/37244

New package: walk-1.0.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


This follows [PR28273](https://github.com/void-linux/void-packages/pull/28273).

A patch file from https://github.com/void-linux/void-packages/pull/37244.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature/new-package-walk-37244.patch --]
[-- Type: text/x-diff, Size: 1027 bytes --]

From ad7e3f0616acc8f046ad363691f3dc383c60e89b Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 27 Oct 2020 10:18:43 +0100
Subject: [PATCH] New package: walk-1.0.0

---
 srcpkgs/walk/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/walk/template

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
new file mode 100644
index 000000000000..85354a5a796a
--- /dev/null
+++ b/srcpkgs/walk/template
@@ -0,0 +1,16 @@
+# Template file for 'walk'
+pkgname=walk
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+hostmakedepends="gzip make"
+short_desc="Two utilities collectively replacing find: walk and sor"
+maintainer="Andrea D'Amore <a@d-amo.re>"
+license="Apache-2.0"
+homepage="https://git.benjamin.barenblat.name/walk/"
+distfiles="https://github.com/bbarenblat/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=7d733cc106ca81390197f772efd4243ab798fe12ee7de30ceec3ce92cb762375
+
+pre_install() {
+	make_install_args="prefix=${DESTDIR}/usr"
+}

Re: [PR REVIEW] New package: walk-1.0.0

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/37244#discussion_r880790576

Comment:
Possibly by quoting special character `$` like in `srcpkgs/9mount/template`.

Re: [PR PATCH] [Updated] New package: walk-1.0.0

[anddam]

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

There is an updated pull request by anddam against master on the void-packages repository

https://github.com/anddam/void-packages feature/new-package-walk
https://github.com/void-linux/void-packages/pull/37244

New package: walk-1.0.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


This follows [PR28273](https://github.com/void-linux/void-packages/pull/28273).

A patch file from https://github.com/void-linux/void-packages/pull/37244.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature/new-package-walk-37244.patch --]
[-- Type: text/x-diff, Size: 1001 bytes --]

From f044f6d5c9bc013d20b2fdb497ccb851f57639f1 Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 27 Oct 2020 10:18:43 +0100
Subject: [PATCH] New package: walk-1.0.0

---
 srcpkgs/walk/template | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 srcpkgs/walk/template

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
new file mode 100644
index 000000000000..de4b1e501413
--- /dev/null
+++ b/srcpkgs/walk/template
@@ -0,0 +1,13 @@
+# Template file for 'walk'
+pkgname=walk
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+make_install_args='prefix=${DESTDIR}/usr'
+hostmakedepends="gzip make"
+short_desc="Two utilities collectively replacing find: walk and sor"
+maintainer="Andrea D'Amore <a@d-amo.re>"
+license="Apache-2.0"
+homepage="https://git.benjamin.barenblat.name/walk/"
+distfiles="https://github.com/bbarenblat/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=7d733cc106ca81390197f772efd4243ab798fe12ee7de30ceec3ce92cb762375

Re: [PR REVIEW] New package: walk-1.0.0

[anddam]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

New review comment by anddam on void-packages repository

https://github.com/void-linux/void-packages/pull/37244#discussion_r880802343

Comment:
> Possibly by quoting special character `$` like in `srcpkgs/9mount/template`.

Oh, right. I see why that was not available.

I will single quote the string to prevent expansion, then.

Thanks.

Re: [PR REVIEW] New package: walk-1.0.0

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/37244#discussion_r881046310

Comment:
Which of the two sites is authoritative? There's no value in having one git webserver listed as a homepage and another providing distfiles. Point the homepage to the authoritative repo page and get the distfile from that.

Re: [PR REVIEW] New package: walk-1.0.0

[anddam]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

New review comment by anddam on void-packages repository

https://github.com/void-linux/void-packages/pull/37244#discussion_r881289635

Comment:
>Which of the two sites is authoritative?  

Main website is on `barenblat.name` domain, the github project mirrors the former.

>There's no value in having one git webserver listed as a homepage and another providing distfiles

There's the value that github offers automated archive downloads, cgit apparently does not.
If you are able to find an archive on a cgit page, please do tell.

I figured fetching an archive was still better than installing from git.

Re: [PR REVIEW] New package: walk-1.0.0

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/37244#discussion_r881530292

Comment:
If the cgit site doesn't offer snapshots, then make `homepage` the GitHub repo. If the homepage is just going to be a front-end to a repository and an option to view a README, it might as well point to the actual tree you're fetching. 

Re: [PR PATCH] [Updated] New package: walk-1.0.0

[anddam]

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

There is an updated pull request by anddam against master on the void-packages repository

https://github.com/anddam/void-packages feature/new-package-walk
https://github.com/void-linux/void-packages/pull/37244

New package: walk-1.0.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


This follows [PR28273](https://github.com/void-linux/void-packages/pull/28273).

A patch file from https://github.com/void-linux/void-packages/pull/37244.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature/new-package-walk-37244.patch --]
[-- Type: text/x-diff, Size: 1020 bytes --]

From 5904c14d955f7b3ccd95d1a083cc0bd9eafbfd7c Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 27 Oct 2020 10:18:43 +0100
Subject: [PATCH] New package: walk-1.0.0

---
 srcpkgs/walk/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/walk/template

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
new file mode 100644
index 000000000000..d41ff8305e88
--- /dev/null
+++ b/srcpkgs/walk/template
@@ -0,0 +1,16 @@
+# Template file for 'walk'
+pkgname=walk
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+hostmakedepends="gzip make"
+short_desc="Two utilities collectively replacing find: walk and sor"
+maintainer="Andrea D'Amore <a@d-amo.re>"
+license="Apache-2.0"
+homepage="https://github.com/bbarenblat/walk"
+distfiles="https://github.com/bbarenblat/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=7d733cc106ca81390197f772efd4243ab798fe12ee7de30ceec3ce92cb762375
+
+pre_install() {
+	make_install_args="prefix=${DESTDIR}/usr"
+}

Re: [PR PATCH] [Updated] New package: walk-1.0.0

[anddam]

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

There is an updated pull request by anddam against master on the void-packages repository

https://github.com/anddam/void-packages feature/new-package-walk
https://github.com/void-linux/void-packages/pull/37244

New package: walk-1.0.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


This follows [PR28273](https://github.com/void-linux/void-packages/pull/28273).

A patch file from https://github.com/void-linux/void-packages/pull/37244.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature/new-package-walk-37244.patch --]
[-- Type: text/x-diff, Size: 1020 bytes --]

From 43222d09c1c4992574c0e0dd169ef8b9b4c6f248 Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 27 Oct 2020 10:18:43 +0100
Subject: [PATCH] New package: walk-1.0.0

---
 srcpkgs/walk/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/walk/template

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
new file mode 100644
index 000000000000..d41ff8305e88
--- /dev/null
+++ b/srcpkgs/walk/template
@@ -0,0 +1,16 @@
+# Template file for 'walk'
+pkgname=walk
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+hostmakedepends="gzip make"
+short_desc="Two utilities collectively replacing find: walk and sor"
+maintainer="Andrea D'Amore <a@d-amo.re>"
+license="Apache-2.0"
+homepage="https://github.com/bbarenblat/walk"
+distfiles="https://github.com/bbarenblat/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=7d733cc106ca81390197f772efd4243ab798fe12ee7de30ceec3ce92cb762375
+
+pre_install() {
+	make_install_args="prefix=${DESTDIR}/usr"
+}

Re: New package: walk-1.0.0

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/37244#issuecomment-1140165465

Comment:
Does this need to be rebased to work? I have no idea what's going on with those errors.

Re: [PR PATCH] [Updated] New package: walk-1.0.0

[anddam]

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

There is an updated pull request by anddam against master on the void-packages repository

https://github.com/anddam/void-packages feature/new-package-walk
https://github.com/void-linux/void-packages/pull/37244

New package: walk-1.0.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


This follows [PR28273](https://github.com/void-linux/void-packages/pull/28273).

A patch file from https://github.com/void-linux/void-packages/pull/37244.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature/new-package-walk-37244.patch --]
[-- Type: text/x-diff, Size: 1020 bytes --]

From d094f66e3340ae001894c6d5dbdeef98f029aa71 Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 27 Oct 2020 10:18:43 +0100
Subject: [PATCH] New package: walk-1.0.0

---
 srcpkgs/walk/template | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 srcpkgs/walk/template

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
new file mode 100644
index 000000000000..d41ff8305e88
--- /dev/null
+++ b/srcpkgs/walk/template
@@ -0,0 +1,16 @@
+# Template file for 'walk'
+pkgname=walk
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+hostmakedepends="gzip make"
+short_desc="Two utilities collectively replacing find: walk and sor"
+maintainer="Andrea D'Amore <a@d-amo.re>"
+license="Apache-2.0"
+homepage="https://github.com/bbarenblat/walk"
+distfiles="https://github.com/bbarenblat/${pkgname}/archive/refs/tags/v${version}.tar.gz"
+checksum=7d733cc106ca81390197f772efd4243ab798fe12ee7de30ceec3ce92cb762375
+
+pre_install() {
+	make_install_args="prefix=${DESTDIR}/usr"
+}

Re: New package: walk-1.0.0

[anddam]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

New comment by anddam on void-packages repository

https://github.com/void-linux/void-packages/pull/37244#issuecomment-1140336003

Comment:
> Does this need to be rebased to work? I have no idea what's going on with those errors.

I think now it just needs the change request to be lifted, then accept the PR.

Re: [PR REVIEW] New package: walk-1.0.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37244#discussion_r884228830

Comment:
Bump, can this be done?

Re: [PR REVIEW] New package: walk-1.0.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/37244#discussion_r884228869

Comment:
```suggestion
distfiles="https://github.com/bbarenblat/walk/archive/refs/tags/v${version}.tar.gz"
```

Re: [PR PATCH] [Updated] New package: walk-1.0.0

[anddam]

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

There is an updated pull request by anddam against master on the void-packages repository

https://github.com/anddam/void-packages feature/new-package-walk
https://github.com/void-linux/void-packages/pull/37244

New package: walk-1.0.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


This follows [PR28273](https://github.com/void-linux/void-packages/pull/28273).

A patch file from https://github.com/void-linux/void-packages/pull/37244.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-feature/new-package-walk-37244.patch --]
[-- Type: text/x-diff, Size: 988 bytes --]

From e89ec0cb5b933cff48b7dd2420db7092de9edd42 Mon Sep 17 00:00:00 2001
From: Andrea D'Amore <a@d-amo.re>
Date: Tue, 27 Oct 2020 10:18:43 +0100
Subject: [PATCH] New package: walk-1.0.0

---
 srcpkgs/walk/template | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 srcpkgs/walk/template

diff --git a/srcpkgs/walk/template b/srcpkgs/walk/template
new file mode 100644
index 000000000000..8cf30e63c9de
--- /dev/null
+++ b/srcpkgs/walk/template
@@ -0,0 +1,13 @@
+# Template file for 'walk'
+pkgname=walk
+version=1.0.0
+revision=1
+build_style=gnu-makefile
+make_install_args='prefix=${DESTDIR}/usr'
+hostmakedepends="gzip make"
+short_desc="Two utilities collectively replacing find: walk and sor"
+maintainer="Andrea D'Amore <a@d-amo.re>"
+license="Apache-2.0"
+homepage="https://github.com/bbarenblat/walk"
+distfiles="https://github.com/bbarenblat/walk/archive/refs/tags/v${version}.tar.gz"
+checksum=7d733cc106ca81390197f772efd4243ab798fe12ee7de30ceec3ce92cb762375

Re: [PR REVIEW] New package: walk-1.0.0

[anddam]

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

New review comment by anddam on void-packages repository

https://github.com/void-linux/void-packages/pull/37244#discussion_r884274179

Comment:
Now I think you guys are just making stuff up to mess with me.

Good thing you stopped flow on this, though, since I had inadvertently reverted the `make_install_args` change (made the changes on another computer).

Re: [PR PATCH] [Merged]: New package: walk-1.0.0

[paper42]

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

There's a merged pull request on the void-packages repository

New package: walk-1.0.0
https://github.com/void-linux/void-packages/pull/37244

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


This follows [PR28273](https://github.com/void-linux/void-packages/pull/28273).