[ISSUE] mtxclient causes nheko to segfault

[ISSUE] mtxclient causes nheko to segfault

[RunningDroid]

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

New issue by RunningDroid on void-packages repository

https://github.com/void-linux/void-packages/issues/37442

Description:
<!-- Don't request update of package. We have a script for that. https://repo-default.voidlinux.org/void-updates/void-updates.txt. However, a quality pull request may help. -->
### System

* xuname:  
  Void 5.15.45_1 x86_64 GenuineIntel uptodate rrmFFFFFFFFFFFFFFFF
* package:  
  mtxclient-0.7.0_1
  nheko-0.9.2_2

### Expected behavior
Not segfaulting when viewing a room in nheko

### Actual behavior
Segfaulting when viewing a room in nheko

### Steps to reproduce the behavior
1. launch nheko
2. try to view a room

Rebuilding mtxclient fixes this, but as near as I can tell the only dependency that's been updated is [openssl](https://github.com/void-linux/void-packages/commit/134c645bd4fd68c6669f917a10a4bd7e6df7fd0e) so I don't know why it fixes it.

Related: Nheko-Reborn/nheko#1083

Re: mtxclient causes nheko to segfault

[balejk]

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

New comment by balejk on void-packages repository

https://github.com/void-linux/void-packages/issues/37442#issuecomment-1149919413

Comment:
I believe this was caused by a recent update of `spdlog`, which both `nheko` and `mtxclient` rely on. Only `nheko` was rebuilt against the new version as `spdlog` was not explicitly listed in `makedepends` of `mtxclient` and it was only pulled indirectly as a dependency of `coeurl`. I'm opening a pull request to address this.

Re: mtxclient causes nheko to segfault

[balejk]

[-- Attachment #1: Type: text/plain, Size: 623 bytes --]

New comment by balejk on void-packages repository

https://github.com/void-linux/void-packages/issues/37442#issuecomment-1150021297

Comment:
Never mind, I didn't realize that the dependency on `spdlog` was introduced to `mtxclient` only after its latest release. Now I think the problem is connected with the recent update of `json-c++`, which also seems to be what the backtrace implies. My understanding is limited, but is it possible that the problem was caused by the `nheko` rebuild (required because of the `spdlog` update) which used the new version of `json-c++` while `mtxclient` is built with the older version?

Re: mtxclient causes nheko to segfault

[deepbluev7]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

New comment by deepbluev7 on void-packages repository

https://github.com/void-linux/void-packages/issues/37442#issuecomment-1150420204

Comment:
Yes, nlohmann/json is a header only lib with afaik no ABI stability. So if it changes minor version, it will generate different code in different files, where it was included. That mismatch can then cause crashes because inlined functions call the wrong noninlined code or so.

Re: mtxclient causes nheko to segfault

[deepbluev7]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

New comment by deepbluev7 on void-packages repository

https://github.com/void-linux/void-packages/issues/37442#issuecomment-1150420204

Comment:
Yes, nlohmann/json is a header only lib with afaik no ABI stability. So if it changes minor version, it will generate different code in different files, where it was included. That mismatch can then cause crashes because inlined functions call the wrong noninlined code, class members are at different offsets or other issues.

Re: mtxclient causes nheko to segfault

[kartikynwa]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

New comment by kartikynwa on void-packages repository

https://github.com/void-linux/void-packages/issues/37442#issuecomment-1152890510

Comment:
Was facing the same issue and rebuilding mtxclient fixed it. Thanks for posting the solution.

Re: [ISSUE] [CLOSED] mtxclient causes nheko to segfault

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 944 bytes --]

Closed issue by RunningDroid on void-packages repository

https://github.com/void-linux/void-packages/issues/37442

Description:
<!-- Don't request update of package. We have a script for that. https://repo-default.voidlinux.org/void-updates/void-updates.txt. However, a quality pull request may help. -->
### System

* xuname:  
  Void 5.15.45_1 x86_64 GenuineIntel uptodate rrmFFFFFFFFFFFFFFFF
* package:  
  mtxclient-0.7.0_1
  nheko-0.9.2_2

### Expected behavior
Not segfaulting when viewing a room in nheko

### Actual behavior
Segfaulting when viewing a room in nheko

### Steps to reproduce the behavior
1. launch nheko
2. try to view a room

Rebuilding mtxclient fixes this, but as near as I can tell the only dependency that's been updated is [openssl](https://github.com/void-linux/void-packages/commit/134c645bd4fd68c6669f917a10a4bd7e6df7fd0e) so I don't know why it fixes it.

Related: Nheko-Reborn/nheko#1083